[scm-migration-dev] cr for HdrChk

2007-09-06 Thread Forrest Wu
Stephen Lau ??: > Forrest Wu wrote: > >> Hi steve, >> >> I am a little bit confusion with this. For TeamWare, how HdrChk.py catch >> a file without #ident error? On the other hand, for Mercurial, how >> HdrChk.py catch a file with #ident error? Because o

[scm-migration-dev] cr for HdrChk

2007-09-05 Thread Forrest Wu
Hi steve, I am a little bit confusion with this. For TeamWare, how HdrChk.py catch a file without #ident error? On the other hand, for Mercurial, how HdrChk.py catch a file with #ident error? Because of HdrChk.py doesn't know what is the game role for the given file. HdrChk.py What does #207 f

[scm-migration-dev] Modification of HdrChk for review

2007-08-22 Thread Forrest Wu
> Hi Forrest, > Sorry for the late reply. I'm not keen on making an almost > duplicate hdrchk2.py from hdrchk.py and relying on passing noident > around. I thought we had discussed having hdrchk only validate #ident > if one existed rather than conditionalising based on which SCM it gets

[scm-migration-dev] Modification of HdrChk for review

2007-08-14 Thread Forrest Wu
Stephen Lau wrote: > Forrest Wu wrote: >> Stephen Lau wrote: >>> Hi Forrest, >>> digging up a really old thread here. :) Did you ever integrate >>> this into the onnv-scm tree? >>> >> No. I haven't put it back. Don't know if

[scm-migration-dev] Modification of HdrChk for review

2007-08-08 Thread Forrest Wu
Stephen Lau wrote: > Forrest Wu wrote: >> Stephen Lau wrote: >>> Hi Forrest, >>> digging up a really old thread here. :) Did you ever integrate >>> this into the onnv-scm tree? >>> >> No. I haven't put it back. Don't know if

[scm-migration-dev] Modification of HdrChk for review

2007-08-07 Thread Forrest Wu
Stephen Lau wrote: > Hi Forrest, > digging up a really old thread here. :) Did you ever integrate this > into the onnv-scm tree? > No. I haven't put it back. Don't know if you accept my solution on this. > cheers, > steve > > Forrest Wu wrote: >

[scm-migration-dev] Re: Modification of HdrChk for review

2007-04-26 Thread Forrest Wu
x27;t need to be modified. Also, both Teamware and Mercurial share the check module code. The user interface like: Teamware: wx hdrchk Mercurial : Cadmium Hdrchk Anything I am missing, please give me your feedback. -- Thanks, Forrest Wu, Sun China Engineering & Research +86 10 62673294 http://blogs.sun.com/forrest

[scm-migration-dev] Re: Modification of HdrChk for review

2007-04-25 Thread Forrest Wu
I attach the webrev. Please get it for review. Sorry for inconvenient. Richard Lowe wrote: > Forrest Wu wrote: > >> Hi Rich and Stephen, > > Steve, can you take this? > >> I got a webrev of mofication of HdrChk.py in Check module and the >> relevant test c

[scm-migration-dev] Modification of HdrChk for review

2007-04-25 Thread Forrest Wu
OK One issue I run across is I can't put the webrev to cr.grommit.com, although I have created a codereview account in it. Any idea? $ scp -r ./webrev forrest at cr.grommit.com:webrev-HdrChk ssh: cr.grommit.com: node name or service name not known lost connection -- Thanks, Forrest Wu, S