Hi,
Please review:
489 webrev with new files in teamware generates errors
http://cr.opensolaris.org/~nbush/scm-migration/489/webrev/
Thanks,
--Nathan
Richard Lowe wrote:
> Nathan Bush writes:
>
>> Richard Lowe wrote:
>>> Nathan Bush writes:
>>>
>>>> Hi,
>>>>
>>>> Please review:
>>>> http://cr.opensolaris.org/~nbush/scm-migration/483/webrev/
>>>>
>
Richard Lowe wrote:
> Nathan Bush writes:
>
>> Hi,
>>
>> Please review:
>> http://cr.opensolaris.org/~nbush/scm-migration/483/webrev/
>>
>> This change should address all of the following bugs:
>> 465 webrev permission display fails for files i
Hi,
Please review:
http://cr.opensolaris.org/~nbush/scm-migration/483/webrev/
This change should address all of the following bugs:
465 webrev permission display fails for files in workspace root.
470 noise in webrev log for deleted files
471 "ERROR: set mode of" errors from webrev
483 webrev per
I assigned this directly to myself, so I don't think Bugzilla will
send a copy to the list.
--Nathan
Original Message
Subject: [Bug 483] New: webrev permission display change #372 has poor
performance
Date: Tue, 22 Apr 2008 20:27:23 -0700 (PDT)
From: bugzilla-dae...@np.grommit
Mike Kupfer wrote:
>>>>>> "Nathan" == Nathan Bush writes:
>
> Nathan> I think webrev could be changed to check that if the hg-active
> Nathan> output reflects a rename, but the first diff did not show it as
> Nathan> one, try a second time with t
Richard Lowe wrote:
> Mike Kupfer writes:
>
>>>>>>> "Nathan" == Nathan Bush writes:
>> Nathan> webrev tries to execute "hg diff -g -r $HG_PARENT $CWS/$DIR/$F".
>> Nathan> In the case of this file, there is a strange discrepancy
Richard Lowe wrote:
> Mike Kupfer writes:
>
>> I have a nightly cron job to generate the project webrev. This morning
>> I noticed errors like
>>
>> ERROR: set mode of
>> /net/athyra/export/kupfer/tonic/src/onnv-scm/webrev/raw_files/old/usr/src/pkgdefs/common_files/i.confupdate
[.
Sorry about this bug, I'll fix it under warranty. :)
Please review:
465 webrev permission display fails for files in workspace root.
http://cr.opensolaris.org/~nbush/scm-migration/465/webrev/
Thanks,
--Nathan
James Carlson wrote:
> Nathan Bush writes:
>> James Carlson wrote:
>>> Nathan Bush writes:
>>>> Proposed fix:
>>>> http://cr.opensolaris.org/~nbush/scm-migration/372/webrev/
>>> 1525-1531,1596-1603: nit: indenting seems to get a little strange
&
James Carlson wrote:
> Nathan Bush writes:
>> Proposed fix:
>> http://cr.opensolaris.org/~nbush/scm-migration/372/webrev/
>
> 1525-1531,1596-1603: nit: indenting seems to get a little strange
> around here.
The preferred indenting style is not clear to me in these cases.
Hi,
I've finished my attempt at fixing:
372 webrev does not display executable bit change
Proposed fix:
http://cr.opensolaris.org/~nbush/scm-migration/372/webrev/
Sample execution:
http://cr.opensolaris.org/~nbush/scm-migration/372/sample/
The sample directory contains sample webrevs that illus
Richard Lowe wrote:
> Nathan Bush writes:
>> Sorry, forgot the revised URL:
>> http://cr.opensolaris.org/~nbush/scm-migration/448/webrev.v2/
>
> That looks ok to me.
Thanks for the review. Pushing it now...
--Nathan
Nathan Bush wrote:
> Richard Lowe wrote:
>> Nathan Bush writes:
>>
>>> Rich (since we discussed this one already) or anyone else, please review:
>>>
>>> 448 webrev should use Hg's ui.username property to identify preparer
>>> http://cr.ope
Richard Lowe wrote:
> Nathan Bush writes:
>
>> Rich (since we discussed this one already) or anyone else, please review:
>>
>> 448 webrev should use Hg's ui.username property to identify preparer
>> http://cr.opensolaris.org/~nbush/scm-migration/448/webrev/
>
Rich (since we discussed this one already) or anyone else, please review:
448 webrev should use Hg's ui.username property to identify preparer
http://cr.opensolaris.org/~nbush/scm-migration/448/webrev/
Thanks,
--Nathan
Great, thanks!
--Nathan
Mark J. Nelson wrote:
> I like this better, and am OK with the changes.
>
> --Mark
>
> On Thu, 13 Mar 2008, Nathan Bush wrote:
>
>> Date: Thu, 13 Mar 2008 20:03:25 -0700
>> From: Nathan Bush
>> To: Mark J. Nelson
>>
lt; $ofile > $WDIR/$DIR/$F-.html
---
> source_to_html Old $PP < $ofile > $WDIR/$DIR/$F-.html
--Nathan
Nathan Bush wrote:
> #3 is also a simple change, only one character: $P vs $PP.
>
> The reason I say it is a matter of opinion is that there is a good
> argumen
; for files in the root
> directory.
>
> But why not fix #3?
>
> --Mark
>
>
>
> On Tue, 11 Mar 2008, Nathan Bush wrote:
>
>> Date: Tue, 11 Mar 2008 22:42:43 -0700
>> From: Nathan Bush
>> To: scm-migration-dev at opensolaris.org
>> Subject
Hi,
Please review:
446 webrev creates inconsistent HTML document titles
http://cr.opensolaris.org/~nbush/scm-migration/446/webrev/
You can see the fix in action in the above webrev itself.
Thanks,
--Nathan
Richard Lowe wrote:
> Nathan Bush writes:
>
>> Hi,
>>
>> I need a code review for:
>> 423 questionable format for rename-only changes in hg webrev
>>
>> The change to webrev is:
>> http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/
>&g
Hi,
I need a code review for:
423 questionable format for rename-only changes in hg webrev
The change to webrev is:
http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/
Here is sample run against a test environment. This shows an
example of each possible type of file change in the index:
Nathan Bush wrote:
> Mark J. Nelson wrote:
>> It's good enough, or if you felt like polishing a little bit more, you
>> could also typset OLDDIR/NEWDIR variables in build_old_new, because each
>> called function repeatedly uses the same constructs
>>
>>
Mark J. Nelson wrote:
>
Please review:
421 webrev: clean up global vars vs. function params
http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
>>>
>>> It seems like you should either remove all of the typeset
>>> declarations from build_old_new, or from each of the
>>> bui
Mark J. Nelson wrote:
>
>> Please review:
>> 421 webrev: clean up global vars vs. function params
>> http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
>
> It seems like you should either remove all of the typeset declarations
> from build_old_new, or from each of the build_old_new_blah
Please review:
421 webrev: clean up global vars vs. function params
http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/
Thanks,
--Nathan
Mike Kupfer wrote:
> I took at look at the webrev; it looks okay. Thanks for cleaning up the
> misuse of $PDIR, $PF, $DIR, and $F. And thanks for the summary writeup
> in Bugzilla!
You're welcome. Thanks for the review.
>
> I did notice some (pre-existing) cruftiness in the build_old_new*
> f
Please review and/or try out:
392 webrev screws up on removed files again.
http://cr.opensolaris.org/~nbush/scm-migration/392/webrev/
Thanks,
--Nathan
This small change is to address:
339 webrev of a deleted file could be clearer
It will print an italic annotation of "(deleted)" next to any such
file, in style similar to how renamed files are already treated.
The first link below is for the change I made, the second shows it
in action:
http://c
Richard Lowe wrote:
> Nathan Bush writes:
>
>> Please review my small fix for:
>> 374 setting CODEMGR_WS confuses webrev
>>
>> The webrev is available at:
>> http://cr.opensolaris.org/~nbush/scm-migration/374/webrev/
>>
>
> That looks right to
Please review my small fix for:
374 setting CODEMGR_WS confuses webrev
The webrev is available at:
http://cr.opensolaris.org/~nbush/scm-migration/374/webrev/
Thanks,
--Nathan
Vladimir Marek wrote:
> I would like to publish proposed fix, how do I, please, setup comments
> for given change ? (something like
>
>123 this is the bug
Enter your comments in that form when you run 'hg commit' in your child
repository. Then run "webrev". It will run 'hg-active' for you,
Richard Lowe wrote:
> Mike Kupfer writes:
>> * Webrev
>>
>> These do not appear to be stoppers for SFW:
>>
>> 374 P3 setting CODEMGR_WS confuses webrev
>
> I'll look at this soon, if I really have to.
Don't worry, I'm already working on it.
>> 372 P3 webrev does not display executab
Mike Kupfer wrote:
> Okay, I've updated nightly.sh and posted the updated the webrev (still
> at http://cr.opensolaris.org/~kupfer/6609947/).
>
> Changes since yesterday:
>
> - I made all my changes use "-a $mail_msg_file >> $LOGFILE"
>
> - I added a comment about sdrop's depending on README.ope
Mike Kupfer wrote:
> I'd like to get a formal review of
>
> 6609947 nightly: findunref, then sdrop
Mike,
I have three comments:
1) Why move the mktpl step at all? It seems that it was already
happening before findunref. The new location introduces two
consecutive if-statements (lines 2130
Stephen Lau wrote:
> Nathan Bush wrote:
>> Stephen Lau wrote:
>>> Nathan Bush wrote:
>>>> Stephen Lau wrote:
>>>>> Nathan Bush wrote:
>>>>>> Stephen Lau wrote:
>>>>>>> 2) We throw a "Header guard does not m
Stephen Lau wrote:
> Nathan Bush wrote:
>> Stephen Lau wrote:
>>> Nathan Bush wrote:
>>>> Stephen Lau wrote:
>>>>> 2) We throw a "Header guard does not match filename" on a header
>>>>> guard that looks like: __FOO_H__ (for fo
Stephen Lau wrote:
> Nathan Bush wrote:
>> Stephen Lau wrote:
>>> 2) We throw a "Header guard does not match filename" on a header
>>> guard that looks like: __FOO_H__ (for foo.h) or other things that
>>> don't strictly match _FOO_H_
>&g
Stephen Lau wrote:
> 2) We throw a "Header guard does not match filename" on a header guard
> that looks like: __FOO_H__ (for foo.h) or other things that don't
> strictly match _FOO_H_
> Is this the best error message? Intuitively, I would think it should be
> "Invalid or missing header guard"
39 matches
Mail list logo
