[scm-migration-dev] code review: remote webrev delete

2008-12-12 Thread Vladimir Kotal
Mark J. Nelson wrote: > I don't have any other comments. > After expanding the set of test cases and doing retesting I have bumped into interesting feature of ksh (and a bug in the script): #!/usr/bin/ksh fce1() { typeset -r host_spec=$1 } fce2() { typeset -r host_spec=$1 } fc

[scm-migration-dev] code review: remote webrev delete

2008-12-10 Thread Mark J. Nelson
I don't have any other comments. --Mark webrev is here: http://cr.opensolaris.org/~vkotal/webrev_delete-6771203.onnv/ >> The date in the .TH section of the manpage should be updated. > > grr, I always forget to update this one. fixed. > >> webrev.sh: >> 171, 236: When do you ever

[scm-migration-dev] code review: remote webrev delete

2008-12-05 Thread Vladimir Kotal
Mark J. Nelson wrote: >>> webrev is here: >>>http://cr.opensolaris.org/~vkotal/webrev_delete-6771203.onnv/ > > The date in the .TH section of the manpage should be updated. grr, I always forget to update this one. fixed. > webrev.sh: > 171, 236: When do you ever call this inappropriately?

[scm-migration-dev] code review: remote webrev delete

2008-12-04 Thread Vladimir Kotal
This one still needs code reviewers. Again, anyone bored or with ksh/webrev mindset can take a look. Thanks, v. > webrev is here: >http://cr.opensolaris.org/~vkotal/webrev_delete-6771203.onnv/

[scm-migration-dev] code review: remote webrev delete

2008-12-04 Thread Mark J. Nelson
Vladimir Kotal wrote: > > > This one still needs code reviewers. Again, anyone bored or with > ksh/webrev mindset can take a look. > > Thanks, > > > v. > >> webrev is here: >>http://cr.opensolaris.org/~vkotal/webrev_delete-6771203.onnv/ The date in the .TH section of the manpage should

[scm-migration-dev] code review: remote webrev delete

2008-11-18 Thread Vladimir Kotal
Hi all, webrev upload might be nice but sometimes it is necessary to un-clobber the webrev area or do a sync from scratch (additions/removals of files in repo). To be able to do so without sftp(1), I've reused already existing functionality in webrev.sh and made it available via new option -D.