Mark J. Nelson writes:
>
> My apologies. I didn't look and see that the README.tools contained
> actual command examples with wildcard expansion, rather than a description
> of the exception_list* source files, which is in a different file anyway.
>
> I'll fix that.
That's it exactly; thanks.
Mark J. Nelson writes:
>
> The changes in usr/src/tools/findunref/Makefile process multiple
> exception_list* files (appropriately plural) into one exception_list,
> which is then passed to the C version of findunref.
Correct.
> It works, I tested it.
No dispute.
> There was some debate abo
Mark J. Nelson writes:
> >> Mark asked me send this along on his behalf, since he's out.
> > [...]
> >>>http://cr.opensolaris.org/~richlowe/toolsreview
> >
> > One thing that jumps out at me is that usr/src/tools/README.tools
> > describes using "exception_list*" with findunref, but that multip
e:
> Date: Wed, 09 Jul 2008 15:10:14 -0400
> From: James Carlson
> To: Mark J. Nelson
> Cc: scm-migration-dev at opensolaris.org
> Subject: Re: [scm-migration-dev] scm-migration tools code review followup
>
> Mark J. Nelson writes:
>>
>> The changes in usr/sr
Wed, 09 Jul 2008 13:51:46 -0400
> From: James Carlson
> To: Mark J. Nelson
> Cc: scm-migration-dev at opensolaris.org
> Subject: Re: [scm-migration-dev] scm-migration tools code review followup
>
> Mark J. Nelson writes:
>>>> Mark asked me send this along on his
>> Mark asked me send this along on his behalf, since he's out.
> [...]
>>>http://cr.opensolaris.org/~richlowe/toolsreview
>
> One thing that jumps out at me is that usr/src/tools/README.tools
> describes using "exception_list*" with findunref, but that multiple
> list change is gone with the
Richard Lowe writes:
>
> Mark asked me send this along on his behalf, since he's out.
[...]
> >http://cr.opensolaris.org/~richlowe/toolsreview
One thing that jumps out at me is that usr/src/tools/README.tools
describes using "exception_list*" with findunref, but that multiple
list change is g
Mark asked me send this along on his behalf, since he's out.
> Thank you for taking the time to review these changes.
>
> So the pages aren't pretty, but the information is (I believe) accurate.
>
> Everything on the "must fix" list is either fixed, or will be, or is
> still there as a reminder f
