[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-29 Thread Bill Sommerfeld
On Fri, 2008-02-29 at 18:32 -0500, Richard Lowe wrote: > Worst case, I'd have to ask for some input to complete the merge > accurately but I don't think bringovercheck and sccscheck would be > that bad to merge in (unless I'm missing something). so, the following webrev is not yet tested but is r

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-29 Thread Richard Lowe
Bill Sommerfeld writes: > On Thu, 2008-02-28 at 15:14 -0800, Mike Kupfer wrote: >> > "Bill" == Bill Sommerfeld writes: >> >> Bill> Last I checked, the bugs that spawned bringovercheck have pretty >> Bill> much all been slain, so it could be retired now even for teamware. >> >> If there's s

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-29 Thread Bill Sommerfeld
On Thu, 2008-02-28 at 15:14 -0800, Mike Kupfer wrote: > > "Bill" == Bill Sommerfeld writes: > > Bill> Last I checked, the bugs that spawned bringovercheck have pretty > Bill> much all been slain, so it could be retired now even for teamware. > > If there's stuff that can be done now and it

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-28 Thread Richard Lowe
Mike Kupfer writes: >> "Bill" == Bill Sommerfeld writes: > > Bill> Last I checked, the bugs that spawned bringovercheck have pretty > Bill> much all been slain, so it could be retired now even for teamware. > > If there's stuff that can be done now and it doesn't depend on the other > SCM Mi

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-28 Thread Richard Lowe
Mike Kupfer writes: >> "JimW" == Jim Walker writes: > > Bill> what I think would make sense would be to set a different, > Bill> non-teamware-specific variable. So a teamware workspace would get > Bill> CODEMGR_WS and the TBD additional variable; mercurial would just get > Bill> the TBD add

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-28 Thread Mike Kupfer
> "Rich" == Richard Lowe writes: Bill> usr/src/tools/Makefile.tools: Bill> Bill> WES-14 Lines 66-73: might INS.pyfile belong in Makefile.master (we're Bill> going to have python elsewhere in ON at some point, right?) Rich> I wasn't sure what to do about that, so I took the more localized Ric

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-28 Thread Mike Kupfer
> "Bill" == Bill Sommerfeld writes: Bill> Last I checked, the bugs that spawned bringovercheck have pretty Bill> much all been slain, so it could be retired now even for teamware. If there's stuff that can be done now and it doesn't depend on the other SCM Migration changes, I'd rather that

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-28 Thread Mike Kupfer
> "JimW" == Jim Walker writes: Bill> what I think would make sense would be to set a different, Bill> non-teamware-specific variable. So a teamware workspace would get Bill> CODEMGR_WS and the TBD additional variable; mercurial would just get Bill> the TBD additional variable. JimW> The adv

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-26 Thread James Carlson
Richard Lowe writes: > Bill Sommerfeld writes: > > what I think would make sense would be to set a different, > > non-teamware-specific variable. So a teamware workspace would get > > CODEMGR_WS and the TBD additional variable; mercurial would just get the > > TBD additional variable. > > I'll l

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-26 Thread Richard Lowe
Bill Sommerfeld writes: >> > WES-3 Should we set CODEMGR_WS in the non-teamware case? >> >> We've been back and forth a few times on the use of CODEMGR_WS, my >> view (which I think was shared by stevel) is that CODEMGR_WS, while >> originally used by and for teamware, has effectively become g

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-26 Thread Bill Sommerfeld
> > WES-3 Should we set CODEMGR_WS in the non-teamware case? > > We've been back and forth a few times on the use of CODEMGR_WS, my > view (which I think was shared by stevel) is that CODEMGR_WS, while > originally used by and for teamware, has effectively become generic at > this point, and th

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-26 Thread Jim Walker
> Bill Sommerfeld writes: WES-3 Should we set CODEMGR_WS in the non-teamware case? >>> We've been back and forth a few times on the use of CODEMGR_WS, my >>> view (which I think was shared by stevel) is that CODEMGR_WS, while >>> originally used by and for teamware, has effectively become g

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-26 Thread Richard Lowe
Bill Sommerfeld writes: > Jim Carlson asked me to review what I could of the big webrev at: > > http://cr.opensolaris.org/~kupfer/onnv-scm/ I'm probably going to have more comments on these, but I'm going to respond to those I can respond to quickly now. > This is my initial batch of comments

[scm-migration-dev] sommerfeld's comments on onnv-scm webrev

2008-02-26 Thread Bill Sommerfeld
Jim Carlson asked me to review what I could of the big webrev at: http://cr.opensolaris.org/~kupfer/onnv-scm/ This is my initial batch of comments, focussing on changes to existing scripts in reverse alphabetical order.. usr/src/tools/scripts/xref.sh: WES-1 detect_scm(): shouldn't this be i