Re: [Scons-dev] getting changes accepted

2013-09-26 Thread anatoly techtonik
If each of these small changes requires some time foe testing and time for review, then it is better to schedule that with separate pull requests. If these are trivial, it is more convenient to merge it in one bunch. -- anatoly t. On Thu, Sep 26, 2013 at 12:05 PM, Tom Tanner (BLOOMBERG/

Re: [Scons-dev] getting changes accepted

2013-09-26 Thread Gary Oberbrunner
On Thu, Sep 26, 2013 at 6:16 AM, anatoly techtonik techto...@gmail.comwrote: If each of these small changes requires some time foe testing and time for review, then it is better to schedule that with separate pull requests. If these are trivial, it is more convenient to merge it in one bunch.

Re: [Scons-dev] getting changes accepted

2013-09-26 Thread Gary Oberbrunner
On Thu, Sep 26, 2013 at 8:11 AM, alexandre.feb...@gmail.com wrote: Hi, By the way, did you review mine? ( https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff ) I saw it, Alexandre -- it's definitely in the queue, and on simple inspection it looks OK. I

Re: [Scons-dev] getting changes accepted

2013-09-26 Thread alexandre . feblot
I used the test case described in the bug, but I have nothing to integrate in scons test suite. Le 26 sept. 2013 à 14:16, Gary Oberbrunner ga...@oberbrunner.com a écrit : On Thu, Sep 26, 2013 at 8:11 AM, alexandre.feb...@gmail.com wrote: Hi, By the way, did you review mine? (

Re: [Scons-dev] getting changes accepted

2013-09-26 Thread Bill Deegan
Here's the wiki page for the mercurial flow for submitting bugs. http://www.scons.org/wiki/SconsMercurialWorkflows -Bill On Thu, Sep 26, 2013 at 5:22 AM, alexandre.feb...@gmail.com wrote: I used the test case described in the bug, but I have nothing to integrate in scons test suite. Le 26