Thanks Bill,
I added the template back. I will update the PR with information about the
tests that are fixed with the changed I provided. I did see you wanted a test
for the executor change. I provided that information with an existing test that
no passes. I will clarify with the next update to
Also you deleted the checklist in the pull request template.
Please add a blurb to src/changes.txt
This is all the normal stuff we ask for all pull requests. That's why it's
in the template so hopefully I can avoid asking each and every contributor
to do the same thing..
On Tue, Jul 24, 2018 at
I put some feedback on the PR almost as soon as you submitted it that you
have yet to respond to.
We need a test which fails under normal scons before your changes and
passes after, as we do with pretty much any and all pull requests.
-Bill
On Mon, Jul 23, 2018 at 5:42 PM, Jason Kenny wrote:
