Hi Bill,
Wanted to know what are your concerns about PR 3155. It current addresses and
fixes a number of small issues ( mostly on windows) the pass rate is better.
Any reason for not merging this?
Jason
___
Scons-dev mailing list
Scons-dev@scons.org
h
I put some feedback on the PR almost as soon as you submitted it that you
have yet to respond to.
We need a test which fails under normal scons before your changes and
passes after, as we do with pretty much any and all pull requests.
-Bill
On Mon, Jul 23, 2018 at 5:42 PM, Jason Kenny wrote:
>
Also you deleted the checklist in the pull request template.
Please add a blurb to src/changes.txt
This is all the normal stuff we ask for all pull requests. That's why it's
in the template so hopefully I can avoid asking each and every contributor
to do the same thing..
On Tue, Jul 24, 2018 at 8
the PR comments. I will tag
you so it should notify you.
Jason
From: Scons-dev on behalf of Bill Deegan via
Scons-dev
Sent: Tuesday, July 24, 2018 10:21 AM
To: SCons developer list
Cc: Bill Deegan
Subject: Re: [Scons-dev] PR 3155
Also you deleted the checklist
