Re: [SeaBIOS] [Qemu-stable] problems with freeBSD

2013-03-08 Thread Gerd Hoffmann
On 03/08/13 08:47, Paolo Bonzini wrote: FWIW I find the binaries in git to be a PITA. I submitted a patch in January to fix the VGA BIOS but it's still broken in git. The one installed in /usr/share/qemu is fine, but whenever I build qemu from git I have to remember to *remove* the one in the

Re: [SeaBIOS] [Qemu-stable] problems with freeBSD

2013-03-08 Thread Paolo Bonzini
Il 08/03/2013 09:20, Gerd Hoffmann ha scritto: On 03/08/13 08:47, Paolo Bonzini wrote: FWIW I find the binaries in git to be a PITA. I submitted a patch in January to fix the VGA BIOS but it's still broken in git. The one installed in /usr/share/qemu is fine, but whenever I build qemu from git

Re: [SeaBIOS] [Qemu-stable] problems with freeBSD

2013-03-08 Thread David Woodhouse
On Fri, 2013-03-08 at 08:47 +0100, Paolo Bonzini wrote: Wasn't that a fix for the SeaBIOS VGA BIOS? The one in qemu.git is still built from the Bochs VGA BIOS. No, it was for Bochs VGA BIOS. http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg03650.html -- dwmw2 smime.p7s Description:

Re: [SeaBIOS] [Qemu-stable] problems with freeBSD

2013-03-08 Thread Gerd Hoffmann
Did it? This is F18: $ rpm -q --requires qemu-system-x86|grep bios seabios-bin = 0.6.0-2 sgabios-bin vgabios = 0.6c-2 Oops. There is a seavgabios-bin package too, and I through cole switched qemu over, but apparently this didn't happen (or maybe in rawhide only) ... cheers, Gerd

Re: [SeaBIOS] [PATCH 0/2][RFC] Remove BDAT from ACPI interface

2013-03-08 Thread Gerd Hoffmann
On 03/07/13 04:04, Kevin O'Connor wrote: This patch changes SeaBIOS to pass the PCI regions via a dynamically updated SSDT instead of via the BDAT memory reference system. This change will likely make it easier to port the ACPI tables to QEMU. This patch has only been lightly tested. Looks

Re: [SeaBIOS] [Qemu-devel] problems with freeBSD

2013-03-08 Thread Laszlo Ersek
On 03/08/13 04:35, Kevin O'Connor wrote: On Thu, Mar 07, 2013 at 09:43:04AM +0100, Aurelien Jarno wrote: On Wed, Mar 06, 2013 at 07:53:51PM -0500, Kevin O'Connor wrote: That change is definitely just build related - I don't see how it could impact the final SeaBIOS binary. How did you

Re: [SeaBIOS] [Qemu-devel] [Qemu-stable] problems with freeBSD

2013-03-08 Thread Kevin O'Connor
On Fri, Mar 08, 2013 at 12:03:15AM +0800, Peter Maydell wrote: Earlier in this thread it's been stated that this often produces subtly broken blobs... I think there have been some far reaching conclusions in this thread based on incorrect premises. SeaBIOS has had problems with

Re: [SeaBIOS] [coreboot] [SimNow] PORT_IRQ_STAT register is 0 in ahci_port_setup

2013-03-08 Thread WANG Siyuan
On 03/08/13 21:27, Kevin O'Connor wrote: On Fri, Mar 08, 2013 at 11:48:57AM +0800, WANG Siyuan wrote: According to this piece of code in src/ahci.c, seabios fails to set DMA or PIO on ahci. PORT_IRQ_STAT is 0. Thanks. Can you send a patch with the proposed fix? -Kevin I am sorry, but I

Re: [SeaBIOS] [Qemu-devel] [Qemu-stable] problems with freeBSD

2013-03-08 Thread Peter Stuge
Kevin O'Connor wrote: I don't believe that dictating one true compiler or one true blob is necessary or desirable. Sure. The point isn't to have only one correct way, but to have reliable results in the common case. A reference toolchain and a reference blob both help accomplish that, but

[SeaBIOS] [PATCH] Add additional dependency checks to Makefile.

2013-03-08 Thread Kevin O'Connor
Generate dependencies on pre-processed ASL files. This ensures that a change to an imported dsdt file will cause iasl to be called. Make .config depend on Kconfig files. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- Makefile | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[SeaBIOS] [PATCH 1/4] shadow: Don't use PCIDevices list in make_bios_readonly().

2013-03-08 Thread Kevin O'Connor
The make_bios_readonly() call is invoked from resume. The PCIDevices list is only valid during POST. Cache the necessary PCI BDF ids so that PCIDevices isn't needed. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/shadow.c | 34 +- 1 file changed, 13

[SeaBIOS] [PATCH 2/4] smm: Don't use PCIDevices list in smm_setup().

2013-03-08 Thread Kevin O'Connor
The smm_setup() call is invoked from resume. The PCIDevices list is only valid during POST. Cache the necessary PCI BDF ids so that PCIDevices isn't needed. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/paravirt.c | 1 + src/smm.c | 66

[SeaBIOS] [PATCH 4/4] Use VARVERIFY32INIT on global variables that point to tmp memory.

2013-03-08 Thread Kevin O'Connor
Enable the recently added build check on global variables that are (or contain) pointers to memory allocated by malloc_tmp(). This helps detect cases where temporary memory is accessed after POST. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/boot.c| 4 ++-- src/pci.c | 2 +-