Re: [SeaBIOS] [PATCH 0/2][RFC] Reduce mptable code dependencies

2013-03-18 Thread Gleb Natapov
On Mon, Mar 18, 2013 at 08:38:59PM -0400, Kevin O'Connor wrote: > These two patches should make the mptable code easier to move out of > SeaBIOS and into QEMU. The first patch stops the mptable from > describing PCI-to-PCI bridges - I don't believe it was the goal (or a > requirement) of the mptab

Re: [SeaBIOS] VGA Option ROM not set up correctly when loaded by coreboot and not SeaBIOS

2013-03-18 Thread Denis 'GNUtoo' Carikli
On Mon, 18 Mar 2013 15:13:32 +0100 Christian Gmeiner wrote: > 2013/3/18 Paul Menzel : > > Dear SeaBIOS, > > > > > > using the AMD/ATI based ASRock E350M1 [1] with coreboot and SeaBIOS > > 1.7.2.1 as a payload and GRUB 2 (1.99-27 from Debian Sid/unstable) > > on the hard drive, letting coreboot lo

Re: [SeaBIOS] [PATCH 0/2][RFC] Reduce mptable code dependencies

2013-03-18 Thread Gleb Natapov
On Tue, Mar 19, 2013 at 02:09:05AM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > Thoughts? > > I wish this effort could go into coreboot instead, so that it could > benefit more than only one machine. > The code is QEMU specific. What other machines are you talking about? --

Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-18 Thread li guang
在 2013-01-10四的 19:57 +0100,Vasilis Liaskovitis写道: > > > > > > IIRC q35 supports memory hotplug natively (picked up in some > > > discussion). Is that correct? > > > > > From previous discussion I also understand that q35 supports native > > hotplug. > > Sections 5.1 and 5.2 of the spec describ

[SeaBIOS] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-18 Thread Alex Williamson
As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control register. Signed-off-by: Alex Williamson --- src

Re: [SeaBIOS] [PATCHv2] acpi: make default DSDT optional

2013-03-18 Thread Peter Stuge
Michael S. Tsirkin wrote: > Also, in qemu I don't think we want to carry around code we never use. I'm sure you know that the SeaBIOS world is a lot more than just QEMU, so probably it makes sense to not change whatever the default was before your change. I get the impression that you have. //Pe

Re: [SeaBIOS] [PATCH 0/2][RFC] Reduce mptable code dependencies

2013-03-18 Thread Peter Stuge
Kevin O'Connor wrote: > Thoughts? I wish this effort could go into coreboot instead, so that it could benefit more than only one machine. //Peter ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 0/2] Fix booting tcm_vhost + seabios

2013-03-18 Thread Asias He
On Mon, Mar 18, 2013 at 02:26:14PM -0700, Nicholas A. Bellinger wrote: > On Fri, 2013-03-15 at 09:45 +0800, Asias He wrote: > > Asias He (2): > > virtio-scsi: Set _DRIVER_OK flag before scsi target scanning > > virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} > > > > src/virtio-scsi.c

[SeaBIOS] [PATCH 2/2] mptable: Use same PCI irqs as ACPI code.

2013-03-18 Thread Kevin O'Connor
The ACPI code has a hardcoded list of PCI interrupts. Use that same list in the mptable code generation. This will ensure that both tables are in synch - it may also make the mptable easier to generate from QEMU. Also, move the irq0_override lookup outside of the irq loop. Signed-off-by: Kevin

[SeaBIOS] [PATCH 1/2] mptable: Don't describe pci-to-pci bridges.

2013-03-18 Thread Kevin O'Connor
It should not be necessary to describe PCI-to-PCI bridges in the mptable. (The mptable was designed to fit in ROM, so it seems unlikely that it would be used for bridges that could be dynamically added.) Describing only the root bus should make it easier to port this content into QEMU. Signed-of

[SeaBIOS] [PATCH 0/2][RFC] Reduce mptable code dependencies

2013-03-18 Thread Kevin O'Connor
These two patches should make the mptable code easier to move out of SeaBIOS and into QEMU. The first patch stops the mptable from describing PCI-to-PCI bridges - I don't believe it was the goal (or a requirement) of the mptable to describe bridges. The second patch synchs the list of PCI irqs be

Re: [SeaBIOS] [PATCH RFC dontapply] license: make acpi bits GPLv2 compatible

2013-03-18 Thread Kevin O'Connor
On Mon, Mar 18, 2013 at 04:14:27PM +0200, Michael S. Tsirkin wrote: > As an intermediate step in the process of moving acpi tables to qemu, we > need to make sure the code we'll be moving is GPLv2 compatible. > I think keeping the relevant files dual-license for a while is the best > way to do this

Re: [SeaBIOS] [PATCH 0/2] Fix booting tcm_vhost + seabios

2013-03-18 Thread Nicholas A. Bellinger
On Fri, 2013-03-15 at 09:45 +0800, Asias He wrote: > Asias He (2): > virtio-scsi: Set _DRIVER_OK flag before scsi target scanning > virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} > > src/virtio-scsi.c | 5 +++-- > src/virtio-scsi.h | 4 ++-- > 2 files changed, 5 insertions(+), 4 dele

Re: [SeaBIOS] VGA Option ROM not set up correctly when loaded by coreboot and not SeaBIOS

2013-03-18 Thread Paul Menzel
Am Montag, den 18.03.2013, 15:13 +0100 schrieb Christian Gmeiner: > 2013/3/18 Paul Menzel : > > using the AMD/ATI based ASRock E350M1 [1] with coreboot and SeaBIOS > > 1.7.2.1 as a payload and GRUB 2 (1.99-27 from Debian Sid/unstable) on > > the hard drive, letting coreboot load the VGA Option ROM

Re: [SeaBIOS] [PATCH] src/Kconfig: Spell »Option ROMs« uniformly as in Wikipedia [1]

2013-03-18 Thread Fred .
Wikipedia titles start with a capital letter, hence it is "Option ROM" but in the article, most references are "option ROM" and probably all references should be "option ROM". option being lowercase because it is an English word, and ROM being uppercase because it is an acronym. On Mon, Mar 18,

Re: [SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Paul Menzel
Am Montag, den 18.03.2013, 16:17 +0200 schrieb Michael S. Tsirkin: > On Mon, Mar 18, 2013 at 02:22:53PM +0100, Paul Menzel wrote: > > Am Montag, den 18.03.2013, 08:57 -0400 schrieb Kevin O'Connor: > > > On Mon, Mar 18, 2013 at 01:00:42PM +0200, Michael S. Tsirkin wrote: > > > > Since commit f7e4dd6

Re: [SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 02:22:53PM +0100, Paul Menzel wrote: > Am Montag, den 18.03.2013, 08:57 -0400 schrieb Kevin O'Connor: > > On Mon, Mar 18, 2013 at 01:00:42PM +0200, Michael S. Tsirkin wrote: > > > Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its > > Michael, thank you fo

Re: [SeaBIOS] VGA Option ROM not set up correctly when loaded by coreboot and not SeaBIOS

2013-03-18 Thread Christian Gmeiner
2013/3/18 Paul Menzel : > Dear SeaBIOS, > > > using the AMD/ATI based ASRock E350M1 [1] with coreboot and SeaBIOS > 1.7.2.1 as a payload and GRUB 2 (1.99-27 from Debian Sid/unstable) on > the hard drive, letting coreboot load the VGA Option ROM and disabling > »Option ROMs« in the menu »BIOS interf

[SeaBIOS] [PATCH RFC dontapply] license: make acpi bits GPLv2 compatible

2013-03-18 Thread Michael S. Tsirkin
As an intermediate step in the process of moving acpi tables to qemu, we need to make sure the code we'll be moving is GPLv2 compatible. I think keeping the relevant files dual-license for a while is the best way to do this, this way code and bufixes can be shared. When everything moves to QEMU and

[SeaBIOS] [PATCH] src/Kconfig: Spell »Option ROMs« uniformly as in Wikipedia [1]

2013-03-18 Thread Paul Menzel
Date: Mon, 18 Mar 2013 14:42:12 +0100 [1] http://en.wikipedia.org/wiki/Option_ROM Signed-off-by: Paul Menzel --- src/Kconfig | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index 3141069..5816cb4 100644 --- a/src/Kconfig +++ b/src

[SeaBIOS] VGA Option ROM not set up correctly when loaded by coreboot and not SeaBIOS

2013-03-18 Thread Paul Menzel
Dear SeaBIOS, using the AMD/ATI based ASRock E350M1 [1] with coreboot and SeaBIOS 1.7.2.1 as a payload and GRUB 2 (1.99-27 from Debian Sid/unstable) on the hard drive, letting coreboot load the VGA Option ROM and disabling »Option ROMs« in the menu »BIOS interfaces« config OPTIONROMS

Re: [SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Paul Menzel
Am Montag, den 18.03.2013, 08:57 -0400 schrieb Kevin O'Connor: > On Mon, Mar 18, 2013 at 01:00:42PM +0200, Michael S. Tsirkin wrote: > > Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its Michael, thank you for putting this in. As commit hashes are hard to memorize adding the sum

[SeaBIOS] [PATCHv4] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its own copy of DSDT, so let's not build in PIIX. This makes building in the DSDT an option, default to on (built-in). If no one complains for a while, we'll be able to switch it off and then maybe remove altogether. With CONFIG_AC

Re: [SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 02:03:42PM +0100, Laszlo Ersek wrote: > On 03/18/13 12:00, Michael S. Tsirkin wrote: > > Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its > > own copy of DSDT, so let's not build in PIIX. This makes building in > > the DSDT an option, default to on (buil

Re: [SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Laszlo Ersek
On 03/18/13 12:00, Michael S. Tsirkin wrote: > Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its > own copy of DSDT, so let's not build in PIIX. This makes building in > the DSDT an option, default to on (built-in). > For the builds bundled with qemu (where we _know_ qemu is > n

Re: [SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Kevin O'Connor
On Mon, Mar 18, 2013 at 01:00:42PM +0200, Michael S. Tsirkin wrote: > Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its > own copy of DSDT, so let's not build in PIIX. This makes building in > the DSDT an option, default to on (built-in). > For the builds bundled with qemu (wher

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 11:48:57AM +0100, Gerd Hoffmann wrote: > On 03/17/13 19:27, Michael S. Tsirkin wrote: > > With seabios built from source, and latest qemu, VMs hang during boot > > for me. Bisect points at this commit: > > 76e58028d28e78431f9de3cee0b3c88d807fa39d > > > > Reverting this hel

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Gerd Hoffmann
Hi, >> The values for the pci i/o windows are passed in a different way now. >> It used to be a reference to seabios-allocated memory (BDAT) with the >> location of that memory being added to the ssdt. Now that indirection >> is gone and seabios generates ssdt fields directly. The later makes

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 12:07:49PM +0100, Gerd Hoffmann wrote: > On 03/18/13 11:56, Michael S. Tsirkin wrote: > > On Mon, Mar 18, 2013 at 11:48:57AM +0100, Gerd Hoffmann wrote: > >> On 03/17/13 19:27, Michael S. Tsirkin wrote: > >>> With seabios built from source, and latest qemu, VMs hang during b

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Gerd Hoffmann
On 03/18/13 11:56, Michael S. Tsirkin wrote: > On Mon, Mar 18, 2013 at 11:48:57AM +0100, Gerd Hoffmann wrote: >> On 03/17/13 19:27, Michael S. Tsirkin wrote: >>> With seabios built from source, and latest qemu, VMs hang during boot >>> for me. Bisect points at this commit: >>> 76e58028d28e78431f9d

[SeaBIOS] [PATCHv3] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
Since commit f7e4dd6c18ccfbaf6cd2f5eaaed2b77cabc8a406 QEMU loads its own copy of DSDT, so let's not build in PIIX. This makes building in the DSDT an option, default to on (built-in). For the builds bundled with qemu (where we _know_ qemu is new enougth that it actually works) we can flip the swit

[SeaBIOS] Does SeaBIOS uses the BIOS interfaces itself?

2013-03-18 Thread Paul Menzel
Dear SeaBIOS folks, looking at $ more src/Kconfig […] config AHCI depends on DRIVES bool "AHCI controllers" default y help Support for AHCI disk code. […] disabling the »Drive interface« (which sets(?) `DRIVES`) in the menu BIOS interfaces, suppor

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 11:48:57AM +0100, Gerd Hoffmann wrote: > On 03/17/13 19:27, Michael S. Tsirkin wrote: > > With seabios built from source, and latest qemu, VMs hang during boot > > for me. Bisect points at this commit: > > 76e58028d28e78431f9de3cee0b3c88d807fa39d > > > > Reverting this hel

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Gerd Hoffmann
On 03/17/13 19:27, Michael S. Tsirkin wrote: > With seabios built from source, and latest qemu, VMs hang during boot > for me. Bisect points at this commit: > 76e58028d28e78431f9de3cee0b3c88d807fa39d > > Reverting this helps. Guest is stuck quite late, after > 'switching root' message, so this co

Re: [SeaBIOS] [PATCHv2] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 11:41:44AM +0100, Laszlo Ersek wrote: > comments in-line > > On 03/18/13 11:12, Michael S. Tsirkin wrote: > > QEMU now loads its own copy of DSDT, so let's not build in PIIX. > > This leaves building in the DSDT an option, default to off. > > If no one complains for a while

Re: [SeaBIOS] Minimal config for booting GRUB2 from SATA drive

2013-03-18 Thread Paul Menzel
Am Samstag, den 16.03.2013, 03:06 -0400 schrieb Kevin O'Connor: > On Fri, Mar 15, 2013 at 06:03:07PM +0100, Paul Menzel wrote: > > Am Donnerstag, den 14.03.2013, 19:35 -0400 schrieb Kevin O'Connor: > > > On Thu, Mar 14, 2013 at 03:57:00PM +0100, Paul Menzel wrote: > > > > > > I am using coreboot o

Re: [SeaBIOS] [PATCHv2] acpi: make default DSDT optional

2013-03-18 Thread Laszlo Ersek
comments in-line On 03/18/13 11:12, Michael S. Tsirkin wrote: > QEMU now loads its own copy of DSDT, so let's not build in PIIX. > This leaves building in the DSDT an option, default to off. > If no one complains for a while, we'll be able to > remove this altogether. > > Signed-off-by: Michael S

Re: [SeaBIOS] [PATCHv2] acpi: make default DSDT optional

2013-03-18 Thread Paul Menzel
Dear Michael, Am Montag, den 18.03.2013, 12:12 +0200 schrieb Michael S. Tsirkin: > QEMU now loads its own copy of DSDT, so let's not build in PIIX. for non-QEMU developers could you please add a version string or commit so it is known since when QEMU supports this? > This leaves building in the

Re: [SeaBIOS] [PATCHv2] acpi: make default DSDT optional

2013-03-18 Thread Gerd Hoffmann
On 03/18/13 11:12, Michael S. Tsirkin wrote: > QEMU now loads its own copy of DSDT, so let's not build in PIIX. > This leaves building in the DSDT an option, default to off. > If no one complains for a while, we'll be able to > remove this altogether. > > Signed-off-by: Michael S. Tsirkin > --- >

[SeaBIOS] [PATCHv2] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
QEMU now loads its own copy of DSDT, so let's not build in PIIX. This leaves building in the DSDT an option, default to off. If no one complains for a while, we'll be able to remove this altogether. Signed-off-by: Michael S. Tsirkin --- Changes from v1: - default the new option to y to r

Re: [SeaBIOS] [PATCH] acpi: make default DSDT optional

2013-03-18 Thread Gerd Hoffmann
On 03/18/13 09:23, Michael S. Tsirkin wrote: > On Sun, Mar 17, 2013 at 10:23:21PM -0400, Kevin O'Connor wrote: >> On Sun, Mar 17, 2013 at 08:32:34PM +0200, Michael S. Tsirkin wrote: >>> QEMU now loads its own copy of DSDT, so let's not build in PIIX. >>> This leaves building in the DSDT an option,

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Laszlo Ersek
On 03/18/13 09:24, Michael S. Tsirkin wrote: > On Sun, Mar 17, 2013 at 10:19:45PM -0400, Kevin O'Connor wrote: >> On Sun, Mar 17, 2013 at 08:27:36PM +0200, Michael S. Tsirkin wrote: >>> With seabios built from source, and latest qemu, VMs hang during boot >>> for me. Bisect points at this commit:

Re: [SeaBIOS] VM won't start since 76e58028d28e78431f9de3cee0b3c88d807fa39d

2013-03-18 Thread Michael S. Tsirkin
On Sun, Mar 17, 2013 at 10:19:45PM -0400, Kevin O'Connor wrote: > On Sun, Mar 17, 2013 at 08:27:36PM +0200, Michael S. Tsirkin wrote: > > With seabios built from source, and latest qemu, VMs hang during boot > > for me. Bisect points at this commit: > > 76e58028d28e78431f9de3cee0b3c88d807fa39d > >

Re: [SeaBIOS] [PATCH] acpi: make default DSDT optional

2013-03-18 Thread Michael S. Tsirkin
On Sun, Mar 17, 2013 at 10:23:21PM -0400, Kevin O'Connor wrote: > On Sun, Mar 17, 2013 at 08:32:34PM +0200, Michael S. Tsirkin wrote: > > QEMU now loads its own copy of DSDT, so let's not build in PIIX. > > This leaves building in the DSDT an option, default to off. > > If no one complains for a wh