Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-21 Thread Christensson, Magnus
Acked-by: Magnus Christensson M. -Original Message- From: seabios-boun...@seabios.org [mailto:seabios-boun...@seabios.org] On Behalf Of Michael S. Tsirkin Sent: Wednesday, March 20, 2013 4:58 PM To: seabios@seabios.org Cc: Woodhouse, David; Magnus Christensson; Jan Kiszka; Jason Baron;

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Gerd Hoffmann
On 03/21/13 07:23, Michael S. Tsirkin wrote: > On Wed, Mar 20, 2013 at 08:22:30PM -0400, Kevin O'Connor wrote: >> On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: >>> >>> Signed-off-by: Laszlo Ersek >> >> I think we need to figure out what the final fw_cfg interface for >> ACPI, SMBIO

[SeaBIOS] [PATCH v15 1/2] add pvpanic device driver

2013-03-21 Thread Hu Tao
pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Hu Tao --- ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg03630.html The version number is 15 to consist with qemu patches. src/acpi-dsdt-isa.dsl | 30 ++ 1 file ch

[SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Hu Tao
Signed-off-by: Hu Tao --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl index 87a31b9..43fe719 100644 --- a/src/acpi-dsdt-isa.dsl +++ b/src/acpi-dsdt-is

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:08, Hu Tao ha scritto: > Signed-off-by: Hu Tao > --- > src/acpi-dsdt-isa.dsl | 14 -- > src/acpi.c| 9 + > 2 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl > index 87a31b9..43fe719 1

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Hu Tao
On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote: > Il 21/03/2013 10:08, Hu Tao ha scritto: > > Signed-off-by: Hu Tao > > --- > > src/acpi-dsdt-isa.dsl | 14 -- > > src/acpi.c| 9 + > > 2 files changed, 21 insertions(+), 2 deletions(-) > > > > diff -

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: > Signed-off-by: Hu Tao OK now you need to ACK GPLv2+ relicensing too :) Could you please review that message "make acpi bits GPLv2 compatible" and respond? > --- > src/acpi-dsdt-isa.dsl | 14 -- > src/acpi.c| 9 +

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-21 Thread Hu Tao
Acked-by: Hu Tao On Wed, Mar 20, 2013 at 05:57:53PM +0200, Michael S. Tsirkin wrote: > You are getting this mail because you might have contributed code to one > of the files in seabios that we want to reuse in QEMU, > when this file was under GPLv3 or LGPLv3. > > QEMU is GPLv2 at the moment, so

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 09:18:50AM +0100, Gerd Hoffmann wrote: > On 03/21/13 07:23, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2013 at 08:22:30PM -0400, Kevin O'Connor wrote: > >> On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: > >>> > >>> Signed-off-by: Laszlo Ersek > >> > >> I t

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek I think this is a bit too aggressive. Let's do what I did for DSDT, add a config option and default to yes. In QEMU, override it to remove MADT from bios. > --- > src/acpi.c | 19 ---

[SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Michael S. Tsirkin
In the interim of moving ACPI tables out of seabios, developers should get the config from QEMU tree to keep things in sync. Signed-off-by: Michael S. Tsirkin --- README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/README b/README index a87a0ad..380fc80 100644 --- a/README +++ b/REA

Re: [SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:03, Michael S. Tsirkin wrote: > In the interim of moving ACPI tables out of > seabios, developers should get the config from > QEMU tree to keep things in sync. > > Signed-off-by: Michael S. Tsirkin > --- > README | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/REA

Re: [SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:22:33PM +0100, Laszlo Ersek wrote: > On 03/21/13 13:03, Michael S. Tsirkin wrote: > > In the interim of moving ACPI tables out of > > seabios, developers should get the config from > > QEMU tree to keep things in sync. > > > > Signed-off-by: Michael S. Tsirkin > > --- >

[SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Michael S. Tsirkin
In the interim of moving ACPI tables out of seabios, developers should get the config from QEMU tree to keep things in sync. Signed-off-by: Michael S. Tsirkin --- README | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/README b/README index a87a0ad..c6a2ee4 1

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 12:23:45PM +, David Woodhouse wrote: > On Wed, 2013-03-20 at 20:22 -0400, Kevin O'Connor wrote: > > On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: > > > > > > Signed-off-by: Laszlo Ersek > > > > I think we need to figure out what the final fw_cfg interf

Re: [SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:30, Michael S. Tsirkin wrote: > In the interim of moving ACPI tables out of > seabios, developers should get the config from > QEMU tree to keep things in sync. > > Signed-off-by: Michael S. Tsirkin > --- > README | 16 ++-- > 1 file changed, 14 insertions(+), 2 deleti

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Gerd Hoffmann
Hi, >>> How about we don't bother to determine this at runtime at all? >> >> Because it will be a PITA for testers + developers to figure the correct >> .config switches of the day during the transition phase? > > Why is it a PITA? Are you developing QEMU? Just use the makefile from > roms/co

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Thu, 2013-03-21 at 13:49 +0100, Gerd Hoffmann wrote: > >>> How about we don't bother to determine this at runtime at all? > >> > >> Because it will be a PITA for testers + developers to figure the correct > >> .config switches of the day during the transition phase? > > > > Why is it a PITA? A

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:23, David Woodhouse wrote: > On Wed, 2013-03-20 at 20:22 -0400, Kevin O'Connor wrote: >> On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: >>> >>> Signed-off-by: Laszlo Ersek >> >> I think we need to figure out what the final fw_cfg interface for >> ACPI, SMBIOS, mptable

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:49:36PM +0100, Gerd Hoffmann wrote: > Hi, > > >>> How about we don't bother to determine this at runtime at all? > >> > >> Because it will be a PITA for testers + developers to figure the correct > >> .config switches of the day during the transition phase? > > > > Wh

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:52, David Woodhouse wrote: > On Thu, 2013-03-21 at 13:49 +0100, Gerd Hoffmann wrote: > How about we don't bother to determine this at runtime at all? Because it will be a PITA for testers + developers to figure the correct .config switches of the day during the tra

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 12:52:17PM +, David Woodhouse wrote: > On Thu, 2013-03-21 at 13:49 +0100, Gerd Hoffmann wrote: > > >>> How about we don't bother to determine this at runtime at all? > > >> > > >> Because it will be a PITA for testers + developers to figure the correct > > >> .config swi

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:04:35PM +, David Woodhouse wrote: > On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: > > - for an earlier qemu, the option must be set, > > - for a later qemu the option must be clear && > > (no -acpitable switch must be specified on the qemu cmldine || > >

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: > - for an earlier qemu, the option must be set, > - for a later qemu the option must be clear && > (no -acpitable switch must be specified on the qemu cmldine || >one -acpitable switch must load a MADT) Hm, that sounds like it won't be

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Thu, 2013-03-21 at 15:12 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 21, 2013 at 01:04:35PM +, David Woodhouse wrote: > > On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: > > > - for an earlier qemu, the option must be set, > > > - for a later qemu the option must be clear && > > >

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:14:38PM +, David Woodhouse wrote: > On Thu, 2013-03-21 at 15:12 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2013 at 01:04:35PM +, David Woodhouse wrote: > > > On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: > > > > - for an earlier qemu, the option

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Gerd Hoffmann
On 03/21/13 14:01, Michael S. Tsirkin wrote: > On Thu, Mar 21, 2013 at 01:49:36PM +0100, Gerd Hoffmann wrote: >> Hi, >> > How about we don't bother to determine this at runtime at all? Because it will be a PITA for testers + developers to figure the correct .config switches of

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Gerd Hoffmann
Hi, > But I'm not sure I see any point in doing it table-by-table. Surely it > can be all or nothing? It allows to merge changes piecewise and avoids piling up long patch queues. It makes bisecting regressions easier. Also the logic "if table $foo is provided by qemu, just use it, otherwise g

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Wed, 2013-03-20 at 20:22 -0400, Kevin O'Connor wrote: > On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: > > > > Signed-off-by: Laszlo Ersek > > I think we need to figure out what the final fw_cfg interface for > ACPI, SMBIOS, mptable, and PIR will be. Once we have consensus, we

[SeaBIOS] [PATCH 2/2 v2] Introduce CONFIG_ACPI_MADT to possibly prevent SeaBIOS from building MADT

2013-03-21 Thread Laszlo Ersek
This config option, when set to N, allows any qemu-built MADT to take precedence. Signed-off-by: Laszlo Ersek --- in v2: - replaced primitive dynamic detection code with static config option - 352 bytes saved in 32bit flat init when set to N (RHEL-6 gcc-4.4.7) v2 depends on Michael's [PATCHv4] a

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: > Signed-off-by: Hu Tao I don't think it is a good idea to dynamically modify the DSDT. We've been using the SSDT for that. In any case, I think this would be a good candidate for merging after the ACPI stuff is moved into QEMU. -Kevin _

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 03:04:37PM +0100, Gerd Hoffmann wrote: > Today you can clone upstream seabios, build it, and the resulting image > will work on pretty much any qemu version since 0.12 or so. You don't > have to pick the correct config switches for your particular qemu > version, it just wo

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 09:18:50AM +0100, Gerd Hoffmann wrote: > On 03/21/13 07:23, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2013 at 08:22:30PM -0400, Kevin O'Connor wrote: > >> On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: > >>> > >>> Signed-off-by: Laszlo Ersek > >> > >> I t

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 03:26:26PM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 21, 2013 at 01:14:38PM +, David Woodhouse wrote: > > On Thu, 2013-03-21 at 15:12 +0200, Michael S. Tsirkin wrote: > > > Anyway, I am not against such runtime flags. > > > > > > If we add to this an option to buil