Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
Syslinux currently looks for a 640x480 mode unless MENU RESOLUTION is given. On April 16, 2014 5:12:21 PM PDT, Kevin O'Connor wrote: >On Wed, Apr 16, 2014 at 04:25:48PM -0700, H. Peter Anvin wrote: >> On 04/16/2014 04:21 PM, Kevin O'Connor wrote: >> > If I build SeaVGABIOS without vesa and run th

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 04:25:48PM -0700, H. Peter Anvin wrote: > On 04/16/2014 04:21 PM, Kevin O'Connor wrote: > > If I build SeaVGABIOS without vesa and run the Fedora 16 (or later) > > installer in qemu I get a menu that is not centered and the bottom > > line of the menu box isn't drawn. Also,

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Peter Stuge
H. Peter Anvin wrote: > Uh... seriously, robustness is a good thing, and it is not entirely > clear that this responsibility necessarily belongs in Coreboot. It's clear to me. The coreboot (all lowercase please) code for QEMU isn't neccessarily complete, and needs these kinds of improvements. >

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 03:47 PM, Kevin O'Connor wrote: > On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: >> Emulating attributes would be great so you can actually navigate >> bootloader menus. > > I took a look a closer look at this. Some things I found: > > - it looks like the syslinux m

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 03:59 PM, Peter Stuge wrote: > Gerd Hoffmann wrote: >>> -pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); >>> +pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | >>> PCI_COMMAND_IO | PCI_COMMAND_MEMORY); >> >> I think that should go in. If w

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 04:21 PM, Kevin O'Connor wrote: > On Wed, Apr 16, 2014 at 04:00:07PM -0700, H. Peter Anvin wrote: >> On 04/16/2014 03:47 PM, Kevin O'Connor wrote: >>> On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: Emulating attributes would be great so you can actually navigate >

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Peter Stuge
Gerd Hoffmann wrote: > > -pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); > > +pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | > > PCI_COMMAND_IO | PCI_COMMAND_MEMORY); > > I think that should go in. If we need it, we better make sure it > is enabled

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 04:00:07PM -0700, H. Peter Anvin wrote: > On 04/16/2014 03:47 PM, Kevin O'Connor wrote: > > On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: > >> Emulating attributes would be great so you can actually navigate > >> bootloader menus. > > > > I took a look a cl

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: > Emulating attributes would be great so you can actually navigate > bootloader menus. I took a look a closer look at this. Some things I found: - it looks like the syslinux menu on recent Fedora versions doesn't work correctly at

Re: [SeaBIOS] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-16 Thread Gabriel L. Somlo
OK, so I have the "legacy" (field-by-field, types 0 and 1 only) code back in, right next to the new aggregate-smbios-table-plus-entrypoint code, tested and apparently working fine. Before I get carried away with "git rebase", do we still want to go through the whole patch sequence of generating ag

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: > And we don't have a cursor I've noticed meanwhile. That would be very > helpful for editing your linux cmd line in the boot loader. A blinking > cursor is probably a bit unrealistic (need timer interrupt etc), but > emulating a bloc

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:48:43PM +0200, Gerd Hoffmann wrote: > > Hi, > > > That said, CONFIG_ATA_DMA is > > very fragile and it may be worth just removing at some point. > > Why is it fragile? On PATA you're supposed to do all these weird controller specific stuff to make sure DMA works, to

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, > But, it does raise the question of how many other callers expect the > bios to not mess with the segment limits. (Though, to be honest, the > only goal I have with coreboot native seavgabios is support for grub, > lilo, syslinux, and maybe ntldr.) Yes, it should be good enough for bootl

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, > But, it does raise the question of how many other callers expect the > bios to not mess with the segment limits. (Though, to be honest, the > only goal I have with coreboot native seavgabios is support for grub, > lilo, syslinux, and maybe ntldr.) Yes, it should be good enough for bootl

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, > That said, CONFIG_ATA_DMA is > very fragile and it may be worth just removing at some point. Why is it fragile? cheers, Gerd ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Mon, Apr 14, 2014 at 02:22:51PM +0200, Gerd Hoffmann wrote: > So you can try this: > > qemu -vga std -bios /usr/share/coreboot.git/coreboot-i440fx-seabios.rom > > to see it live in action. > > Two problems spotted so far: > > (1) ipxe hangs at rom load time. > can be worked around by

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:17:45PM +0200, Gerd Hoffmann wrote: > Hi, > > > --- a/src/hw/ata.c > > +++ b/src/hw/ata.c > > > -pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); > > +pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | > > PCI_COMMAND_IO | PC

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, > --- a/src/hw/ata.c > +++ b/src/hw/ata.c > -pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); > +pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | > PCI_COMMAND_IO | PCI_COMMAND_MEMORY); Ah. I think that should go in. If we need it, we better m

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Tue, Apr 15, 2014 at 07:52:47AM +0200, Gerd Hoffmann wrote: > Hi, > > > Oddly, I can't boot from a hard drive (-hda) when I use the > > coreboot/seabios I built though. It keeps failing at "Booting from > > Hard Disk...". > > I see that with my builds too, but only with -vga std (where core

Re: [SeaBIOS] [Qemu-devel] [PATCH V6 0/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-16 Thread Kevin O'Connor
On Thu, Apr 10, 2014 at 09:55:20PM +0300, Marcel Apfelbaum wrote: > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. Thanks - I have committed thi

Re: [SeaBIOS] [PATCH] Factor out smbios table walking from display_uuid to smbios_next().

2014-04-16 Thread Kevin O'Connor
On Sat, Apr 12, 2014 at 12:00:50PM -0400, Kevin O'Connor wrote: > Signed-off-by: Kevin O'Connor FYI, I have committed this patch. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [Xen-devel] [PATCH] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Igor Kozhukhov
On 15 Apr 2014, at 21:22, Roger Pau Monne wrote: > On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow > SeaBIOS to fetch the emulation to use from the environment variables. the same with -melf_i386_sol2 on illumos based platform. LGTM from me here. -Igor > This allows SeaBI

Re: [SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Ian Campbell
On Wed, 2014-04-16 at 14:48 +0200, Idwer Vollering wrote: > 2014-04-16 9:14 GMT+02:00 Roger Pau Monne : > > On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow > > SeaBIOS to fetch the emulation to use from the environment variables. > > > > This allows SeaBIOS to compile on FreeBS

Re: [SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Idwer Vollering
2014-04-16 9:14 GMT+02:00 Roger Pau Monne : > On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow > SeaBIOS to fetch the emulation to use from the environment variables. > > This allows SeaBIOS to compile on FreeBSD with gcc. > > Signed-off-by: Roger Pau Monné Acked-by: Idwer Vol

Re: [SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Idwer Vollering
2014-04-16 14:38 GMT+02:00 Idwer Vollering : > 2014-04-16 9:14 GMT+02:00 Roger Pau Monne : >> On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow >> SeaBIOS to fetch the emulation to use from the environment variables. >> >> This allows SeaBIOS to compile on FreeBSD with gcc. > >>

Re: [SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Idwer Vollering
2014-04-16 9:14 GMT+02:00 Roger Pau Monne : > On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow > SeaBIOS to fetch the emulation to use from the environment variables. > > This allows SeaBIOS to compile on FreeBSD with gcc. > +LD32BIT_FLAG:=-melf_i386 That will not work, see be

Re: [SeaBIOS] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-16 Thread Gerd Hoffmann
On Di, 2014-04-15 at 20:47 -0400, Kevin O'Connor wrote: > On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > > Leave the old interface code basically as-is. type0 and type1 > > individual fields are passed like they are passed today. We don't > > change to to pass full tables, and w

Re: [SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Ian Campbell
On Wed, 2014-04-16 at 09:14 +0200, Roger Pau Monne wrote: > On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow > SeaBIOS to fetch the emulation to use from the environment variables. > > This allows SeaBIOS to compile on FreeBSD with gcc. > > Signed-off-by: Roger Pau Monné > Cc

[SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

2014-04-16 Thread Roger Pau Monne
On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow SeaBIOS to fetch the emulation to use from the environment variables. This allows SeaBIOS to compile on FreeBSD with gcc. Signed-off-by: Roger Pau Monné Cc: Ian Campbell --- Changes in v2: - Rebase on top of master --- Makef