Re: [SeaBIOS] [PATCH] Don't enable thread preemption during S3 resume vga option rom execution.

2014-05-31 Thread Paul Menzel
Dear Kevin, thank you for the patch. Am Freitag, den 30.05.2014, 21:47 -0400 schrieb Kevin O'Connor: Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/stacks.c | 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stacks.c b/src/stacks.c index 6bcb319..beccc0f

Re: [SeaBIOS] [PATCH] smp: Replace QEMU SMP init assembler code with C; run only in 32bit mode.

2014-05-31 Thread Paolo Bonzini
Il 31/05/2014 03:20, Kevin O'Connor ha scritto: Change the multi-processor init code to trampoline into 32bit mode on each of the additional processors. Implement an atomic lock so that each processor performs its initialization serially. I don't see much benefit in this change, in fact the

Re: [SeaBIOS] [PATCH] Don't enable thread preemption during S3 resume vga option rom execution.

2014-05-31 Thread Kevin O'Connor
On Sat, May 31, 2014 at 11:32:39AM +0200, Paul Menzel wrote: What problem did it cause and on what systems? I'm not aware of this causing a problem on any system. The combination of etc/threads==2 (was CONFIG_THREAD_OPTIONROMS) and etc/s3-resume-vga-init==1 is likely very rare. With the above

[SeaBIOS] [PATCHv2] smp: Replace QEMU SMP init assembler code with C; run only in 32bit mode.

2014-05-31 Thread Kevin O'Connor
Change the multi-processor init code to trampoline into 32bit mode on each of the additional processors. Implement an atomic lock so that each processor performs its initialization serially. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- Changed since v2: * Use lock btsl instead of lock

Re: [SeaBIOS] [PATCHv2] smp: Replace QEMU SMP init assembler code with C; run only in 32bit mode.

2014-05-31 Thread Kevin O'Connor
On Sat, May 31, 2014 at 12:18:32PM -0400, Kevin O'Connor wrote: Change the multi-processor init code to trampoline into 32bit mode on each of the additional processors. Implement an atomic lock so that each processor performs its initialization serially. Signed-off-by: Kevin O'Connor