Re: [SeaBIOS] [PATCH 1/3] Add multiboot header to bios.bin.raw

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 19.05.2015 04:10, Kevin O'Connor wrote: On Mon, May 18, 2015 at 08:05:17PM +, Vladimir 'phcoder' Serbinenko wrote: diff --git a/scripts/layoutrom.py b/scripts/layoutrom.py index dd770fe..04e7efa 100755 --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -646,9 +646,10 @@ def

Re: [SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

2015-05-19 Thread Paolo Bonzini
On 19/05/2015 09:47, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 19.05.2015 09:45, Paolo Bonzini wrote: On 18/05/2015 22:07, Vladimir 'phcoder' Serbinenko wrote: +void +coreboot_multiboot_init(u32 mbptr) +{ + struct multiboot_info *mbi = (void *)mbptr; + dprintf (1, mbptr=0x%x\n,

Re: [SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
This code would need to be in the seabios coding style. Could you point to style guide or to tell exact points you dislike? STFW seabios style guide returns no relevant results Instead of passing this variable all the way through these initialization functions, I suspect it would be much

Re: [SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 19.05.2015 09:45, Paolo Bonzini wrote: On 18/05/2015 22:07, Vladimir 'phcoder' Serbinenko wrote: +void +coreboot_multiboot_init(u32 mbptr) +{ + struct multiboot_info *mbi = (void *)mbptr; + dprintf (1, mbptr=0x%x\n, mbptr); + if (mbptr == NO_MULTIBOOT) +return; + mbi =

Re: [SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

2015-05-19 Thread Paolo Bonzini
On 18/05/2015 22:07, Vladimir 'phcoder' Serbinenko wrote: +void +coreboot_multiboot_init(u32 mbptr) +{ + struct multiboot_info *mbi = (void *)mbptr; + dprintf (1, mbptr=0x%x\n, mbptr); + if (mbptr == NO_MULTIBOOT) +return; + mbi = (void *)mbptr; + dprintf (1, flags=0x%x,

Re: [SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

2015-05-19 Thread Paolo Bonzini
On 19/05/2015 10:10, Paolo Bonzini wrote: On 19/05/2015 09:47, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 19.05.2015 09:45, Paolo Bonzini wrote: On 18/05/2015 22:07, Vladimir 'phcoder' Serbinenko wrote: +void +coreboot_multiboot_init(u32 mbptr) +{ + struct multiboot_info *mbi

Re: [SeaBIOS] [PATCH 1/3] Add multiboot header to bios.bin.raw

2015-05-19 Thread Kevin O'Connor
On Tue, May 19, 2015 at 08:14:56AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 19.05.2015 04:10, Kevin O'Connor wrote: On Mon, May 18, 2015 at 08:05:17PM +, Vladimir 'phcoder' Serbinenko wrote: diff --git a/scripts/layoutrom.py b/scripts/layoutrom.py index

Re: [SeaBIOS] [PATCH 1/3] Add multiboot header to bios.bin.raw

2015-05-19 Thread Kevin O'Connor
On Tue, May 19, 2015 at 04:43:49PM +0200, Vladimir 'phcoder' Serbinenko wrote: Le 19 mai 2015 15:51, Kevin O'Connor ke...@koconnor.net a écrit : The _reloc_abs_start definition isn't available if CONFIG_RELOCATE_INIT is disabled - I think the symbol you want is code32flat_start. Both

Re: [SeaBIOS] [PATCH 1/3] Add multiboot header to bios.bin.raw

2015-05-19 Thread Vladimir 'phcoder' Serbinenko
Le 19 mai 2015 15:51, Kevin O'Connor ke...@koconnor.net a écrit : On Tue, May 19, 2015 at 08:14:56AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 19.05.2015 04:10, Kevin O'Connor wrote: On Mon, May 18, 2015 at 08:05:17PM +, Vladimir 'phcoder' Serbinenko wrote: diff

[SeaBIOS] [PATCH v3 2/2] Add multiboot support.

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
From 7ecb31e60ca5cde8f7649414a0463ff70fbe2865 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko phco...@gmail.com Date: Mon, 18 May 2015 19:07:16 +0200 Subject: [PATCH 2/2] Add multiboot support. I've been successfully using SeaBIOS as secondary bootloader. In more details I have

[SeaBIOS] [PATCH] ahci: Ignore max_ports.

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
At least AHCI on Intel on some machines claim to support only 6 ports while in fact higher port numbers are present and work. This is needed to access CD-ROM on PackardBell MS2290. Both GRUB and Linux have a similar workaround. Signed-off-by: Vladimir Serbinenko phco...@gmail.com ---

[SeaBIOS] [PATCH v3 1/2] Link rom.o with -N option.

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
This option tells linker not to align sections in a way optimied for OS. ls -lh out/bios.bin.elf -rwxr-xr-x 1 phcoder phcoder 90K Mai 19 20:38 out/bios.bin.elf Signed-off-by: Vladimir Serbinenko phco...@gmail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [SeaBIOS] [PATCH 1/3] Add multiboot header to bios.bin.raw

2015-05-19 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 19.05.2015 17:03, Kevin O'Connor wrote: On Tue, May 19, 2015 at 04:43:49PM +0200, Vladimir 'phcoder' Serbinenko wrote: Le 19 mai 2015 15:51, Kevin O'Connor ke...@koconnor.net a écrit : The _reloc_abs_start definition isn't available if CONFIG_RELOCATE_INIT is disabled - I think the symbol

Re: [SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

2015-05-19 Thread Kevin O'Connor
On Tue, May 19, 2015 at 08:12:46AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: This code would need to be in the seabios coding style. Could you point to style guide or to tell exact points you dislike? STFW seabios style guide returns no relevant results