[SeaBIOS] [PATCH 1/2] tpm: Unify tpm_fill_hash()/tpm_log_extend_event() and use in BIOS interface

2016-02-06 Thread Kevin O'Connor
Don't call tpm_fill_hash() or tpm_log_extend_event() from any internal code (ie, tpm_add_measurement_to_log). The internal code does not require the additional checks that these functions provide. Unify the tpm_fill_hash() and tpm_log_extend_event() into a new function hash_log_extend(), and use

[SeaBIOS] [PATCH 0/2] tpm2 logging

2016-02-06 Thread Kevin O'Connor
Hi Stefan, What do you think about something like these two patches in place of your last patch 10? Basically using 'struct tcg_pcr_event2_sha1' instead of introducing a new 'struct log_entry'. -Kevin Kevin O'Connor (2): tpm: Unify tpm_fill_hash()/tpm_log_extend_event() and use in BIOS i

[SeaBIOS] [PATCH 2/2] tpm: Write logs in TPM 2 format

2016-02-06 Thread Kevin O'Connor
Add support for the TPM 2 format of log messages. Write the logs in the format that is appropriate for the version of the host's TPM. For TPM 1.2 write it in the 'pcpes' structure's format, for TPM 2 in the new TPM 2 format. By using this method we can keep the API interface on systems with a TPM

Re: [SeaBIOS] [PATCH 1/2] ehci: Only delay UHCI/OHCI port scan until after EHCI setup completes

2016-02-06 Thread Kevin O'Connor
On Tue, Feb 02, 2016 at 03:03:36PM -0500, Kevin O'Connor wrote: > EHCI controller setup needs to occur prior to checking any UHCI or > OHCI ports to ensure a high speed device is not mistakenly configured > on a full speed "companion" controller. However, only the UHCI/OHCI > port scan needs to be

Re: [SeaBIOS] [PATCH v3 00/11] Add TPM 2 support

2016-02-06 Thread Kevin O'Connor
On Tue, Feb 02, 2016 at 01:09:08PM -0500, Stefan Berger wrote: > This series of patches adds TPM 2 support to SeaBIOS in the way previously > proposed. Thanks Stefan. I committed patches 1-9 and 11. I wanted to look further at patch 10. -Kevin ___ Se

Re: [SeaBIOS] [PATCH 0/4] Some additional PCI cleanups

2016-02-06 Thread Kevin O'Connor
On Wed, Feb 03, 2016 at 10:51:50AM -0500, Kevin O'Connor wrote: > Some additional PCI code cleanup - most notable is the first patch > which adds a '%pP' modifier to the 'printf' code for outputting > 'struct pci_device' pointers. FYI, I committed this series. -Kevin

Re: [SeaBIOS] [PATCH 00/14] Clean up PCI BAR handling

2016-02-06 Thread Kevin O'Connor
On Tue, Feb 02, 2016 at 11:18:43PM -0500, Kevin O'Connor wrote: > This series adds some helper functions for working with PCI BARs (Base > Address Registers), and it then updates all the drivers to use these > helper functions. The new helper functions perform sanity checks on > the BARs and make