Re: [SeaBIOS] [PATCH 4/4] cleanup smp_setup()

2016-05-11 Thread Igor Mammedov
On Tue, 10 May 2016 16:43:34 +0200 Igor Mammedov wrote: > MaxCountCPUs could never be 0 or less CountCPUs > anymore, remove code that wouldn't be executed. > > Signed-off-by: Igor Mammedov > --- > src/fw/smp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/fw/smp.c b/src/fw/smp

Re: [SeaBIOS] [PATCH 0/4] support booting more than 255 CPUs with QEMU

2016-05-11 Thread Igor Mammedov
On Tue, 10 May 2016 16:43:30 +0200 Igor Mammedov wrote: Probably question to Kevin, I've tried to make AP bootstrap run in parallel to speed up smp_setup with many CPUs. However it hangs and I couldn't debug it. Debugging works fine in 16bit mode as described in wiki but from the point when entry

[SeaBIOS] [PATCH v2 0/4] support booting more than 255 CPUs with QEMU

2016-05-11 Thread Igor Mammedov
Changelog since: v1: * s/count_cpu/apic_id_init/ * merge handle_x2apic() into apic_id_init() RFC: * move out max-cpus check out of mptable_setup() * factor out CPU counting/apic ID detection in separate function * return back accidentially deleted debug message with APIC ID

[SeaBIOS] [PATCH v2 1/4] paravirt: disable legacy bios tables in case of more than 255 CPUs

2016-05-11 Thread Igor Mammedov
MPTable doesn't support more than 255 CPUs and QEMU supplies an alternative MADT table which guest will use instead of it. So do not install legacy tables if more than 254 CPUs are provided Signed-off-by: Igor Mammedov --- src/fw/paravirt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletion

[SeaBIOS] [PATCH v2 2/4] smp: refactor present CPU APIC ID detection and counting

2016-05-11 Thread Igor Mammedov
From: Kevin O'Connor Signed-off-by: "Kevin O'Connor" Signed-off-by: Igor Mammedov --- v2: * s/count_cpu/apic_id_init/ * call apic_id_init() after sending SIPI, it will be needed for switching BSP into x2APIC mode --- src/fw/smp.c | 33 +++-- 1 file changed,

[SeaBIOS] [PATCH v2 3/4] support booting with more than 255 CPUs

2016-05-11 Thread Igor Mammedov
SDM[*1] says that if there are CPUs with APIC ID greater than 254, BIOS is to pass control to OS in x2APIC mode. Use the fact that QEMU passes in "etc/max-cpus" max possible "APIC ID + 1" to detect need for x2APIC mode. Also instead of CMOS_BIOS_SMP_COUNT which is limited to 256 CPUs use a new rom

[SeaBIOS] [PATCH v2 4/4] cleanup smp_setup()

2016-05-11 Thread Igor Mammedov
MaxCountCPUs could never be 0 or less CountCPUs anymore, remove code that wouldn't be executed. Signed-off-by: Igor Mammedov --- src/fw/smp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/fw/smp.c b/src/fw/smp.c index dfb8425..cb40ec6 100644 --- a/src/fw/smp.c +++ b/src/fw/smp.c @@ -

Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4] fw/pci: Add support for mapping Intel IGD via QEMU

2016-05-11 Thread Igor Mammedov
On Tue, 10 May 2016 09:19:52 -0600 Alex Williamson wrote: > On Tue, 23 Feb 2016 10:22:33 -0500 > "Kevin O'Connor" wrote: > > > On Tue, Feb 16, 2016 at 02:39:27PM -0700, Alex Williamson wrote: > > > QEMU provides two fw_cfg files to support IGD. The first holds the > > > OpRegion data which h

Re: [SeaBIOS] [PATCH 4/4] cleanup smp_setup()

2016-05-11 Thread Kevin O'Connor
On Wed, May 11, 2016 at 11:50:36AM +0200, Igor Mammedov wrote: > On Tue, 10 May 2016 16:43:34 +0200 > Igor Mammedov wrote: > > > MaxCountCPUs could never be 0 or less CountCPUs > > anymore, remove code that wouldn't be executed. > > > > Signed-off-by: Igor Mammedov > > --- > > src/fw/smp.c | 2

Re: [SeaBIOS] [PATCH 0/4] support booting more than 255 CPUs with QEMU

2016-05-11 Thread Kevin O'Connor
On Wed, May 11, 2016 at 12:02:40PM +0200, Igor Mammedov wrote: > On Tue, 10 May 2016 16:43:30 +0200 > Igor Mammedov wrote: > > Probably question to Kevin, > I've tried to make AP bootstrap run in parallel > to speed up smp_setup with many CPUs. > However it hangs and I couldn't debug it. > Debugg

Re: [SeaBIOS] [RFC PATCH v4] fw/pci: Add support for mapping Intel IGD via QEMU

2016-05-11 Thread Kevin O'Connor
On Tue, May 10, 2016 at 09:19:52AM -0600, Alex Williamson wrote: > On Tue, 23 Feb 2016 10:22:33 -0500 > "Kevin O'Connor" wrote: > > > On Tue, Feb 16, 2016 at 02:39:27PM -0700, Alex Williamson wrote: > > > QEMU provides two fw_cfg files to support IGD. The first holds the > > > OpRegion data whic

Re: [SeaBIOS] [RFC PATCH v4] fw/pci: Add support for mapping Intel IGD via QEMU

2016-05-11 Thread Alex Williamson
On Wed, 11 May 2016 11:19:25 -0400 "Kevin O'Connor" wrote: > On Tue, May 10, 2016 at 09:19:52AM -0600, Alex Williamson wrote: > > On Tue, 23 Feb 2016 10:22:33 -0500 > > "Kevin O'Connor" wrote: > > > > > On Tue, Feb 16, 2016 at 02:39:27PM -0700, Alex Williamson wrote: > > > > QEMU provides t