Re: [SeaBIOS] [PATCH] restore MSRs on S3 resume

2016-07-07 Thread Paolo Bonzini
> On Thu, Jul 07, 2016 at 04:00:40PM +0200, Paolo Bonzini wrote: > > Currently the MTRRs and MSR_IA32_FEATURE_CONTROL are not restored on S3 > > resume. Because these have to be applied to all processors, SMP setup > > has to be added to S3 resume. > > > > There are two differences between the

Re: [SeaBIOS] [PATCH] restore MSRs on S3 resume

2016-07-07 Thread Kevin O'Connor
On Thu, Jul 07, 2016 at 04:00:40PM +0200, Paolo Bonzini wrote: > Currently the MTRRs and MSR_IA32_FEATURE_CONTROL are not restored on S3 > resume. Because these have to be applied to all processors, SMP setup > has to be added to S3 resume. > > There are two differences between the boot and

Re: [SeaBIOS] [PATCH 1/3] vgabios: Remove special case of dh==0xff in handle_1013()

2016-07-07 Thread Kevin O'Connor
On Mon, Jul 04, 2016 at 12:41:14PM -0400, Kevin O'Connor wrote: > The original "lgpl vgabios" had a special case for dh==0xff in its > int1013 (write string) code. There does not appear to be any VGABIOS > documentation supporting this as an externally available feature. It > appears this was

[SeaBIOS] [PATCH] restore MSRs on S3 resume

2016-07-07 Thread Paolo Bonzini
Currently the MTRRs and MSR_IA32_FEATURE_CONTROL are not restored on S3 resume. Because these have to be applied to all processors, SMP setup has to be added to S3 resume. There are two differences between the boot and resume paths. First, romfile_* is not usable in the resume paths so we move

Re: [SeaBIOS] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL

2016-07-07 Thread Laszlo Ersek
On 07/07/16 14:12, Paolo Bonzini wrote: > >> I've worried that if I only *call* these interfaces to set the MSR, then >> the next (independent) use of the same interfaces would clear the MSR >> through the INIT-SIPI-SIPI. That would have forced me to modify the >> protocol / PPI implementations

Re: [SeaBIOS] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL

2016-07-07 Thread Paolo Bonzini
> I've worried that if I only *call* these interfaces to set the MSR, then > the next (independent) use of the same interfaces would clear the MSR > through the INIT-SIPI-SIPI. That would have forced me to modify the > protocol / PPI implementations so that any use of them would reprogram > the