Re: [SeaBIOS] [PATCH v4 3/5] error out if present cpus count changed during SMP bringup

2016-09-16 Thread Igor Mammedov
On Fri, 16 Sep 2016 08:55:49 -0400 "Kevin O'Connor" wrote: > On Fri, Sep 16, 2016 at 01:54:16PM +0200, Igor Mammedov wrote: > > if during SMP bringup a cpu is hotplugged, Seabios might > > silently hung in > > > > while (cmos_smp_count != CountCPUs) > > > > loop as

Re: [SeaBIOS] [PATCH v4 3/5] error out if present cpus count changed during SMP bringup

2016-09-16 Thread Kevin O'Connor
On Fri, Sep 16, 2016 at 01:54:16PM +0200, Igor Mammedov wrote: > if during SMP bringup a cpu is hotplugged, Seabios might > silently hung in > > while (cmos_smp_count != CountCPUs) > > loop as cmos_smp_count might be less then CountCPUs if > SIPI were delivered to the hotplugged CPU. > > Warn

Re: [SeaBIOS] [PATCH] boot: Show boot splash until all threads are complete

2016-09-16 Thread Kevin O'Connor
On Wed, Sep 14, 2016 at 06:20:34PM +0200, Paul Menzel wrote: > Currently, even with `etc/threads` set to 2 in CBFS, the boot splash is > only shown for a short period, while SeaBIOS detects the hard disk on > the ASRock E350M1, which takes 10 seconds with this particular hard > drive model. > >

Re: [SeaBIOS] [PATCH] kbd: Move extended and release events out of special key detection switch

2016-09-16 Thread Kevin O'Connor
On Mon, Sep 12, 2016 at 11:30:47AM -0400, Kevin O'Connor wrote: > Move checking for release and extended scancodes to the top of > __process_key(). FYI, I committed this change. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] [PATCH] fix virtio-pci

2016-09-16 Thread Kevin O'Connor
On Fri, Sep 16, 2016 at 01:14:36PM +0200, Igor Mammedov wrote: > On Fri, 16 Sep 2016 13:01:46 +0200 > Gerd Hoffmann wrote: > > > virtio-pci calls pci_enable_{io,mem}bar with the bar number, > > but the functions expect the bar base register offset. > > > > Reported-by: Igor

[SeaBIOS] [PATCH v4 4/5] add helpers to read etc/boot-cpus at resume time

2016-09-16 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- src/fw/paravirt.h | 3 +++ src/fw/paravirt.c | 38 ++ src/fw/smp.c | 11 ++- 3 files changed, 47 insertions(+), 5 deletions(-) diff --git a/src/fw/paravirt.h b/src/fw/paravirt.h index

[SeaBIOS] [PATCH v4 5/5] support booting with more than 255 CPUs

2016-09-16 Thread Igor Mammedov
SDM[*1] says that if there are CPUs with APIC ID greater than 254, BIOS is to pass control to OS in x2APIC mode. Use the fact that QEMU passes in "etc/max-cpus" max possible "APIC ID + 1" to detect need for x2APIC mode. Also instead of CMOS_BIOS_SMP_COUNT which is limited to 256 CPUs use a new rom

[SeaBIOS] [PATCH v4 3/5] error out if present cpus count changed during SMP bringup

2016-09-16 Thread Igor Mammedov
if during SMP bringup a cpu is hotplugged, Seabios might silently hung in while (cmos_smp_count != CountCPUs) loop as cmos_smp_count might be less then CountCPUs if SIPI were delivered to the hotplugged CPU. Warn user about it and ask for reboot. While at it rename CountCPUs to BroughtUpCPUs

[SeaBIOS] [PATCH v4 1/5] paravirt: disable legacy bios tables in case of more than 255 CPUs

2016-09-16 Thread Igor Mammedov
MPTable doesn't support more than 255 CPUs and QEMU supplies an alternative MADT table which guest will use instead of it. So do not install legacy tables if more than 254 CPUs are provided Signed-off-by: Igor Mammedov Acked-by: Michael S. Tsirkin ---

[SeaBIOS] [PATCH v4 0/5] support booting more than 255 CPUs with QEMU

2016-09-16 Thread Igor Mammedov
Changelog since: v3: * don't move CPU counting around, leave it as is and consolidate apic_id accounting only * add and use qemu_*_present_cpus_count() helpers to init/get boot cpus count at boot time and only qemu_get_present_cpus_count() at resume time * fix S3

[SeaBIOS] [PATCH v4 2/5] smp: consolidate CPU APIC ID detection and accounting

2016-09-16 Thread Igor Mammedov
From: Kevin O'Connor Signed-off-by: "Kevin O'Connor" Signed-off-by: Igor Mammedov --- v3: * fix hang on resume path by resetting CountCPUs on every smp_scan v2: * s/count_cpu/apic_id_init/ * call apic_id_init() after sending

Re: [SeaBIOS] [PATCH] fix virtio-pci

2016-09-16 Thread Igor Mammedov
On Fri, 16 Sep 2016 13:01:46 +0200 Gerd Hoffmann wrote: > virtio-pci calls pci_enable_{io,mem}bar with the bar number, > but the functions expect the bar base register offset. > > Reported-by: Igor Mammedov > Signed-off-by: Gerd Hoffmann

[SeaBIOS] [PATCH] fix virtio-pci

2016-09-16 Thread Gerd Hoffmann
virtio-pci calls pci_enable_{io,mem}bar with the bar number, but the functions expect the bar base register offset. Reported-by: Igor Mammedov Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [SeaBIOS] guest is unable to boot from virtio drive

2016-09-16 Thread Igor Mammedov
On Fri, 16 Sep 2016 11:04:07 +0200 Igor Mammedov wrote: It actually doesn't boot with defconfig either, I'm using current master at 642db1905ab133007d7427b6758a2103fb09a19a > This happens only when combination of build options > CONFIG_RELOCATE_INIT=n +

[SeaBIOS] guest is unable to boot from virtio drive

2016-09-16 Thread Igor Mammedov
This happens only when combination of build options CONFIG_RELOCATE_INIT=n + CONFIG_DEBUG_LEVEL=3 to reproduce compile seabios defconfig + above options and start guest with a single virtio drive: -drive if=virtio,file=guest.img As result one gets: No bootable device. here is debug log:

[SeaBIOS] TPM implementation

2016-09-16 Thread Wim Vervoorn
Hello Kevin/Stefan, I can see a lot of work has been done already on the tpm implementation in SeaBIOS. Can you update me on the status of this? Should I still consider this to be work in progress or is this close to a stage where it can actually be used in a production level project? Best