[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Gerd Hoffmann
Hi, > * Letting the user choose the date which will appear in the > SystemBiosDate registry key > Under QEMU. Ah, *this* is why qemu provides a type0 table. What is the use case for this? > Legacy SMBIOS Bios Date is '01/01/2011’ Maybe it's time add a config option to compile out

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Sam Eiderman
I actually love this idea. So we can now expect only ’06/23/99’ date string to reside in F-SEG at build time. This will allow setting the SystemBiosDate to all dates from 06/23/99 to 01/01/80 (2080) which is reasonable enough. So now we will copy the smbios0.date to "char win_bios_date[] VARFSE

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Kevin O'Connor
On Thu, May 23, 2019 at 06:58:57PM +0300, Sam Eiderman wrote: > > On 23 May 2019, at 18:54, Kevin O'Connor wrote: > > I understand. If we ensured the smbios date is always in the > > f-segment, would that also solve the problem? (That is, using the > > 'char win_bios_date[] VARFSEG' method discu

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Sam Eiderman
> On 23 May 2019, at 18:54, Kevin O'Connor wrote: > > On Thu, May 23, 2019 at 04:11:21PM +0300, Sam Eiderman wrote: >> Many programs use SystemBiosDate registry key in order to verify the machine >> they are running on (mostly for activation/licensing purposes). >> This registry key is read on

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Kevin O'Connor
On Thu, May 23, 2019 at 04:11:21PM +0300, Sam Eiderman wrote: > Many programs use SystemBiosDate registry key in order to verify the machine > they are running on (mostly for activation/licensing purposes). > This registry key is read only and is computed as explained before. > When this date chan

[SeaBIOS] [PATCH 2/2] virtio-pci: Use %pP format in dprintf() calls

2019-05-23 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/virtio-pci.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 96f9c6b..d543521 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@ -417,9 +417,8 @@ void vp_init_simple(

[SeaBIOS] [PATCH 1/2] pciinit: Use %pP shorthand for printing device ids in intel_igd_setup()

2019-05-23 Thread Kevin O'Connor
The hardcoded device names can cause false-positives on Windows bios version checks. Use the %pP format to avoid that. Reported-by: Sam Eiderman Signed-off-by: Kevin O'Connor --- src/fw/pciinit.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/fw/

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Sam Eiderman
Hi, Many programs use SystemBiosDate registry key in order to verify the machine they are running on (mostly for activation/licensing purposes). This registry key is read only and is computed as explained before. When this date changes - this may break the behavior of the machine. This date neve

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Gerd Hoffmann
Hi, > > The thing is, if the date reported by smbios tables is 05/02/2015 (which is > > bigger than 04/01/2014) so: > > If smbios tables are in fseg - Windows will select the most recent date - > > 05/02/2015 > > If not - Windows will select the most recent date (the only one it found) - > >