[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

2019-06-18 Thread Kevin O'Connor
On Thu, Jun 13, 2019 at 07:01:06PM +0100, David Woodhouse wrote: > On Thu, 2019-06-13 at 13:33 -0400, Kevin O'Connor wrote: > > Can you give some background on how this is intended to be used? > > > > We used to allow the version string to be overridden, but we found the > > results were a bit

[SeaBIOS] Re: [PATCH v2] csm: Sanitise alignment constraint in Legacy16GetTableAddress

2019-06-18 Thread Kevin O'Connor
On Thu, Jun 13, 2019 at 04:25:13PM +0100, David Woodhouse wrote: > The alignment constraint is defined in the CSM specifications as > "Bit mapped. First non-zero bit from the right is the alignment." > > Use __fls() to sanitise the alignment given that definition, since > passing a