[SeaBIOS] Re: [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions

2019-06-22 Thread Sam Eiderman
> On 22 Jun 2019, at 18:27, Kevin O'Connor wrote: > > On Sat, Jun 22, 2019 at 11:51:48AM +0300, Sam Eiderman wrote: >> But maybe someone wants bootorder but doesn’t want to override legacy disk >> translations… >> >> I’m thinking of maybe adding >> >> if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GE

[SeaBIOS] Re: [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions

2019-06-22 Thread Kevin O'Connor
On Sat, Jun 22, 2019 at 11:51:48AM +0300, Sam Eiderman wrote: > But maybe someone wants bootorder but doesn’t want to override legacy disk > translations… > > I’m thinking of maybe adding > > if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GEOMETRY) > return NULL; That's fine - though it's (!CONFIG_B

[SeaBIOS] Re: [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions

2019-06-22 Thread Sam Eiderman
But maybe someone wants bootorder but doesn’t want to override legacy disk translations… I’m thinking of maybe adding if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GEOMETRY) return NULL; In each of the get_*_devpath functions (which will normally return an allocated string, not on stack). Another