[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 03:43:51PM -0300, Heitor Alves de Siqueira wrote: > On Thu, May 27, 2021 at 11:44 AM Kevin O'Connor wrote: > > > > The purpose of this code is to restore the NMI_DISABLE_BIT to what it > > was prior to call32_prep(). If something calls the bios without the > >

[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Heitor Alves de Siqueira
On Thu, May 27, 2021 at 11:44 AM Kevin O'Connor wrote: > > The purpose of this code is to restore the NMI_DISABLE_BIT to what it > was prior to call32_prep(). If something calls the bios without the > NMI_DISABLE_BIT set, it's this code that makes sure SeaBIOS returns to > that calling code with

[SeaBIOS] Re: [PATCH v2] make BUILD_MIN_BIOSTABLE configurable

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 10:52:27AM +0200, Gerd Hoffmann wrote: > BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data > structures -- for example disk drives known to seabios -- must be > stored there, so the space available here limits the number of > devices seabios is able to manage.

[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 09:25:01AM -0300, Heitor Alves de Siqueira wrote: > We should disable NMIs when accessing CMOS ports during state restore, > like it's done during state backup in call32_prep(). > > Signed-off-by: Heitor Alves de Siqueira > --- > src/stacks.c | 2 +- > 1 file changed, 1

[SeaBIOS] [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Heitor Alves de Siqueira
We should disable NMIs when accessing CMOS ports during state restore, like it's done during state backup in call32_prep(). Signed-off-by: Heitor Alves de Siqueira --- src/stacks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stacks.c b/src/stacks.c index

[SeaBIOS] [PATCH 0/1] stacks: disable NMIs during state restore on call32_post()

2021-05-27 Thread Heitor Alves de Siqueira
Hi all, We've had reports of users hitting KVM emulation failures in certain workloads and were able to track down a missing NMI_DISABLE_BIT in call32_post() when accessing CMOS ports. This patch disables NMIs on state restore, following other accesses to CMOS_PORT_INDEX throughout the seabios

[SeaBIOS] [PATCH v2] make BUILD_MIN_BIOSTABLE configurable

2021-05-27 Thread Gerd Hoffmann
BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data structures -- for example disk drives known to seabios -- must be stored there, so the space available here limits the number of devices seabios is able to manage. This patch adds an config option for BUILD_MIN_BIOSTABLE so the size