[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-06-01 Thread Heitor Alves de Siqueira
Thank you very much for the explanation, Kevin! This has really helped in understanding these sections of the code. I agree that without a reproducer, this is going to be really difficult to debug further. I'll see if we can't get more data from the users that reported this with debug builds of

[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Heitor Alves de Siqueira
On Thu, May 27, 2021 at 11:44 AM Kevin O'Connor wrote: > > The purpose of this code is to restore the NMI_DISABLE_BIT to what it > was prior to call32_prep(). If something calls the bios without the > NMI_DISABLE_BIT set, it's this code that makes sure SeaBIOS returns to > that calling code with

[SeaBIOS] [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Heitor Alves de Siqueira
We should disable NMIs when accessing CMOS ports during state restore, like it's done during state backup in call32_prep(). Signed-off-by: Heitor Alves de Siqueira --- src/stacks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stacks.c b/src/stacks.c index 2fe1bfbd64fd

[SeaBIOS] [PATCH 0/1] stacks: disable NMIs during state restore on call32_post()

2021-05-27 Thread Heitor Alves de Siqueira
code. Heitor Alves de Siqueira (1): stacks: fix missing NMI_DISABLE_BIT on call32_post() src/stacks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1 ___ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email