[SeaBIOS] [PATCH 08/10] malloc: Add warning if free() called on invalid memory

2015-10-09 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/malloc.c | 10 ++ src/malloc.h | 4 +--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/malloc.c b/src/malloc.c index c41a0cb..f5c2ed4 100644 --- a/src/malloc.c +++ b/src/malloc.c @@ -276,6 +276,16 @@ _free(void

[SeaBIOS] [PATCH 09/10] malloc: Don't mix virtual and physical addresses

2015-10-09 Thread Kevin O'Connor
Consistently use 'u32' for physical addresses and pointers for virtual addresses in the malloc code. Introduce and use memremap() where a physical address needs to be converted to a virtual address. Use virt_to_phys() for the inverse. Signed-off-by: Kevin O'Connor --- src

[SeaBIOS] [PATCH 00/10] Misc code cleanups

2015-10-09 Thread Kevin O'Connor
This series is a fallout of work I was doing to test PAE. I think the cleanups in this series make sense even without PAE. -Kevin Kevin O'Connor (10): e820: Introduce e820_remove() and avoid exporting E820_HOLE e820: Rename memmap.c to e820map.c and use consistent "e820_"

[SeaBIOS] [PATCH 03/10] e820: Update debugging messages to report 64bit values

2015-10-09 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/e820map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/e820map.c b/src/e820map.c index 901ccdf..39445cf 100644 --- a/src/e820map.c +++ b/src/e820map.c @@ -79,7 +79,7 @@ dump_map(void) void e820_add(u64 start, u64 size, u32

[SeaBIOS] [PATCH 06/10] malloc: Use consistent naming for internal low-level "alloc" functions

2015-10-09 Thread Kevin O'Connor
Use the "alloc_" prefix for all the low-level allocation functions and avoid camelCase naming. Signed-off-by: Kevin O'Connor --- src/malloc.c | 102 +-- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/src

[SeaBIOS] [PATCH 04/10] virtio: Simplify vring alignment code

2015-10-09 Thread Kevin O'Connor
Don't do phys_to_virt(virt_to_phys(vaddr)) for page alignment - page alignment can be determined directly from the virtual address. Use the ALIGN() macro to make the code more readable. Signed-off-by: Kevin O'Connor --- src/hw/virtio-ring.h | 29 + 1 file

[SeaBIOS] [PATCH 01/10] e820: Introduce e820_remove() and avoid exporting E820_HOLE

2015-10-09 Thread Kevin O'Connor
The E820_HOLE definition is used internally in the e820 manipulation code to remove entries from the e820 map. Introduce the e820_remove() function so that the E820_HOLE definition does not need to be exported from the memmap.c code. Signed-off-by: Kevin O'Connor --- src/malloc.c | 2 +-

[SeaBIOS] [PATCH 07/10] malloc: Introduce common helper alloc_new_detail()

2015-10-09 Thread Kevin O'Connor
Introduce helper for finding temp space to hold an "allocation detail struct" and use it in both alloc_add() and _malloc(). Signed-off-by: Kevin O'Connor --- src/list.h | 10 + src/malloc.c | 72 +++- 2 fi

[SeaBIOS] [PATCH 02/10] e820: Rename memmap.c to e820map.c and use consistent "e820_" prefix

2015-10-09 Thread Kevin O'Connor
Rename memmap.c to e820map.c as the code in that file only deals with maintaining the e820 map. Move all the e820 definitions to new file e820map.h and use a consistent "e820_" prefix on all exported functions. Signed-off-by: Kevin O'Connor --- Makefile

Re: [SeaBIOS] [PATCH 1/2] Fix typos found by codespell

2015-10-09 Thread Kevin O'Connor
On Fri, Oct 02, 2015 at 08:46:40AM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > scripts/kconfig/lxdialog/util.c | 2 +- > src/Kconfig | 2 +- > src/biosvar.h | 2 +- > src/bmp.c | 2 +- > src/fw/shadow.c

Re: [SeaBIOS] [PATCH 1/2] Consolidate code16*() functions

2015-10-09 Thread Kevin O'Connor
On Mon, Sep 28, 2015 at 10:11:41AM -0400, Kevin O'Connor wrote: > Introduce code16_override() for cases where call16() should not > restore the previous 16bit state. All callers now use call16_back() > to invoke 16bit code, so rename call16_back() to call16(). FYI, I committed the

Re: [SeaBIOS] VT-d not enabled on Chromebook Pixel 2013 Link & Chromebook Pixel 2015 Samus

2015-10-09 Thread Kevin O'Connor
On Fri, Oct 09, 2015 at 04:36:02PM +0100, edward wandasiewicz wrote: > Basically, we are missing a DMAR table in the BIOS [...] > $ acpidump -s > > ACPI: RSDP 0x000F48E0 24 (v02 CORE ) > ACPI: RSDT 0x7CF44030 38 (v01 CORE COREBOOT > CORE ) > ACPI: XSDT 0

Re: [SeaBIOS] Problems booting legacy OSes on Chromebook Pixel 2015 - cbmem output

2015-10-06 Thread Kevin O'Connor
On Tue, Oct 06, 2015 at 04:10:05PM +0100, John Lewis wrote: > > > >>If I disable coreboot framebuffer support in SeaBIOS and then use the > >>VGABIOS from the stock ROM in RW_LEGACY, I don't get any display from > >>SeaBIOS on Broadwell. > >> > >>If I do the same with a Haswell Chromebook, the disp

Re: [SeaBIOS] Problems booting legacy OSes on Chromebook Pixel 2015 - cbmem output

2015-10-06 Thread Kevin O'Connor
On Tue, Oct 06, 2015 at 01:40:05PM +0100, edward wandasiewicz wrote: > On Tue, Oct 6, 2015 at 2:02 AM, Kevin O'Connor wrote: > > P.S. it should be possible to implement a SeaVGABIOS with support for > > mode switching on Intel graphics adapters. That should solve these >

Re: [SeaBIOS] Problems booting legacy OSes on Chromebook Pixel 2015 - cbmem output

2015-10-06 Thread Kevin O'Connor
On Tue, Oct 06, 2015 at 12:53:44PM +0100, John Lewis wrote: > >Looks like you have a rom from John Lewis. I'd confirm that the > >SeaVGABIOS in the rom is relatively recent as there were some changes > >("leal" emulation) that are known to work better on the *BSDs. > > > >If SeaVGABIOS is recent,

Re: [SeaBIOS] Problems booting legacy OSes on Chromebook Pixel 2015 - cbmem output

2015-10-05 Thread Kevin O'Connor
On Mon, Oct 05, 2015 at 05:04:09PM +0100, edward wandasiewicz wrote: > Following on from this post - http://seabios.seabios.narkive.com/UAt3jVij > > I was having the exactly the same problem. So to summarize, you can boot Linux on Samus, but can not boot any *BSD? Both Linux and the BSDs do work

Re: [SeaBIOS] [PATCH 1/2] Fix typos found by codespell

2015-10-02 Thread Kevin O'Connor
On Fri, Oct 02, 2015 at 08:46:40AM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > scripts/kconfig/lxdialog/util.c | 2 +- > src/Kconfig | 2 +- > src/biosvar.h | 2 +- > src/bmp.c | 2 +- > src/fw/shadow.c

Re: [SeaBIOS] [PATCH 2/2] Fix typo in function name

2015-10-02 Thread Kevin O'Connor
On Fri, Oct 02, 2015 at 08:46:41AM +0200, Stefan Weil wrote: > This makes checks with codespell easier. > > Signed-off-by: Stefan Weil > --- > scripts/kconfig/conf.c | 6 +++--- > scripts/kconfig/confdata.c | 2 +- > scripts/kconfig/lkc_proto.h | 2 +- > scripts/kconfig/mconf.c | 10

Re: [SeaBIOS] [PATCH v4 0/2] QEMU fw_cfg DMA interface

2015-10-01 Thread Kevin O'Connor
On Thu, Oct 01, 2015 at 02:16:04PM +0200, Marc Marí wrote: > Implement guest-side of the QEMU FW CFG DMA interface for x86 Thanks - this patch series looks good to me. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/l

[SeaBIOS] [PATCH 10/15] optionroms: Use ioremap() on PCI rom bars to map them to memory

2015-09-30 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/memmap.h | 3 +++ src/optionroms.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/memmap.h b/src/memmap.h index 092e2ad..c927ab9 100644 --- a/src/memmap.h +++ b/src/memmap.h @@ -13,5 +13,8 @@ static inline u32 virt_to

[SeaBIOS] [PATCH 11/15] smp: Use ioremap() on APIC memory

2015-09-30 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/fw/smp.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/fw/smp.c b/src/fw/smp.c index 579acdb..711eb27 100644 --- a/src/fw/smp.c +++ b/src/fw/smp.c @@ -7,16 +7,18 @@ #include "config.h&q

[SeaBIOS] [PATCH 14/15] Experimental support for PAE paging

2015-09-30 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/Kconfig | 7 +++ src/malloc.c| 3 ++ src/memmap.c| 129 +++- src/memmap.h| 17 ++-- src/romlayout.S | 35 --- src/stacks.c| 15 ++- src/x86.h

[SeaBIOS] [PATCH 09/15] memmap: Move GDT declarations from misc.c to new file memmap.c

2015-09-30 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- Makefile | 2 +- src/memmap.c | 53 + src/misc.c | 45 - 3 files changed, 54 insertions(+), 46 deletions(-) create mode 100644 src/memmap.c diff --

[SeaBIOS] [PATCH 15/15] Experiment with SeaBIOS internal memory above 4GB

2015-09-30 Thread Kevin O'Connor
This is a test. Changes to paravirt.c and stacks.c are not correct. --- src/fw/paravirt.c | 8 src/malloc.c | 48 +--- src/malloc.h | 15 +++ src/stacks.c | 2 +- 4 files changed, 49 insertions(+), 24 deletions(-)

[SeaBIOS] [PATCH 13/15] Implement protected mode exception handlers

2015-09-30 Thread Kevin O'Connor
Support simple exception handlers for General Protection (GP) and Page Fault (PF) faults. The handlers will report the issue and halt the machine. Signed-off-by: Kevin O'Connor --- src/malloc.c| 2 ++ src/memmap.c| 66 +++--

[SeaBIOS] [PATCH 12/15] tpm: Temporary ioremap() hack for tpm_drivers

2015-09-30 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/tpm_drivers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c index 444eac3..8c92401 100644 --- a/src/hw/tpm_drivers.c +++ b/src/hw/tpm_drivers.c @@ -8,11 +8,12 @@ // This file m

[SeaBIOS] [PATCH 07/15] malloc: Introduce common helper alloc_new_detail()

2015-09-30 Thread Kevin O'Connor
Introduce helper for finding temp space to hold an "allocation detail struct" and use it in both alloc_add() and _malloc(). Signed-off-by: Kevin O'Connor --- src/list.h | 10 + src/malloc.c | 72 +++- 2 fi

[SeaBIOS] [PATCH 08/15] malloc: Don't mix virtual and physical addresses

2015-09-30 Thread Kevin O'Connor
Consistently use 'u32' for physical addresses and pointers for virtual addresses in the malloc code. Introduce and use memremap() where a physical address needs to be converted to a virtual address. Use virt_to_phys() for the inverse. Signed-off-by: Kevin O'Connor --- src

[SeaBIOS] [PATCH 06/15] malloc: Use consistent naming for internal low-level "alloc" functions

2015-09-30 Thread Kevin O'Connor
Use the "alloc_" prefix for all the low-level allocation functions and avoid camelCase naming. Signed-off-by: Kevin O'Connor --- src/malloc.c | 102 +-- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/src

[SeaBIOS] [PATCH 02/15] e820: Rename memmap.c to e820map.c and use consistent "e820_" prefix

2015-09-30 Thread Kevin O'Connor
Rename memmap.c to e820map.c as the code in that file only deals with maintaining the e820 map. Move all the e820 definitions to new file e820map.h and use a consistent "e820_" prefix on all exported functions. Signed-off-by: Kevin O'Connor --- Makefile

[SeaBIOS] [PATCH 03/15] e820: Update debugging messages to report 64bit values

2015-09-30 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/e820map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/e820map.c b/src/e820map.c index 901ccdf..39445cf 100644 --- a/src/e820map.c +++ b/src/e820map.c @@ -79,7 +79,7 @@ dump_map(void) void e820_add(u64 start, u64 size, u32

[SeaBIOS] [PATCH 04/15] virtio: Simplify vring alignment code

2015-09-30 Thread Kevin O'Connor
Don't do phys_to_virt(virt_to_phys(vaddr)) for page alignment - page alignment can be determined directly from the virtual address. Use the ALIGN() macro to make the code more readable. Signed-off-by: Kevin O'Connor --- src/hw/virtio-ring.h | 29 + 1 file

[SeaBIOS] [PATCH 05/15] virtio: Move standard definitions from virtio-ring.h to standard headers

2015-09-30 Thread Kevin O'Connor
Move PAGE_SHIFT / virt_to_phys() to memmap.h and smp_[rw]mb() to x86.h. Signed-off-by: Kevin O'Connor --- src/hw/pvscsi.c | 2 +- src/hw/virtio-ring.h | 7 --- src/memmap.h | 7 +++ src/x86.h| 8 4 files changed, 16 insertions(+), 8 deletions(-)

[SeaBIOS] [PATCH 01/15] e820: Introduce e820_remove() and avoid exporting E820_HOLE

2015-09-30 Thread Kevin O'Connor
The E820_HOLE definition is used internally in the e820 manipulation code to remove entries from the e820 map. Introduce the e820_remove() function so that the E820_HOLE definition does not need to be exported from the memmap.c code. Signed-off-by: Kevin O'Connor --- src/malloc.c | 2 +-

[SeaBIOS] [RFCv2 00/15] Experiment with PAE paging

2015-09-30 Thread Kevin O'Connor
cheme. The first 2MB uses an identity map, and no other memory is accessible without first calling ioremap() (or the similar memremap() ). That scheme is probably a bit too aggressive - it would likely be simpler to not require memremap() to access regular ram below 4GB. -Kevin Kevin O'

Re: [SeaBIOS] SeaBIOS PAE experiment

2015-09-30 Thread Kevin O'Connor
On Tue, Sep 29, 2015 at 10:19:19PM +0200, Rudolf Marek wrote: > Hi Kevin, > > > * The reason why PAE is interesting (instead of standard i386 paging) > > is that it allows for 64bit mappings and because one can set it up > > with just a single level page directory of 2MB pages. The single > >

[SeaBIOS] SeaBIOS PAE experiment

2015-09-28 Thread Kevin O'Connor
r a 16bit bios to fully support 64bit memory. * I haven't done any performance tests. It's unclear what the performance impact of enabling paging on every 32bit entry point would be. -Kevin commit 6ffd9a0b0852c83850cc531a97d3f576bfc93e21 Author: Kevin O'Connor Date: Mon Sep

[SeaBIOS] [PATCH 2/2] Always enable caching on transition32; backup/restore cr0 on call32

2015-09-28 Thread Kevin O'Connor
-by: Kevin O'Connor --- src/fw/smp.c| 3 --- src/post.c | 3 --- src/romlayout.S | 1 + src/stacks.c| 45 - src/x86.h | 9 ++--- 5 files changed, 35 insertions(+), 26 deletions(-) diff --git a/src/fw/smp.c b/src/fw/smp.c

[SeaBIOS] [PATCH 1/2] Consolidate code16*() functions

2015-09-28 Thread Kevin O'Connor
Introduce code16_override() for cases where call16() should not restore the previous 16bit state. All callers now use call16_back() to invoke 16bit code, so rename call16_back() to call16(). Signed-off-by: Kevin O'Connor --- src/stacks.c

Re: [SeaBIOS] [RFC 2/3] Transitions to and from 64 bits

2015-09-21 Thread Kevin O'Connor
On Mon, Sep 21, 2015 at 12:03:29PM -0400, Kevin O'Connor wrote: > According to my Intel docs, PAE supports the same 52bit physical > address range that x86_64 supports. Thinking about this further, I could see changing SeaBIOS' 32bit code to always use PAE mode (when available).

Re: [SeaBIOS] [RFC 2/3] Transitions to and from 64 bits

2015-09-21 Thread Kevin O'Connor
On Mon, Sep 21, 2015 at 06:23:54PM +0200, Marc Marí wrote: > On Mon, 21 Sep 2015 12:03:29 -0400 > "Kevin O'Connor" wrote: > > Also, your code seems to run regular 32bit code when in "long mode" - > > is that valid? > > It doesn't crash.

Re: [SeaBIOS] [RFC 0/3] NVDIMM booting support

2015-09-21 Thread Kevin O'Connor
On Mon, Sep 21, 2015 at 03:14:04PM +0200, Marc Marí wrote: > Implement support for booting from a PMEM region compatible with NVDIMM and > NFIT specifications. > > The current implementation is still slow. When running a Linux guest on top of > QEMU in x86: > > Using actual -kernel option: > QEMU

Re: [SeaBIOS] [RFC 2/3] Transitions to and from 64 bits

2015-09-21 Thread Kevin O'Connor
On Mon, Sep 21, 2015 at 04:38:00PM +0200, Marc Marí wrote: > On Mon, 21 Sep 2015 15:57:56 +0200 > Gerd Hoffmann wrote: > > > +/ > > > + * Page table > > > + / > > > +void

Re: [SeaBIOS] [PATCH 0/5] Simplify 16bit/32bit trampoline code

2015-09-18 Thread Kevin O'Connor
On Mon, Sep 14, 2015 at 10:26:21AM -0400, Kevin O'Connor wrote: > This series simplifies some of the existing trampoline code. FYI, I committed this series. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/

Re: [SeaBIOS] [PATCH v3 2/2] Boot Linux using QEMU fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 09:28:57PM +0200, Marc Marí wrote: > On Fri, 18 Sep 2015 14:40:30 -0400 > "Kevin O'Connor" wrote: > > On Fri, Sep 18, 2015 at 10:59:15AM +0200, Marc Marí wrote: > > > bootprio_find_named_rom("genroms/linuxboot.bin", 0)); &g

Re: [SeaBIOS] [PATCH v3 2/2] Boot Linux using QEMU fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 10:59:15AM +0200, Marc Marí wrote: > Reading Linux from the fw_cfg interface is faster using the DMA interface. > For this reason, add a Linux loader that can benefit from this interface. > > Signed-off-by: Marc Marí > --- > src/boot.c| 32 - >

[SeaBIOS] [PATCH 3/5] Unify inline assembler in variants of call16 functions

2015-09-14 Thread Kevin O'Connor
The assembler between call16(), call16big() and call16_sloppy() are very similar. Rework the functions so that a single version of the inline assembly can be used for all variants. Signed-off-by: Kevin O'Connor --- src/romlayout.S | 9 - src/stacks.c

[SeaBIOS] [PATCH 5/5] Use transition32_nmi_off from call32() and call16_back()

2015-09-14 Thread Kevin O'Connor
The call32() and call16_back() functions will always disable NMI and enable a20 (via the call32_prep() function) so it is safe to use the _nmi_off variant of transition32. Signed-off-by: Kevin O'Connor --- src/romlayout.S | 1 + src/stacks.c| 4 ++-- 2 files changed, 3 insertions(

[SeaBIOS] [PATCH 0/5] Simplify 16bit/32bit trampoline code

2015-09-14 Thread Kevin O'Connor
This series simplifies some of the existing trampoline code. -Kevin Kevin O'Connor (5): Unify smm/sloppy variants of call32_prep/post and call16_helper Rename Call32Data to Call16Data Unify inline assembler in variants of call16 functions Unify call32_sloppy() and call32()

[SeaBIOS] [PATCH 2/5] Rename Call32Data to Call16Data

2015-09-14 Thread Kevin O'Connor
The variable stores information on how and what to restore during a call to 16bit code, so Call16Data is a better name. Signed-off-by: Kevin O'Connor --- src/stacks.c | 58 +- 1 file changed, 29 insertions(+), 29 deletions(-) diff --

[SeaBIOS] [PATCH 4/5] Unify call32_sloppy() and call32()

2015-09-14 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/stacks.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/src/stacks.c b/src/stacks.c index f92a484..a1b8677 100644 --- a/src/stacks.c +++ b/src/stacks.c @@ -197,12 +197,20 @@ call16_smm(u32 eax, u3

[SeaBIOS] [PATCH 1/5] Unify smm/sloppy variants of call32_prep/post and call16_helper

2015-09-14 Thread Kevin O'Connor
The "smm" and "sloppy" variants of the 16bit to 32bit trampoline backup/restore code are very similar. They can be unified into a single copy of each function. Signed-off-by: Kevin O'Connor --- src/stacks.c | 132 ++

Re: [SeaBIOS] [PATCH] build: use -fstack-check=no when available

2015-09-14 Thread Kevin O'Connor
On Fri, Sep 11, 2015 at 11:06:31PM -0400, Mike Frysinger wrote: > On 11 Sep 2015 19:49, Kevin O'Connor wrote: > > On Fri, Sep 11, 2015 at 05:38:40PM -0400, Mike Frysinger wrote: > > > From: Magnus Granberg > > > > > > Some compilers default this o

Re: [SeaBIOS] [PATCH] build: use -fstack-check=no when available

2015-09-11 Thread Kevin O'Connor
On Fri, Sep 11, 2015 at 05:38:40PM -0400, Mike Frysinger wrote: > From: Magnus Granberg > > Some compilers default this option to on which leads to build failures: Thanks. What compiler / distribution defaults this on? -Kevin ___ SeaBIOS mailing lis

[SeaBIOS] [PATCH] Simplify transition16/32 assembler code

2015-09-08 Thread Kevin O'Connor
Backup and restore %eax only around code that needs to use %eax. Signed-off-by: Kevin O'Connor --- src/romlayout.S | 89 ++--- 1 file changed, 40 insertions(+), 49 deletions(-) diff --git a/src/romlayout.S b/src/romlayout.S index 79

Re: [SeaBIOS] "bootorder" documentation change

2015-09-07 Thread Kevin O'Connor
On Mon, Sep 07, 2015 at 09:10:03PM +0200, Maxime de Roucy wrote: > Le lundi 07 septembre 2015 à 10:36 -0400, Kevin O'Connor a écrit : > > I don't understand what Maxime is reporting (via the documentation > > patch), nor what Matt's patch above fixes. Could someon

Re: [SeaBIOS] "bootorder" documentation change

2015-09-07 Thread Kevin O'Connor
On Mon, Sep 07, 2015 at 07:29:27AM +, Matt DeVillier wrote: > coincidentally enough, my patch to correct the 'Booting from' text for USB > devices > (which I just updated) should address the issue you describe in the > documentation patch: > > https://github.com/MattDevo/SeaBIOS/commit/424fa77

Re: [SeaBIOS] [PATCH] megasas: Fix outw, outl argument order

2015-09-03 Thread Kevin O'Connor
On Sat, Aug 29, 2015 at 08:02:38AM +0200, Stefan Weil wrote: > The value is the first argument and the port is the second, > but the code was using the opposite order. Thanks - I committed this patch. I also committed a follow up patch turning the outw() into an outl(). -Kevin _

Re: [SeaBIOS] [PATCHv2 0/6] Improve sdcard boot menu description

2015-09-03 Thread Kevin O'Connor
On Mon, Aug 31, 2015 at 05:51:15PM -0400, Kevin O'Connor wrote: > This is a respin of a previous series to extend the sdcard boot menu > description. Instead of showing the product name and card version, > this series shows the product name and card capacity. The card > capaci

Re: [SeaBIOS] [PATCH] rtc_setup, NMI - Seabios boot loop

2015-09-01 Thread Kevin O'Connor
for the addressee(s) indicated. [...] Your email was sent to a public email list. -Kevin commit 3156b71a535e6617fbc60fd6aef09a229aca7327 Author: Kevin O'Connor Date: Tue Sep 1 19:43:08 2015 -0400 rtc: Disable NMI in rtc_mask() The rtc_mask() function should make sure the NMI disa

[SeaBIOS] [PATCH 1/6] sdcard: Move sdcard_set_frequency()/sdcard_set_power() in sdcard.c

2015-08-31 Thread Kevin O'Connor
Just code movement; no code changes. Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 116 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 8e7e954..bf35277 100644 --- a/s

[SeaBIOS] [PATCHv2 0/6] Improve sdcard boot menu description

2015-08-31 Thread Kevin O'Connor
rsion. Kevin O'Connor (6): sdcard: Move sdcard_set_frequency()/sdcard_set_power() in sdcard.c sdcard: Move frequency setting into sdcard_card_setup() sdcard: Move drive registration to sdcard_card_setup() sdcard: Turn card_type into a bitmap and store if card is MMC type sdcard: Disp

[SeaBIOS] [PATCH 6/6] sdcard: Obtain card capacity and report it on the boot menu

2015-08-31 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 48 +++- 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index d5ea40c..d80b473 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -68,6

[SeaBIOS] [PATCH 5/6] sdcard: Display sdcard product name in boot menu

2015-08-31 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 336314e..d5ea40c 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -408,6 +408,8 @@ sdcard_card_setup(struct sddr

[SeaBIOS] [PATCH 4/6] sdcard: Turn card_type into a bitmap and store if card is MMC type

2015-08-31 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 5b3ffb1..336314e 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -139,8 +139,8 @@ struct sddr

[SeaBIOS] [PATCH 2/6] sdcard: Move frequency setting into sdcard_card_setup()

2015-08-31 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index bf35277..a60fa92 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -355,9 +355,14 @@ sdcard_set_frequency(s

[SeaBIOS] [PATCH 3/6] sdcard: Move drive registration to sdcard_card_setup()

2015-08-31 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index a60fa92..5b3ffb1 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -353,8 +

Re: [SeaBIOS] [PATCH v2 2/2] Boot Linux using QEMU fw_cfg DMA interface

2015-08-31 Thread Kevin O'Connor
On Mon, Aug 31, 2015 at 07:10:37PM +0200, Marc Marí wrote: > On Mon, 31 Aug 2015 12:46:57 -0400 > "Kevin O'Connor" wrote: > > > On Mon, Aug 31, 2015 at 11:12:02AM +0200, Marc Marí wrote: > > > Reading Linux from the fw_cfg interface is faster using the DMA

Re: [SeaBIOS] [PATCH v2 2/2] Boot Linux using QEMU fw_cfg DMA interface

2015-08-31 Thread Kevin O'Connor
On Mon, Aug 31, 2015 at 11:12:02AM +0200, Marc Marí wrote: > Reading Linux from the fw_cfg interface is faster using the DMA interface. > For this reason, add a Linux loader that can benefit from this interface. > > Signed-off-by: Marc Marí > --- > src/boot.c| 26 + > src

Re: [SeaBIOS] [PATCH v2 1/2] Add QEMU fw_cfg DMA interface

2015-08-31 Thread Kevin O'Connor
On Mon, Aug 31, 2015 at 11:12:01AM +0200, Marc Marí wrote: > Add support for the new fw_cfg DMA interface. The protocol is explained in > QEMU documentation. Thanks for working on this. > Signed-off-by: Marc Marí > --- > src/fw/paravirt.c | 65 >

Re: [SeaBIOS] Unremovable USB3 device can not be detected after reboot

2015-08-27 Thread Kevin O'Connor
On Thu, Aug 27, 2015 at 03:47:02AM +, Zheng Bao wrote: > Fist time: Power up, SeaGate USB hard drive can be detected. > --   start > SeaBIOS (version rel-1.8.0-0-g4c59f5d-dirty-20150826_232532-supersrv) [...] >

Re: [SeaBIOS] Unremovable USB3 device can not be detected after reboot

2015-08-26 Thread Kevin O'Connor
On Wed, Aug 26, 2015 at 10:39:25AM +, Zheng Bao wrote: > Hi, All, > My test environment. > > Main Board: AMD Bettong > SeaBIOS: 1.8.0 > USB3 device: USB MSC vendor='Seagate' product='FA GoFlex Pro' rev='0210' > type=0 removable=0 > > The device can be detected at Seabios stage only when the

Re: [SeaBIOS] : USB 3.0 port failed if a USB 3.0 device is attached when power up

2015-08-25 Thread Kevin O'Connor
On Wed, Aug 26, 2015 at 01:50:49AM +, Zheng Bao wrote: > The patch doesn't work. Can you post the log with the patch and the debug level set to 5. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] : USB 3.0 port failed if a USB 3.0 device is attached when power up

2015-08-25 Thread Kevin O'Connor
On Tue, Aug 25, 2015 at 06:11:53AM +, Zheng Bao wrote: > I tried with Parmer, which I assume is close to ASUS F2A85-M, and got the > same result. > :( Does the patch below help? (Make sure CONFIG_THREADS=y). -Kevin --- a/src/hw/usb-xhci.c +++ b/src/hw/usb-xhci.c @@ -364,6 +364,7 @@ xhci_h

[SeaBIOS] [PATCH] docs: Don't use an add-symbol-file offset when describing gdb debugging

2015-08-24 Thread Kevin O'Connor
Recent versions of gdb will only add an offset to the '.text' section of object files via the add-symbol-file command. The SeaBIOS build doesn't place code directly in a '.text' section, so update the documentation to obtain the same result via an 'objcopy'

[SeaBIOS] [PATCH 1/4] sdcard: Move sdcard_set_frequency()/sdcard_set_power() in sdcard.c

2015-08-24 Thread Kevin O'Connor
Just code movement; no code changes. Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 116 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 8e7e954..bf35277 100644 --- a/s

[SeaBIOS] [PATCH 2/4] sdcard: Move frequency setting into sdcard_card_setup()

2015-08-24 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index bf35277..a60fa92 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -355,9 +355,14 @@ sdcard_set_frequency(s

[SeaBIOS] [PATCH 4/4] sdcard: Display sdcard product name and revision in boot menu

2015-08-24 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 5b3ffb1..23d7432 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -409,6 +409,8 @@ sdcard_card_setup(struct sddr

[SeaBIOS] [PATCH 3/4] sdcard: Move drive registration to sdcard_card_setup()

2015-08-24 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/hw/sdcard.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index a60fa92..5b3ffb1 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -353,8 +

[SeaBIOS] [PATCH 0/4] Improve sdcard boot menu description

2015-08-24 Thread Kevin O'Connor
This series extends the sdcard boot menu description to include product and version information from the sd card. This makes the menu more readable and can help distinguish between cards if more than one drive is in the system. -Kevin Kevin O'Connor (4): sdcard: Move sdcard_set_freq

Re: [SeaBIOS] [PATCH 0/3] Patches for baytrail based chromebooks

2015-08-24 Thread Kevin O'Connor
On Mon, Aug 17, 2015 at 01:21:54PM -0400, Kevin O'Connor wrote: > This series enables seabios to run on some Baytrail CPU based > chromebooks. At least some of these machines do not support routing > of legacy interrupts and at least some have SDHCI controllers that do > not appe

Re: [SeaBIOS] [RFC 2/2] Add Linux boot code for the fw_cfg dma interface

2015-08-19 Thread Kevin O'Connor
On Wed, Aug 19, 2015 at 07:31:30PM +0200, Gerd Hoffmann wrote: > Doing this in seabios looks appealing too as seabios needs the code for > fw_cfg support anyway and it is already written in C. It needs some > more care through so things like bootorder and pxeboot continue to work. > Maybe seabios

Re: [SeaBIOS] [PATCH] rtc: Support disabling the RTC timer irq support

2015-08-17 Thread Kevin O'Connor
On Mon, Aug 17, 2015 at 11:32:18PM +0200, Paul Menzel wrote: > Am Montag, den 17.08.2015, 12:23 -0400 schrieb Kevin O'Connor: > > Add a build time config option to remove support for RTC timer > > interrupts along with the associated bios calls requiring that > > suppo

[SeaBIOS] [PATCH 3/3] sdcard: Allow sdcard addresses to be specified in CBFS files

2015-08-17 Thread Kevin O'Connor
Allow a hardcoded address to be specified in cbfs files with a prefix of "etc/sdcard". Some real-world devices have valid SDHCI controllers that do not show up as PCI devices. Signed-off-by: Kevin O'Connor --- docs/Runtime_config.md | 1 + src/hw/sdcar

[SeaBIOS] [PATCH 1/3] Add minimal support for machines without hardware interrupts

2015-08-17 Thread Kevin O'Connor
hardware interrupts. Signed-off-by: Kevin O'Connor --- src/Kconfig| 13 - src/clock.c| 31 +-- src/hw/pic.c | 14 ++ src/hw/pic.h | 4 src/hw/timer.c | 2 ++ src/stacks.c | 5 - src/util.h | 1 + 7 files change

[SeaBIOS] [PATCH 2/3] ps2: Eliminate "etc/ps2-poll-only"; use CONFIG_HARDWARE_IRQ instead

2015-08-17 Thread Kevin O'Connor
The "etc/ps2-poll-only" runtime setting is directly tied to the new CONFIG_HARDWARE_IRQ setting - use the compile time setting to control both. Signed-off-by: Kevin O'Connor --- docs/Runtime_config.md | 1 - src/hw/ps2port.c | 16 ++-- 2 files changed, 6 in

[SeaBIOS] [PATCH 0/3] Patches for baytrail based chromebooks

2015-08-17 Thread Kevin O'Connor
the hardware. This series is also available at: https://github.com/KevinOConnor/seabios/tree/baytrail-testing -Kevin Kevin O'Connor (3): Add minimal support for machines without hardware interrupts ps2: Eliminate "etc/ps2-poll-only"; use CONFIG_HARDWARE_IRQ instead sdcar

[SeaBIOS] [PATCH] rtc: Support disabling the RTC timer irq support

2015-08-17 Thread Kevin O'Connor
Add a build time config option to remove support for RTC timer interrupts along with the associated bios calls requiring that support. Signed-off-by: Kevin O'Connor --- src/Kconfig | 9 + src/clock.c | 13 - src/hw/rtc.c | 6 ++ src/stacks.c | 2 +- 4 files ch

Re: [SeaBIOS] [PATCH 00/14] Initial sdcard support on real hardware

2015-08-17 Thread Kevin O'Connor
On Wed, Aug 12, 2015 at 04:03:21PM -0400, Kevin O'Connor wrote: > This series further improves the SeaBIOS sdcard support. At the > conclusion of the series the sdcard support is enabled on > configurations beyond QEMU. > > This code was tested on an Asus C300 (a Baytr

Re: [SeaBIOS] [PATCH 1/2] edd: Pass the segment/offset from int 1348 calls using a 'struct segoff_s'

2015-08-17 Thread Kevin O'Connor
On Thu, Aug 13, 2015 at 11:49:09AM -0400, Kevin O'Connor wrote: > Signed-off-by: Kevin O'Connor FYI, I committed this series. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 1/2] Move CanInterrupt check to check_irqs() and wait_irq()

2015-08-17 Thread Kevin O'Connor
On Thu, Aug 13, 2015 at 10:16:30AM -0400, Kevin O'Connor wrote: > Signed-off-by: Kevin O'Connor FYI, I committed a slightly modified version of this series. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mai

Re: [SeaBIOS] [PATCH] optionroms: Don't run option rom on PCI bar if CBFS/fw_cfg version exists

2015-08-17 Thread Kevin O'Connor
On Wed, Aug 12, 2015 at 11:20:35AM -0400, Kevin O'Connor wrote: > If there exists a "pci%04x,%04x.rom" file in CBFS/fw_cfg then the code > should not attempt to run a rom found on the PCI device itself - even > if the one in CBFS/fw_cfg is not a valid rom. This ma

[SeaBIOS] [PATCH 2/2] edd: Reduce parameters to fill_generic_edd()

2015-08-13 Thread Kevin O'Connor
Have callers of fill_generic_edd() calculate the edd iface_path field. Have callers determine if the bus type is PCI vs ISA. Signed-off-by: Kevin O'Connor --- src/block.c | 77 - 1 file changed, 45 insertions(+), 32 deletions(-)

[SeaBIOS] [PATCH 1/2] edd: Pass the segment/offset from int 1348 calls using a 'struct segoff_s'

2015-08-13 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/block.c | 16 +--- src/block.h | 2 +- src/disk.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/block.c b/src/block.c index a1054ac..cd732c1 100644 --- a/src/block.c +++ b/src/block.c @@ -288,10 +2

Re: [SeaBIOS] serial console : no keystroke

2015-08-13 Thread Kevin O'Connor
On Thu, Aug 13, 2015 at 03:47:26PM +0200, Maxime de Roucy wrote: > Hello, > > I am trying vanilla coreboot/SeaBios on an pc-engines apu1d4 : > http://www.pcengines.ch/apu1d4.htm > > The board natively use a modified version of coreboot, the sources are > available at http://www.pcengines.ch/howto

[SeaBIOS] [PATCH 2/2] Call cpu_relax() if yielding prior to interrupts being enabled

2015-08-13 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/stacks.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/stacks.c b/src/stacks.c index 1cd0fde..192fb2a 100644 --- a/src/stacks.c +++ b/src/stacks.c @@ -661,9 +661,11 @@ fail: void VISIBLE16 check_irqs(void) { -

[SeaBIOS] [PATCH 1/2] Move CanInterrupt check to check_irqs() and wait_irq()

2015-08-13 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/stacks.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/stacks.c b/src/stacks.c index 1ad9ef0..1cd0fde 100644 --- a/src/stacks.c +++ b/src/stacks.c @@ -661,6 +661,9 @@ fail: void VISIBLE16 check_irqs(void) { +

Re: [SeaBIOS] [PATCH] build: Require "make VERSION=x" parameter to be on command line

2015-08-13 Thread Kevin O'Connor
On Thu, Aug 13, 2015 at 07:59:42AM +0200, Paul Menzel wrote: > Am Mittwoch, den 12.08.2015, 18:32 -0400 schrieb Kevin O'Connor: > > Don't pull in VERSION from the build environment - there is too great > > a potential for a variable conflict. > > &g

Re: [SeaBIOS] Issue booting to Linux Live DVD image using coreboot, SeaBIOS and QEMU

2015-08-12 Thread Kevin O'Connor
On Wed, Aug 12, 2015 at 10:23:00AM -0700, Dustin Brazeau wrote: > I'm attempting to use QEMU, coreboot and SeaBIOS to boot a live Fedora > image. I have built a coreboot image with SeaBIOS as the payload. I can get > QEMU to boot all the way to the SeaBIOS's boot menu, but pressing F12 > doesn't no

[SeaBIOS] [PATCH] build: Require "make VERSION=x" parameter to be on command line

2015-08-12 Thread Kevin O'Connor
Don't pull in VERSION from the build environment - there is too great a potential for a variable conflict. Signed-off-by: Kevin O'Connor --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index e287530..220a9f7 100644 --- a/Makefile +++ b/Makefil

<    7   8   9   10   11   12   13   14   15   16   >