1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On 24/8/23 10:57, Gerd Hoffmann wrote:
With loglevel 1 (same we use for RAM entries),
so it is included in the firmware log by default.
Signed-off-by: Gerd Hoffmann
---
src/fw/paravirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
f the FIFO.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Paolo Bonzini
---
src/hw/esp-scsi.c | 4
1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an ema
f the FIFO.
Signed-off-by: Mark Cave-Ayland
---
src/hw/esp-scsi.c | 4
1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
f the FIFO.
Signed-off-by: Mark Cave-Ayland
---
src/hw/esp-scsi.c | 4
1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On 3/7/23 12:51, Paul Menzel wrote:
Just a note, Mailman’s rewrite of the `From` header field resulted in
the author information below in the SeaBIOS git archive [1][2]:
> Niklas Cassel via SeaBIOS
No idea, how to solve this.
Thanks for reporting. Candidate patch using git .mailmap
(https
es: dc776a2 ("nvme: avoid use-after-free in nvme_controller_enable()")
Fixes: 54082c8 ("nvme: fix missing newline on sq full print")
Fixes: b0d61ec ("usb-hid: Increase MAX_KBD_EVENT")
Reported-by: Paul Menzel
Signed-off-by: Philippe Mathieu-Daudé
---
.mailmap | 23 +
;
> Signed-off-by: Gerd Hoffmann
> ---
> src/fw/dsdt_parser.c | 21 +
> 1 file changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On 9/30/20 1:12 PM, Gerd Hoffmann wrote:
> ... via "%X" format string.
>
> Signed-off-by: Gerd Hoffmann
> ---
> src/output.c | 49 +++--
> 1 file changed, 27 insertions(+), 22 deletions(-)
Reviewe
ble_length += t0_len;
> +if (t0_len > ep.max_structure_size)
> +ep.max_structure_size = t0_len;
> +ep.number_of_structures++;
> + }
> }
>
> /* allocate final blob and record its address in the entry point */
>
Rev
ffer do not
> overflow.
>
> Signed-off-by: Paul Menzel
Reviewed-by: Philippe Mathieu-Daudé
> ---
> src/hw/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/hw/nvme.c b/src/hw/nvme.c
> index 41f3b76..6a01204 100644
> --- a/src/h
(&dop);
if (ret)
-dprintf(1, "scsi_is_ready returned %d\n", ret);
+dprintf(5, "scsi_is_ready returned %d\n", ret);
// Read the Boot Record Volume Descriptor
u8 buffer[CDROM_SECTOR_SIZE];
Reviewed-by
On 5/8/20 1:37 PM, Gerd Hoffmann wrote:
Read month register which should never have a value larger than 12.
In case the read returns 0xff assume the rtc isn't there.
Don't try to read the cpu count from cmos without rtc.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mat
&eax, &ebx, &ecx, &edx);
+dprintf(1, "kvm: have invtsc, freq %u kHz\n", eax);
What is "invtsc"? "tsc" alone maybe?
Reviewed-by: Philippe Mathieu-Daudé
+tsctimer_setfreq(eax);
+}
}
}
_
+;
-t = (t + 1) >> 1;
-}
-TimerKHz = DIV_ROUND_UP((u32)t, 1000 * PMTIMER_TO_PIT);
-TimerPort = 0;
-
-dprintf(1, "CPU Mhz=%u\n", (TimerKHz << ShiftTSC) / 1000);
+tsctimer_configure(t);
}
// Setup internal timers.
Reviewed-by: Philippe Mathieu-Dau
On Tue, Mar 3, 2020 at 7:08 PM Philippe Mathieu-Daudé wrote:
>
> Hello Paul,
>
> On 3/3/20 5:50 PM, Paul Menzel wrote:
> > Date: Tue, 3 Mar 2020 16:24:46 +0100
> >
> > GCC 10 gives the warnings below:
> >
> > In file included from out/ccode32fla
Hello Paul,
On 3/3/20 5:50 PM, Paul Menzel wrote:
Date: Tue, 3 Mar 2020 16:24:46 +0100
GCC 10 gives the warnings below:
In file included from out/ccode32flat.o.tmp.c:54:
./src/tcgbios.c: In function 'tpm20_write_EfiSpecIdEventStruct':
./src/tcgbios.c:290:30: warning: array subsc
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On 1/14/20 10:25 AM, Gerd Hoffmann wrote:
Check each disk attached to a virtio-scsi device whenever
it is bootable and skip initialization in case it isn't.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
---
src/hw/virtio-scsi.c | 11 ++-
1 file change
On 1/14/20 10:25 AM, Gerd Hoffmann wrote:
Call find_prio("HALT") only once, on first is_bootprio_strict() call.
Store the result in a variable and reuse it on subsequent calls.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
---
src/boot.c | 6 +-
1 file
Hi Sam,
On 11/13/19 4:03 PM, Sam Eiderman wrote:
Hi,
Does this fix a bug that actually happened?
I just noticed that in my lchs patches I assumed that lchs struct is
zeroed out in all devices (not only ahci):
9caa19be0e53 (geometry: Apply LCHS values for boot devices)
Seems like this is not
cr_selection, pcrSelect))
+return -1;
+
tpm20_pcr_selection = malloc_high(size);
if (tpm20_pcr_selection) {
memcpy(tpm20_pcr_selection, &trg->data, size);
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mail
if (irc != 0)
+if (irc != 0 ||
+*respbufferlen < sizeof(struct tpm_rsp_header))
return -1;
td->ready();
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an em
Hi Daniel,
On 10/29/19 6:42 PM, cyrev...@googlemail.com wrote:
From: Daniel Maslowski
Can you explain the rational of this patch?
In particular why use signed vs unsigned.
Thanks,
Phil.
Signed-off-by: Daniel Maslowski
---
src/lodepng.c | 12 ++--
1 file changed, 6 insertions(+
, 14 insertions(+)
FWIW =)
Reviewed-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
logical geometries directly we are able to support such
"exotic" disks.
We serialize this information in a similar way to the "bootorder"
interface.
The new fw_cfg entry is "bios-geometry".
Reviewed-by: Karl Heubaum
Reviewed-by: Arbel Moshe
Reviewed-by: Philippe Mat
: Arbel Moshe
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eiderman
---
bootdevice.c | 61 +---
1 file changed, 34 insertions(+), 27 deletions(-)
diff --git a/bootdevice.c b/bootdevice.c
index bc5e1c2de4
**errp)
@@ -3018,6 +3029,7 @@ static void scsi_hd_class_initfn(ObjectClass *klass, void
*data)
SCSIDeviceClass *sc = SCSI_DEVICE_CLASS(klass);
sc->realize = scsi_hd_realize;
+sc->unrealize = scsi_unrealize;
sc->alloc_req= scsi_new_request;
sc->u
On 10/16/19 6:41 PM, Sam Eiderman wrote:
From: Sam Eiderman
We will need to add LCHS removal logic to scsi-hd's unrealize() in the
next commit.
Reviewed-by: Karl Heubaum
Reviewed-by: Arbel Moshe
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eid
/* handler to set the boot_device order for a specific type of MachineClass */
typedef void QEMUBootSetHandler(void *opaque, const char *boot_order,
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
___
SeaBIOS mailing li
ices include:
* ide-hd
* scsi-hd
* virtio-blk-pci
In future commits we will use the provided LCHS and pass it to the BIOS
through fw_cfg to be supplied using INT13 routines.
Reviewed-by: Karl Heubaum
Reviewed-by: Arbel Moshe
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eide
On 10/21/19 5:31 PM, Kevin O'Connor wrote:
Update the documentation to be explicit about the signed-off-by
convention.
Signed-off-by: Kevin O'Connor
Reviewed-by: Philippe Mathieu-Daudé
---
docs/Contributing.md | 5
docs/developer-certificate-of-o
On 10/16/19 5:19 PM, Sam Eiderman wrote:
Sure!
Philippe withdrew his R-b on 7/8, as I explained 7/8 is fine (only
need to remove a bad comment) the problem was in the tests 8/8 -
should I include the original R/b?
I withdrew it because John was preparing his pull request, and I needed
more ti
On 10/16/19 2:14 PM, Laszlo Ersek wrote:
Hi Sam,
On 10/16/19 13:02, Sam Eiderman wrote:
Gentle Ping,
Philippe, John?
Just wondering if the series is okay, as Gerd pointed out this series
is a blocker for the corresponding changes in SeaBIOS for v 1.13
The QEMU series is still not merged, du
Hi Sam,
On 9/29/19 12:13 PM, Sam Eiderman wrote:
Philippe, thanks for the fast review,
Fast is not always the friend of careful.
John, thanks for picking up this hot potato :-)
Sam
On Thu, Sep 26, 2019 at 10:16 PM Philippe Mathieu-Daudé
mailto:phi...@redhat.com>> wrote:
On 9
On 9/26/19 9:09 PM, Philippe Mathieu-Daudé wrote:
> On 9/26/19 8:26 PM, John Snow wrote:
>> On 9/26/19 5:57 AM, Philippe Mathieu-Daudé wrote:
>>> Hi Sam,
>>>
>>> On 9/25/19 1:06 PM, Sam Eiderman wrote:
>>>> From: Sam Eiderman
>>>>
>&g
On 9/26/19 8:26 PM, John Snow wrote:
> On 9/26/19 5:57 AM, Philippe Mathieu-Daudé wrote:
>> Hi Sam,
>>
>> On 9/25/19 1:06 PM, Sam Eiderman wrote:
>>> From: Sam Eiderman
>>>
>>> Using fw_cfg, supply logical CHS values directly from QEMU to the BIO
On 9/25/19 1:06 PM, Sam Eiderman wrote:
> From: Sam Eiderman
>
> Add QTest tests to check the logical geometry override option.
>
> The tests in hd-geo-test are out of date - they only test IDE and do not
> test interesting MBRs.
>
> I added a few helper functions which will make adding more te
Hi Sam,
On 9/25/19 1:06 PM, Sam Eiderman wrote:
> From: Sam Eiderman
>
> Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS.
>
> Non-standard logical geometries break under QEMU.
>
> A virtual disk which contains an operating system which depends on
> logical geometries (co
char *suffix)
Please update to 'const char *suffix'.
John, can you do it directly in your tree before sending the pull request?
With it:
Reviewed-by: Philippe Mathieu-Daudé
> +{
> +char *devpath = NULL, *s = NULL, *d, *bootpath;
> +
> +if (dev) {
>
Eiderman
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/scsi/scsi-bus.c | 16
> include/hw/scsi/scsi.h | 1 +
> 2 files changed, 17 insertions(+)
>
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index bccb7cc4c6..359d50d6d0 100644
> --- a/
On 9/25/19 1:06 PM, Sam Eiderman wrote:
> From: Sam Eiderman
>
> Fixing tabbing in block related macros.
>
> Reviewed-by: Karl Heubaum
> Reviewed-by: Arbel Moshe
> Signed-off-by: Sam Eiderman
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/ide/qdev.c
#x27;Connor
Reviewed-by: Philippe Mathieu-Daudé
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index d16d1ae..5f7d537 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -68,6 +68,7 @@ COMMONCFLAGS += $(call cc-option,$(CC)
Cc'ing Eduardo, Paolo.
On 8/20/19 3:38 PM, Philippe Mathieu-Daudé wrote:
> On 8/20/19 3:12 PM, John Snow wrote:
>> On 8/20/19 6:25 AM, Philippe Mathieu-Daudé wrote:
>>> [cross posting QEMU & SeaBIOS]
>>>
>>> Hello,
>>>
>>> I'v
[Sorry seabios@ list for the noise!]
On 8/20/19 4:54 PM, Philippe Mathieu-Daudé wrote:
> On 8/20/19 4:36 PM, Dr. David Alan Gilbert wrote:
>> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
>>> On 8/20/19 3:38 PM, Philippe Mathieu-Daudé wrote:
>>>> On 8/
On 8/20/19 4:36 PM, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
>> On 8/20/19 3:38 PM, Philippe Mathieu-Daudé wrote:
>>> On 8/20/19 3:12 PM, John Snow wrote:
>>>> On 8/20/19 6:25 AM, Philippe Mathieu-Daudé wrote:
>&
On 8/20/19 3:38 PM, Philippe Mathieu-Daudé wrote:
> On 8/20/19 3:12 PM, John Snow wrote:
>> On 8/20/19 6:25 AM, Philippe Mathieu-Daudé wrote:
>>> [cross posting QEMU & SeaBIOS]
>>>
>>> Hello,
>>>
>>> I'v been looking at a QEMU
On 8/20/19 3:12 PM, John Snow wrote:
> On 8/20/19 6:25 AM, Philippe Mathieu-Daudé wrote:
>> [cross posting QEMU & SeaBIOS]
>>
>> Hello,
>>
>> I'v been looking at a QEMU bug report [1] which bisection resulted in a
>> SeaBIOS commit:
>>
>&g
[cross posting QEMU & SeaBIOS]
Hello,
I'v been looking at a QEMU bug report [1] which bisection resulted in a
SeaBIOS commit:
4a6dbcea3e412fe12effa2f812f50dd7eae90955 is the first bad commit
commit 4a6dbcea3e412fe12effa2f812f50dd7eae90955
Author: Nikolay Nikolov
Date: Sun Feb 4 17:27:01 2018
ndex d2d11db..909c0a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -23,7 +23,7 @@ OBJCOPY=$(CROSS_PREFIX)objcopy
> OBJDUMP=$(CROSS_PREFIX)objdump
> STRIP=$(CROSS_PREFIX)strip
> PYTHON=python
> -CPP=cpp
> +CPP=$(CROSS_PREFIX)cpp
>
On 1/9/19 7:01 PM, Mike Banon wrote:
> Please tell, will the old ASCII mailing list archive continue to work
> and get the new messages?
> I found it as really convenient to wget and observe with lightweight
> browsers or even console "links"
This is also useful when you want to reply to a thread
On 10/06/2017 11:33 AM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
> ---
> src/x86.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/x86.h b/src/x86.h
On 10/06/2017 11:33 AM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
>
> It seems both TIS & CRB devices share the same timeout. Make
> initialization function generic for now.
>
> Signed-off-by: Marc-André L
Hi Patrick,
On 03/17/2017 01:49 PM, Patrick Rudolph wrote:
Advertise compatible VESA modes, that are smaller or equal to
coreboot's active framebuffer. Only modes that have the same Bpp
are advertise and can be selected.
Allows the Windows 7 bootloader NTLDR to show up in VESA mode.
Allows to s
On 02/24/2017 03:27 AM, Daniel Verkamp wrote:
The status code field is 8 bits wide starting at bit 1; the previous
code would truncate the top bit.
Signed-off-by: Daniel Verkamp
Reviewed-by: Philippe Mathieu-Daudé
---
src/hw/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 02/24/2017 03:27 AM, Daniel Verkamp wrote:
It looks like the intent was to exit the loop if a command failed, but
the current code would actually continue looping in that case.
Signed-off-by: Daniel Verkamp
Reviewed-by: Philippe Mathieu-Daudé
---
src/hw/nvme.c | 2 +-
1 file changed
On 02/24/2017 03:27 AM, Daniel Verkamp wrote:
Signed-off-by: Daniel Verkamp
Reviewed-by: Philippe Mathieu-Daudé
---
src/hw/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hw/nvme.c b/src/hw/nvme.c
index 9fda011..60557ae 100644
--- a/src/hw/nvme.c
+++ b/src
57 matches
Mail list logo