Re: [SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

2014-12-03 Thread Gerd Hoffmann
On Di, 2014-12-02 at 10:40 -0500, Kevin O'Connor wrote: On Mon, Dec 01, 2014 at 10:56:09PM +0100, Patrick Georgi wrote: objdump output parsing expects C locale strings and formatting. Make sure it gets what it requires. Signed-off-by: Patrick Georgi pgeo...@google.com Thanks. Your

Re: [SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

2014-12-03 Thread Gerd Hoffmann
Hi, How about this: [export LC_ALL globally in Makefile] Tested-By: Patrick Georgi pgeo...@google.com pushed to master. cheers, Gerd ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

2014-12-03 Thread Kevin O'Connor
On Wed, Dec 03, 2014 at 11:16:39AM +0100, Gerd Hoffmann wrote: On Di, 2014-12-02 at 10:40 -0500, Kevin O'Connor wrote: On Mon, Dec 01, 2014 at 10:56:09PM +0100, Patrick Georgi wrote: objdump output parsing expects C locale strings and formatting. Make sure it gets what it requires.

Re: [SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

2014-12-03 Thread Gerd Hoffmann
Hi, export KCONFIG_CONFIG := $(CURDIR)/.config +export LC_ALL := C Does that impact kconfig? As far I know kconfig isn't localized, so I don't think it has any effect there. Also works fine on a quick test. cheers, Gerd

Re: [SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

2014-12-02 Thread Kevin O'Connor
On Mon, Dec 01, 2014 at 10:56:09PM +0100, Patrick Georgi wrote: objdump output parsing expects C locale strings and formatting. Make sure it gets what it requires. Signed-off-by: Patrick Georgi pgeo...@google.com Thanks. Your patch misses the call to OBJDUMP in bios.bin.prep though. Does

[SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

2014-12-01 Thread Patrick Georgi
objdump output parsing expects C locale strings and formatting. Make sure it gets what it requires. Signed-off-by: Patrick Georgi pgeo...@google.com --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eecb8a1..9191509 100644 ---