[SeaBIOS] [PATCH] init_virtio_scsi(): reset the HBA before freeing its virtio ring

2014-01-14 Thread Laszlo Ersek
When init_virtio_scsi() finds no SCSI targets connected to the HBA, it frees the virtio ring. Other code in SeaBIOS proceeds to overwrite the area. However, the ring is in use by qemu at that point -- not only did we report the (ACK|DRIVER|DRIVER_OK) status earlier, we even communicated over the ri

Re: [SeaBIOS] [PATCH] init_virtio_scsi(): reset the HBA before freeing its virtio ring

2014-01-15 Thread Paolo Bonzini
Il 15/01/2014 02:48, Laszlo Ersek ha scritto: > When init_virtio_scsi() finds no SCSI targets connected to the HBA, it > frees the virtio ring. Other code in SeaBIOS proceeds to overwrite the > area. However, the ring is in use by qemu at that point -- not only did we > report the (ACK|DRIVER|DRIVE

Re: [SeaBIOS] [PATCH] init_virtio_scsi(): reset the HBA before freeing its virtio ring

2014-01-17 Thread Kevin O'Connor
On Wed, Jan 15, 2014 at 11:01:59AM +0100, Paolo Bonzini wrote: > Il 15/01/2014 02:48, Laszlo Ersek ha scritto: > > When init_virtio_scsi() finds no SCSI targets connected to the HBA, it > > frees the virtio ring. Other code in SeaBIOS proceeds to overwrite the > > area. However, the ring is in use

Re: [SeaBIOS] [PATCH] init_virtio_scsi(): reset the HBA before freeing its virtio ring

2014-01-17 Thread Laszlo Ersek
On 01/17/14 18:17, Kevin O'Connor wrote: > On Wed, Jan 15, 2014 at 11:01:59AM +0100, Paolo Bonzini wrote: >> Il 15/01/2014 02:48, Laszlo Ersek ha scritto: >>> When init_virtio_scsi() finds no SCSI targets connected to the HBA, it >>> frees the virtio ring. Other code in SeaBIOS proceeds to overwrit