[SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-22 Thread Kevin O'Connor
Hi Stefan, As part of trying to better understand the TPM code, I found some changes to tcgbios.c were helpful. It's mostly code movement. I've only compile tested these changes, but I think they are safe. I don't want to conflict with any changes you may have pending. So, let me know if this

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-22 Thread Stefan Berger
On 11/22/2015 12:20 PM, Kevin O'Connor wrote: Hi Stefan, As part of trying to better understand the TPM code, I found some changes to tcgbios.c were helpful. It's mostly code movement. I've only compile tested these changes, but I think they are safe. I don't want to conflict with any changes

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-22 Thread Kevin O'Connor
On Sun, Nov 22, 2015 at 06:54:47PM -0500, Stefan Berger wrote: > On 11/22/2015 12:20 PM, Kevin O'Connor wrote: > >Hi Stefan, > > > >As part of trying to better understand the TPM code, I found some > >changes to tcgbios.c were helpful. It's mostly code movement. I've > >only compile tested these

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-22 Thread Stefan Berger
On 11/22/2015 08:26 PM, Kevin O'Connor wrote: On Sun, Nov 22, 2015 at 06:54:47PM -0500, Stefan Berger wrote: On 11/22/2015 12:20 PM, Kevin O'Connor wrote: Hi Stefan, As part of trying to better understand the TPM code, I found some changes to tcgbios.c were helpful. It's mostly code movement.

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-23 Thread Kevin O'Connor
On Sun, Nov 22, 2015 at 11:11:36PM -0500, Stefan Berger wrote: > On 11/22/2015 08:26 PM, Kevin O'Connor wrote: > >I will hold off on further changes until you can merge any features > >you have pending. > > It's mostly the menu that I would want to have merged next. All patches > after that are no

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-23 Thread Kevin O'Connor
On Mon, Nov 23, 2015 at 11:17:35AM -0500, Kevin O'Connor wrote: >However, it seems like just undoing my > patch 4 makes the most sense. I'll pull that patch out and repost > tonight. FYI, I modified the series (mostly reverted patch 4) and pushed to github: https://github.com/KevinOConnor/seab

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-24 Thread Stefan Berger
On 11/23/2015 11:40 PM, Kevin O'Connor wrote: On Mon, Nov 23, 2015 at 11:17:35AM -0500, Kevin O'Connor wrote: However, it seems like just undoing my patch 4 makes the most sense. I'll pull that patch out and repost tonight. FYI, I modified the series (mostly reverted patch 4) and pushed to git

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-28 Thread Kevin O'Connor
On Tue, Nov 24, 2015 at 12:40:32PM -0500, Stefan Berger wrote: > On 11/23/2015 11:40 PM, Kevin O'Connor wrote: > >On Mon, Nov 23, 2015 at 11:17:35AM -0500, Kevin O'Connor wrote: > >>However, it seems like just undoing my > >>patch 4 makes the most sense. I'll pull that patch out and repost > >>ton

Re: [SeaBIOS] [PATCH 0/7] Some TPM code reorganization

2015-11-30 Thread Stefan Berger
On 11/28/2015 07:44 AM, Kevin O'Connor wrote: On Tue, Nov 24, 2015 at 12:40:32PM -0500, Stefan Berger wrote: On 11/23/2015 11:40 PM, Kevin O'Connor wrote: On Mon, Nov 23, 2015 at 11:17:35AM -0500, Kevin O'Connor wrote: However, it seems like just undoing my patch 4 makes the most sense. I'll