Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-30 Thread Kevin O'Connor
On Wed, Dec 30, 2015 at 07:06:58PM -0500, Kevin O'Connor wrote: > On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote: > > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > > >+static u8 TPM_working; > > > > Should this not also have VARLOW to not be ROM'ed? > > The only code that runs af

Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-30 Thread Kevin O'Connor
On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >Perform the hardware probe once during setup instead of checking if > >the probe has been completed on each measurement event. > > > >Don't probe for hardware during BIOS interface dete

Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-30 Thread Stefan Berger
On 12/29/2015 07:17 PM, Kevin O'Connor wrote: Perform the hardware probe once during setup instead of checking if the probe has been completed on each measurement event. Don't probe for hardware during BIOS interface detection. Just check if the hardware is in a working state. Unify has_workin

[SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-29 Thread Kevin O'Connor
Perform the hardware probe once during setup instead of checking if the probe has been completed on each measurement event. Don't probe for hardware during BIOS interface detection. Just check if the hardware is in a working state. Unify has_working_tpm() with similar tpm_is_working(). Signed-o