Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

On Mon, Nov 30, 2015 at 06:18:27AM +0100, Peter Stuge wrote: > Sorry, should have sent all in one email. > > Stefan Berger wrote: > > +if (enable) > > +dprintf(DEBUG_tcg, "Return code from TPM_PhysicalEnable = > > 0x%08x\n", > > +*returnCode); > > +else > > +

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

On Sun, Nov 29, 2015 at 11:49:43PM -0500, Stefan Berger wrote: > From: Stefan Berger > > This patch adds an new menu entry to the main menu. This menu item enables > the user to enter a TPM control menu which allows control of those aspects > of the TPM's state that

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

Kevin O'Connor wrote: > > > +static u32 > > > +read_stclear_flags(char *buf, int buf_len) > > > +{ > > .. > > > +if (rc || returnCode) > > > +goto err_exit; > > .. > > > +err_exit: > > > +dprintf(DEBUG_tcg, "TCGBIOS: TPM malfunctioning (line %d).\n", > > > __LINE__); > > > > I

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

"Kevin O'Connor" wrote on 11/30/2015 10:05:22 AM: > From: "Kevin O'Connor" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: seabios@seabios.org, Stefan Berger > Date: 11/30/2015 10:05 AM > Subject: Re: [PATCH 3/3] tpm: Add a menu

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

On Mon, Nov 30, 2015 at 10:23:28AM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 11/30/2015 10:05:22 AM: > > Are the above definitions part of the standard, or internal to the > > implementation? If the latter, they should go into tcgbios.[ch] > > These are

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

On Mon, Nov 30, 2015 at 06:02:45AM +0100, Peter Stuge wrote: > Stefan Berger wrote: > > +++ b/src/tcgbios.c > > +static u32 > > +read_stclear_flags(char *buf, int buf_len) > > +{ > .. > > +if (rc || returnCode) > > +goto err_exit; > .. > > +err_exit: > > +dprintf(DEBUG_tcg,

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

Stefan Berger wrote: > +++ b/src/tcgbios.c > +static u32 > +read_stclear_flags(char *buf, int buf_len) > +{ .. > +if (rc || returnCode) > +goto err_exit; .. > +err_exit: > +dprintf(DEBUG_tcg, "TCGBIOS: TPM malfunctioning (line %d).\n", __LINE__); I can't help but think that it

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

Sorry, should have sent all in one email. Stefan Berger wrote: > +if (enable) > +dprintf(DEBUG_tcg, "Return code from TPM_PhysicalEnable = 0x%08x\n", > +*returnCode); > +else > +dprintf(DEBUG_tcg, "Return code from TPM_PhysicalDisable = 0x%08x\n", > +