Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 02:59, Hu Tao ha scritto: Why doesn't it work with q35? ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest, one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We should use the one in q35-acpi-dsdt.hex to patch DSDT for q35. But including

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-26 Thread Hu Tao
On Tue, Mar 26, 2013 at 08:03:09AM +0100, Paolo Bonzini wrote: Il 26/03/2013 02:59, Hu Tao ha scritto: Why doesn't it work with q35? ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest, one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We should use the

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-26 Thread Paolo Bonzini
Il 26/03/2013 08:24, Hu Tao ha scritto: ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest generates two dsdt_isa_pest, one in out/acpi-dsdt.hex the other in out/q35-acpi-dsdt.hex. We should use the one in q35-acpi-dsdt.hex to patch DSDT for q35. But including q35-acpi-dsdt.hex, along with

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-25 Thread Hu Tao
On Fri, Mar 22, 2013 at 09:48:18AM +0200, Gleb Natapov wrote: On Thu, Mar 21, 2013 at 05:17:11PM +0800, Hu Tao wrote: On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote: Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com ---

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-22 Thread Hu Tao
On Thu, Mar 21, 2013 at 06:54:59PM -0400, Kevin O'Connor wrote: On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com I don't think it is a good idea to dynamically modify the DSDT. We've been using the SSDT for that. In any case, I think

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-22 Thread Hu Tao
On Thu, Mar 21, 2013 at 11:54:25AM +0200, Michael S. Tsirkin wrote: On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com OK now you need to ACK GPLv2+ relicensing too :) Could you please review that message make acpi bits GPLv2 compatible and

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-22 Thread Gleb Natapov
On Thu, Mar 21, 2013 at 05:17:11PM +0800, Hu Tao wrote: On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote: Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl index

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Hu Tao
On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote: Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-)

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com OK now you need to ACK GPLv2+ relicensing too :) Could you please review that message make acpi bits GPLv2 compatible and respond? --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com I don't think it is a good idea to dynamically modify the DSDT. We've been using the SSDT for that. In any case, I think this would be a good candidate for merging after the ACPI stuff is moved