Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Kevin O'Connor
On Thu, May 08, 2014 at 07:29:15AM +, Gonglei (Arei) wrote: > > > > --- /dev/null > > > > +++ b/tools/firmware/hvmloader/tools/acpi_extract.py > > > > @@ -0,0 +1,308 @@ > > > > +#!/usr/bin/python > > > > +# Copyright (C) 2011 Red Hat, Inc., Michael S. Tsirkin > > > > > > > > +# > > > > +# Thi

Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Michael S. Tsirkin
On Thu, May 08, 2014 at 12:26:21PM +0100, Ian Campbell wrote: > On Thu, 2014-05-08 at 07:29 +, Gonglei (Arei) wrote: > > > +rmvc_pcrm = inl(PCI_RMV_BASE); > > > > > > > > > > > > So .. what is at this special 0xae0c address? > > > > > > > > Is there some code in QEMU that needs this tr

Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Ian Campbell
On Thu, 2014-05-08 at 11:32 +0300, Michael S. Tsirkin wrote: > Also I wonder: would it be possible for you to load the acpi > tables from qemu instead of generating your own? There is stuff in the tables for which the definition is Xen and not Qemu. The interrupt routing table is the one which I c

Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Ian Campbell
On Thu, 2014-05-08 at 07:29 +, Gonglei (Arei) wrote: > > +rmvc_pcrm = inl(PCI_RMV_BASE); > > > > > > > > > So .. what is at this special 0xae0c address? > > > > > > Is there some code in QEMU that needs this treatment as well? > > > > Yep, the 0xae0c is defined in upstream QEMU, which

Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Johannes Krampf
>> > Well, Xen code is under GPLv2 so I don't think you can do this? >> > >> > Unless Michael is willing to release it under a different licence? >> >> I'd be fine with "GPLv2 or later" so code can flow back to seabios >> as well - but you will have to track down everyone else who >> changed this f

Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Michael S. Tsirkin
On Thu, May 08, 2014 at 07:29:15AM +, Gonglei (Arei) wrote: > Hi, all > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Thursday, May 08, 2014 4:15 AM > > To: Konrad Rzeszutek Wilk > > Cc: Gonglei (Arei); qemu-de...@nongnu.org; xen-de...@lists.xen

Re: [SeaBIOS] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Gonglei (Arei)
Hi, all > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, May 08, 2014 4:15 AM > To: Konrad Rzeszutek Wilk > Cc: Gonglei (Arei); qemu-de...@nongnu.org; xen-de...@lists.xen.org; > Huangweidong (C); ian.campb...@citrix.com; stefano.stabell...@eu.citri