[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-28 Thread Sam Eiderman
Kevin, I have used your method to clean FSEG from unwanted date strings and added a new fw_cfg to control the date that will eventually appear in SystemBiosDate. New patches submitted. Thanks, Sam > On 24 May 2019, at 19:35, Sam Eiderman wrote: > > Kevin, > > Notice that your patch changes S

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-24 Thread Sam Eiderman
Kevin, Notice that your patch changes SystemBiosDate for legacy smbios users from 04/01/14 to 01/01/11 - Iā€™m okay with this change. Also notice that the RELEASE_DATE_STR[] in smbios.c has to be volatile or else it is optimized, unlike BIOS_DATE[] which is used in a function call and is not opti

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Gerd Hoffmann
Hi, > * Letting the user choose the date which will appear in the > SystemBiosDate registry key > Under QEMU. Ah, *this* is why qemu provides a type0 table. What is the use case for this? > Legacy SMBIOS Bios Date is '01/01/2011ā€™ Maybe it's time add a config option to compile out

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Sam Eiderman
I actually love this idea. So we can now expect only ā€™06/23/99ā€™ date string to reside in F-SEG at build time. This will allow setting the SystemBiosDate to all dates from 06/23/99 to 01/01/80 (2080) which is reasonable enough. So now we will copy the smbios0.date to "char win_bios_date[] VARFSE

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Kevin O'Connor
On Thu, May 23, 2019 at 06:58:57PM +0300, Sam Eiderman wrote: > > On 23 May 2019, at 18:54, Kevin O'Connor wrote: > > I understand. If we ensured the smbios date is always in the > > f-segment, would that also solve the problem? (That is, using the > > 'char win_bios_date[] VARFSEG' method discu

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Sam Eiderman
> On 23 May 2019, at 18:54, Kevin O'Connor wrote: > > On Thu, May 23, 2019 at 04:11:21PM +0300, Sam Eiderman wrote: >> Many programs use SystemBiosDate registry key in order to verify the machine >> they are running on (mostly for activation/licensing purposes). >> This registry key is read on

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Kevin O'Connor
On Thu, May 23, 2019 at 04:11:21PM +0300, Sam Eiderman wrote: > Many programs use SystemBiosDate registry key in order to verify the machine > they are running on (mostly for activation/licensing purposes). > This registry key is read only and is computed as explained before. > When this date chan

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Sam Eiderman
Hi, Many programs use SystemBiosDate registry key in order to verify the machine they are running on (mostly for activation/licensing purposes). This registry key is read only and is computed as explained before. When this date changes - this may break the behavior of the machine. This date neve

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-23 Thread Gerd Hoffmann
Hi, > > The thing is, if the date reported by smbios tables is 05/02/2015 (which is > > bigger than 04/01/2014) so: > > If smbios tables are in fseg - Windows will select the most recent date - > > 05/02/2015 > > If not - Windows will select the most recent date (the only one it found) - > >

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-22 Thread Kevin O'Connor
On Wed, May 22, 2019 at 04:49:35PM +0300, Sam Eiderman wrote: > > On 20 May 2019, at 5:28, Kevin O'Connor wrote: > > On Fri, May 17, 2019 at 11:57:23PM +0300, Sam Eiderman wrote: > >> From: Liran Alon > >> > >> Windows kernel extracts various BIOS information at boot-time. > >> The method it use

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-22 Thread R S
Oh my. Use of non-ISO8601 format in any form of computer code need to be sanctioned. On Wed, May 22, 2019 at 9:50 AM Sam Eiderman wrote: > > > On 20 May 2019, at 5:28, Kevin O'Connor wrote: > > On Fri, May 17, 2019 at 11:57:23PM +0300, Sam Eiderman wrote: > > From: Liran Alon > > Windows kerne

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-22 Thread Sam Eiderman
> On 20 May 2019, at 5:28, Kevin O'Connor wrote: > > On Fri, May 17, 2019 at 11:57:23PM +0300, Sam Eiderman wrote: >> From: Liran Alon >> >> Windows kernel extracts various BIOS information at boot-time. >> The method it uses to extract SystemBiosDate is very hueristic. >> It is done by nt!Cm

[SeaBIOS] Re: [PATCH 3/6] bios_date: Change BiosDate to SMBIOS bios date

2019-05-19 Thread Kevin O'Connor
On Fri, May 17, 2019 at 11:57:23PM +0300, Sam Eiderman wrote: > From: Liran Alon > > Windows kernel extracts various BIOS information at boot-time. > The method it uses to extract SystemBiosDate is very hueristic. > It is done by nt!CmpGetBiosDate(). > > nt!CmpGetBiosDate() works by scanning all