[security-dev 01564]: Re: Code review request: 6919610 KeyTabInputStream uses static field for per-instance value

2010-01-26 Thread Xuelei Fan
Looks fine to me. Xuelei On 1/25/2010 1:07 PM, Max (Weijun) Wang wrote: Hi All Please take a review at -- http://cr.openjdk.java.net/~weijun/6919610/webrev.00 Bug description follows. Thanks Max *Change Request ID*: 6919610 *Synopsis*: KeyTabInputStream uses static field for per-ins

[security-dev 01563]: Subject lines in security-dev.

2010-01-26 Thread Brad Wetmore
Looking for opinions as to whether the current subject line format of the security-...@o.j.n emails is useful: Subject: [security-dev 01800]: The Real subject. I note a lot of the client (e.g. sounds, swing) lists have just the list name, and a lot of the server lists (e.g. tl, hotspot) don'

[security-dev 01562]: hg: jdk7/tl/langtools: 6917130: should test that annotations that have been optimized away are not emitted to classfile

2010-01-26 Thread jonathan . gibbons
Changeset: 59167312ed4e Author:jjg Date: 2010-01-26 11:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/59167312ed4e 6917130: should test that annotations that have been optimized away are not emitted to classfile Reviewed-by: jjg, darcy Contributed-by: m...@csail.mit

[security-dev 01561]: hg: jdk7/tl/langtools: 6919944: incorrect position given for duplicate annotation value error

2010-01-26 Thread jonathan . gibbons
Changeset: da0e3e2dd3ef Author:jjg Date: 2010-01-26 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/da0e3e2dd3ef 6919944: incorrect position given for duplicate annotation value error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! te

[security-dev 01560]: hg: jdk7/tl/jdk: 6919185: test/closed/sun/net/ftp/FtpTests fails to compile

2010-01-26 Thread jean-christophe . collet
Changeset: f544825d0976 Author:jccollet Date: 2010-01-26 11:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f544825d0976 6919185: test/closed/sun/net/ftp/FtpTests fails to compile Summary: Fixed a couple of regressions in FtpClient and updated the test. Reviewed-by: chegar

[security-dev 01559]: hg: jdk7/tl/jdk: 6919610: KeyTabInputStream uses static field for per-instance value

2010-01-26 Thread weijun . wang
Changeset: 558f2a424bfa Author:weijun Date: 2010-01-26 17:03 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/558f2a424bfa 6919610: KeyTabInputStream uses static field for per-instance value Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ktab/KeyTabInputStr