hg: jdk7/tl/langtools: 6980017: javap -XDdetail:source behaves badly if source not available.

2010-08-26 Thread jonathan . gibbons
Changeset: ae3acbf63943 Author:jjg Date: 2010-08-26 16:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ae3acbf63943 6980017: javap -XDdetail:source behaves badly if source not available. Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! sr

hg: jdk7/tl/langtools: 6604599: ToolProvider should be less compiler-specific

2010-08-26 Thread jonathan . gibbons
Changeset: cfd047f3cf60 Author:jjg Date: 2010-08-26 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cfd047f3cf60 6604599: ToolProvider should be less compiler-specific Reviewed-by: darcy ! src/share/classes/javax/tools/ToolProvider.java + test/tools/javac/api/Tool

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-26 Thread Michael McMahon
Weijun Wang wrote: The internal structure of NTLMAuthentication is changed and that's why I changed the serialVersionUid as well. If unchanged, I guess the old serialized form can still be accepted by the new class, but all new field will become null/0. After the change, any such deserializatio

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-26 Thread Weijun Wang
The internal structure of NTLMAuthentication is changed and that's why I changed the serialVersionUid as well. If unchanged, I guess the old serialized form can still be accepted by the new class, but all new field will become null/0. After the change, any such deserialization should throw a ex

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

2010-08-26 Thread Michael McMahon
Why is the serialVersionUid changed in NTLMAuthentication? Otherwise, the encapsulation of NTLM in the new API looks quite concise and neat to me? Looks fine. - Michael Vincent Ryan wrote: The SASL component looks good Max. Michael/Chris: have you any comments on the NTLM changes? On 25/0