Hi All
http://cr.openjdk.java.net/~weijun/7055363/webrev.01/
*Attention*: please note that the jtreg mode for jdk_security3 is still
RunOthervmBatch. Xuelei is now working on the JSSE tests. Once he is
ready, he will change the mode to RunSamevmBatch.
The code changes:
* Still included in t
> Please review these JNDI changes.
> Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072353
> webrev: http://cr.openjdk.java.net/~mduigou/7072353/0/webrev/
Thanks for your effort to make JNDI free of compile-warning. The work is
hard, I appreciate it.
1. I noticed the copyright d
Changeset: 809e8db0c142
Author:chegar
Date: 2011-07-29 10:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/809e8db0c142
6978200: ServerSocket.toString include "port=0" in the returned String
Summary: Removal of "port=0" from ServerSocket.toString method
Reviewed-by: alanb, c
Xuelei Fan wrote:
:
1. I noticed the copyright date of a few files are unchanged, please
update them before you push the changes.
This has come up a few times but I don't think it is strictly required.
Kelly or one of the release engineers run a script over the forest
periodically to fix up
Weijun Wang wrote:
Hi All
http://cr.openjdk.java.net/~weijun/7055363/webrev.01/
I went through the changes to the tests and they look okay to me. It's
good to see so many tests removed from the problem list and the tests
updated to work in samevm or agentvm mode.
Is there a bug created for t
On Aug 3, 2011, at 12:11 AM, Alan Bateman wrote:
> Xuelei Fan wrote:
>> :
>> 1. I noticed the copyright date of a few files are unchanged, please
>> update them before you push the changes.
>>
> This has come up a few times but I don't think it is strictly required. Kelly
> or one of the rel
Thanks for reviewing! See my responses inline.
I'll wait on sending another webrev until I've received the rest of your
comments.
-Sasha
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
Please review these JNDI changes.
Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072353
webrev: htt
Thanks for reviewing! Please see my responses inline.
I'll wait on sending another webrev until I've received the rest of your
comments.
-Sasha
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
Please review these JNDI changes.
Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072353
webr
On 08/03/2011 12:43 AM, Alan Bateman wrote:
Weijun Wang wrote:
Hi All
http://cr.openjdk.java.net/~weijun/7055363/webrev.01/
I went through the changes to the tests and they look okay to me. It's
good to see so many tests removed from the problem list and the tests
updated to work in samevm o
com/sun/jndi/toolkit/dir/SearchFilter.java
451 for (NamingEnumeration ve = attr.getAll();
452 ve.hasMore();
453) {
The update is OK. But the coding style looks uncomfortable. Would you
mind change it to use for-each style?
. javax/naming/directory/BasicAtt
On 17:11 Tue 02 Aug , Alan Bateman wrote:
> Xuelei Fan wrote:
> > :
> > 1. I noticed the copyright date of a few files are unchanged, please
> > update them before you push the changes.
> >
> This has come up a few times but I don't think it is strictly required.
> Kelly or one of the relea
11 matches
Mail list logo
