Code review request for 7049079: NTSYSTEM CLASS IS LEAKING 3 WINDOWS TOKENS

2011-09-02 Thread Seán Coffey
This is a forward port to JDK 8 of a fix gone into jdk 5 and jdk6 releases. It'll be ported to 7u shortly after jdk8. Bug id is not public. NTSystem() obtains a native Token instance for each constructor call. This is unnecessary and Token instances should only be requested when called for,

hg: jdk8/tl/langtools: 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper

2011-09-02 Thread maurizio . cimadamore
Changeset: ec27e5befa53 Author:mcimadamore Date: 2011-09-02 17:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec27e5befa53 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper Summary: Missing override for

hg: jdk8/tl/jdk: 6898310: (cs) Charset cache lookups should be synchronized

2011-09-02 Thread xueming . shen
Changeset: 812c6d4d6a58 Author:sherman Date: 2011-09-02 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/812c6d4d6a58 6898310: (cs) Charset cache lookups should be synchronized Summary: synchronize the lookup in iterator Reviewed-by: alanb !

hg: jdk8/tl/jdk: 6989067: BigInteger's array copiers should be converted to System.arraycopy()

2011-09-02 Thread joe . darcy
Changeset: 95aff7cbf590 Author:darcy Date: 2011-09-02 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95aff7cbf590 6989067: BigInteger's array copiers should be converted to System.arraycopy() Reviewed-by: mduigou, forax ! src/share/classes/java/math/BigInteger.java

Re: Code review request for 7049079: NTSYSTEM CLASS IS LEAKING 3 WINDOWS TOKENS

2011-09-02 Thread Weijun Wang
The code change looks fine. Thanks Max On 09/02/2011 11:15 PM, Seán Coffey wrote: This is a forward port to JDK 8 of a fix gone into jdk 5 and jdk6 releases. It'll be ported to 7u shortly after jdk8. Bug id is not public. NTSystem() obtains a native Token instance for each constructor call.