Re: code review request: 7089889: Krb5LoginModule.login() throws an exception if used without a keytab

2011-09-20 Thread Xuelei Fan
It's OK. Xuelei On 9/21/2011 12:26 PM, Weijun Wang wrote: > > > On 09/21/2011 11:52 AM, Xuelei Fan wrote: >> On 9/20/2011 1:38 PM, Weijun Wang wrote: >>> Any more comment? >>> >>> Thanks >>> Max >>> >>> On 09/16/2011 01:57 PM, Weijun Wang wrote: On 09/16/2011 01:45 PM, Xuelei Fan

Re: code review request: 7089889: Krb5LoginModule.login() throws an exception if used without a keytab

2011-09-20 Thread Weijun Wang
On 09/21/2011 11:52 AM, Xuelei Fan wrote: On 9/20/2011 1:38 PM, Weijun Wang wrote: Any more comment? Thanks Max On 09/16/2011 01:57 PM, Weijun Wang wrote: On 09/16/2011 01:45 PM, Xuelei Fan wrote: My first impression about the fix: 1. Do you want to update getKeys() comments about isInit

Re: code review request: 7089889: Krb5LoginModule.login() throws an exception if used without a keytab

2011-09-20 Thread Xuelei Fan
On 9/20/2011 1:38 PM, Weijun Wang wrote: > Any more comment? > > Thanks > Max > > On 09/16/2011 01:57 PM, Weijun Wang wrote: >> >> >> On 09/16/2011 01:45 PM, Xuelei Fan wrote: >>> My first impression about the fix: >>> 1. Do you want to update getKeys() comments about isInitiator value? >> >> OK.

hg: jdk8/tl/jdk: 7012206: ~20 tools tests failing due to -XX:-UsePerfData default in Java SE Embedded

2011-09-20 Thread david . holmes
Changeset: d177eecda07e Author:dholmes Date: 2011-09-20 22:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d177eecda07e 7012206: ~20 tools tests failing due to -XX:-UsePerfData default in Java SE Embedded Summary: Explicitly enable UsePerfData for the tools that require it

hg: jdk8/tl/jdk: 7085944: 3/3 FDS: gdb does not find debug symbols for libjsig link

2011-09-20 Thread daniel . daugherty
Changeset: 029ba13aa0df Author:dcubed Date: 2011-09-20 19:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/029ba13aa0df 7085944: 3/3 FDS: gdb does not find debug symbols for libjsig link Summary: Add support for importing .debuginfo files from HSX. Reviewed-by: phh ! make/c

hg: jdk8/tl/jdk: 6268216: Boolean.getBoolean() throws SecurityException

2011-09-20 Thread joe . darcy
Changeset: 9b2fc8a11421 Author:darcy Date: 2011-09-20 18:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b2fc8a11421 6268216: Boolean.getBoolean() throws SecurityException Reviewed-by: mduigou ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Intege

Re: hg: jdk8/tl/jdk: 7091369: DatagramSocket/Limit.java failing on 8 and 7u2

2011-09-20 Thread Rémi Forax
On 09/19/2011 04:21 PM, michael.x.mcma...@oracle.com wrote: Changeset: e3d78fe803d4 Author:michaelm Date: 2011-09-19 15:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3d78fe803d4 7091369: DatagramSocket/Limit.java failing on 8 and 7u2 Reviewed-by: chegar, alanb ! src/w

Re: Code review request: 7088502 Security libraries don't build with javac -Werror

2011-09-20 Thread Kurchi Hazra
On 9/19/2011 12:23 PM, Sean Mullan wrote: On 09/16/2011 06:34 PM, Kurchi Hazra wrote: Hi Sean, Can you please review these changes? Summary: * Small changes to Java files in src/share/classes/com/sun/org/apache/xml/internal/security and its subpackages to remove build warnings. * Small chang

hg: jdk8/tl/jdk: 7074264: Switches to packages tree view and adds unit tests to sources

2011-09-20 Thread mike . duigou
Changeset: c77b41652266 Author:mduigou Date: 2011-09-20 12:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c77b41652266 7074264: Switches to packages tree view and adds unit tests to sources Reviewed-by: igor ! make/netbeans/README ! make/netbeans/common/closed-share-view.

hg: jdk8/tl/langtools: 7030473: Remove dead field JCCompilationUnit.flags

2011-09-20 Thread jonathan . gibbons
Changeset: ac964af3b5e7 Author:jjg Date: 2011-09-20 12:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac964af3b5e7 7030473: Remove dead field JCCompilationUnit.flags Reviewed-by: dlsmith ! src/share/classes/com/sun/tools/javac/tree/JCTree.java

Code review request: 7092375 Security libraries don't build with javac -Werror

2011-09-20 Thread Kurchi Hazra
Hi Xuelei, Can you please review these changes? Summary: 1. Small changes to Java files, mostly in src/share/classes/javax/security and its subpackages to remove build warnings. 2. Small changes to relevant makefiles to prevent reintroduction of removed warnings. Added a new makefile to preve