Re: Code review request: 7092375 Security libraries don't build with javac -Werror

2011-09-22 Thread Kurchi Hazra
Hi Xuelei, Thanks a lot for your comments. Please find an updated webrev at : http://cr.openjdk.java.net/~xuelei/7092375/webrev.01/ Thanks, Kurchi On 9/21/2011 3:44 AM, Xuelei Fan wrote: 1. "src/share/classes/javax/security/auth/SubjectDomainCombiner.java": public Void run() {

Re: 7054637 closed/lib/security/cacerts/VerifyCACerts.java failed on solaris 11

2011-09-22 Thread Michael StJohns
Hi Vincent - Sorry - it took me a few days to look at this. I can't support it. I think this the wrong way to do things - specifically the dependence on the presence of a PKCS11 attribute in the Vendor space. You've got a value in PKCS11Constants +/* Only the raw encoding for an EC

Re: Code review request: 7088502 Security libraries don't build with javac -Werror

2011-09-22 Thread Kurchi Hazra
Hi Sean, The updated webrev with your comments incorporated: http://cr.openjdk.java.net/~mullan/kurchi/7088502/webrev.01/ For SignatureAlgorithm.java [130, 399, 434] change type to Class and similar changes, I have stuck to your comment, and suppressed the "unchecked" warnings at the pl

hg: jdk8/tl/langtools: 7075721: javac should have public enum for exit codes

2011-09-22 Thread jonathan . gibbons
Changeset: 497571d34112 Author:jjg Date: 2011-09-22 09:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/497571d34112 7075721: javac should have public enum for exit codes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/co

code review request: 7077646: gssapi wrap for CFX per-message tokens always set FLAG_ACCEPTOR_SUBKEY

2011-09-22 Thread Weijun Wang
Webrev at http://cr.openjdk.java.net/~weijun/7077646/webrev.00/ According to RFC 4121 [1]: 2. Key Derivation for Per-Message Tokens ... During the context initiation and acceptance sequence, the acceptor MAY assert a subkey in the AP-REP message. If the acceptor asserts a sub