Re: Code review request, CR 6996372: synchronizing handshaking hash

2012-04-26 Thread Weijun Wang
Looks fine. It seems people normally put "static" before "final", but since there are already 2 "final static" there, you're free to do anything. Thanks Max On 04/27/2012 12:07 PM, Xuelei Fan wrote: On 4/27/2012 11:46 AM, David Schlosnagle wrote: On Apr 26, 2012, at 10:07 PM, Xuelei Fan wr

Re: Code review request, CR 6996372: synchronizing handshaking hash

2012-04-26 Thread Xuelei Fan
On 4/27/2012 11:46 AM, David Schlosnagle wrote: > On Apr 26, 2012, at 10:07 PM, Xuelei Fan wrote: > >> webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.00/ > > It might be worthwhile to add a comment that both disabledAlgorithmsMap and > keySizeConstraintsMap are locked by the disabled

Re: Code review request, CR 6996372: synchronizing handshaking hash

2012-04-26 Thread David Schlosnagle
On Apr 26, 2012, at 10:07 PM, Xuelei Fan wrote: > webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.00/ It might be worthwhile to add a comment that both disabledAlgorithmsMap and keySizeConstraintsMap are locked by the disabledAlgorithmsMap instance. Also, is there any reason not to m

Code review request, CR 6996372: synchronizing handshaking hash

2012-04-26 Thread Xuelei Fan
Hi Weijun, Are you available to review the simple fix for the unnecessarily used synchronizedMap()? webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.00/ Thanks, Xuelei

hg: jdk8/tl/jdk: 48 new changesets

2012-04-26 Thread lana . steuck
Changeset: fcc788b5f917 Author:mfang Date: 2012-03-16 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcc788b5f917 Merge Changeset: 5e32f84f0ca9 Author:mfang Date: 2012-03-22 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e32f84f0ca9 Merge

hg: jdk8/tl/hotspot: 38 new changesets

2012-04-26 Thread lana . steuck
Changeset: e02867d10860 Author:amurillo Date: 2012-03-30 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e02867d10860 7158137: new hotspot build - hs24-b07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 51612f0c0a79 Author:nloodin Date: 2012-03-15

hg: jdk8/tl/langtools: 6 new changesets

2012-04-26 Thread lana . steuck
Changeset: 807ca8ffbeb4 Author:ohair Date: 2012-04-10 08:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/807ca8ffbeb4 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by: oha

hg: jdk8/tl/jaxws: 4 new changesets

2012-04-26 Thread lana . steuck
Changeset: a34aee728ac0 Author:ohair Date: 2012-04-10 08:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a34aee728ac0 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by: ohair,

hg: jdk8/tl: 4 new changesets

2012-04-26 Thread lana . steuck
Changeset: e1830598f0b7 Author:ohair Date: 2012-04-10 08:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e1830598f0b7 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by: ohair, jjg, d

hg: jdk8/tl/corba: 5 new changesets

2012-04-26 Thread lana . steuck
Changeset: a1b6b8f33d86 Author:ohair Date: 2012-04-10 08:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a1b6b8f33d86 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by: ohair,

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Phil Race
All looks good to me. Compiler won't spot misspelled library names so I did try to check all those are still the same. -phil. On 4/26/2012 2:20 PM, Mandy Chung wrote: Thanks, Sean. I have fixed the 3 files per your comment. Mandy On 4/26/2012 1:59 PM, Sean Mullan wrote: Looks fine, just a c

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Mandy Chung
Thanks, Phil. FYI. I plan to use TL gate for the entire changeset. The change will show up in the awt/2D repos when this gets integrated in the next promoted build. Mandy On 4/26/2012 3:51 PM, Phil Race wrote: All looks good to me. Compiler won't spot misspelled library names so I did try

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Mandy Chung
Thanks, Sean. I have fixed the 3 files per your comment. Mandy On 4/26/2012 1:59 PM, Sean Mullan wrote: Looks fine, just a couple of nits. src/macosx/classes/com/apple/concurrent/LibDispatchNative.java, - the closing static brace is not indented the same as the open brace. src/solaris/cla

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Sean Mullan
Looks fine, just a couple of nits. src/macosx/classes/com/apple/concurrent/LibDispatchNative.java, - the closing static brace is not indented the same as the open brace. src/solaris/classes/sun/management/FileSystemImpl.java src/windows/classes/sun/management/FileSystemImpl.java - line-bre

hg: jdk8/tl/jdk: 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion

2012-04-26 Thread kurchi . subhra . hazra
Changeset: 108a02a57b75 Author:khazra Date: 2012-04-26 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/108a02a57b75 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Summary: Enable user to read/write preferences to persistent storage Revie

Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Mandy Chung
7164376 Replace use of sun.security.action.LoadLibraryAction with direct call of System.loadLibrary Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/ This change is required for jdk modularization. High level summary: it replaces the use of LoadLibraryAction: