3. Realm.java
63 } catch (KrbException ke) {
64 RealmException re = new RealmException(ke.getMessage());
65 re.initCause(ke);
66 throw re;
67 }
I think you make a lot cleanup to exception thrown with just one call,
like the one in KerberosPrincipal.java:
-IOException
On 6/15/2012 12:19 PM, Weijun Wang wrote:
>
>
> On 06/15/2012 10:28 AM, Xuelei Fan wrote:
>> Looks fine to me. Just some minor comments.
>>
>> 1. PrincipalName.java
>> need to make it more clear that PrincipalName is not only for the name
>> of a principal, but also include the realm.
>>
>> - 48
On 06/15/2012 10:28 AM, Xuelei Fan wrote:
Looks fine to me. Just some minor comments.
1. PrincipalName.java
need to make it more clear that PrincipalName is not only for the name
of a principal, but also include the realm.
- 48 * This class encapsulates a Kerberos principal.
+ 48 * This cla
Looks fine to me. Just some minor comments.
1. PrincipalName.java
need to make it more clear that PrincipalName is not only for the name
of a principal, but also include the realm.
- 48 * This class encapsulates a Kerberos principal.
+ 48 * This class encapsulates a Kerberos principal,
+ *
Looks fine to me.
Xuelei
On 6/15/2012 12:10 AM, Sean Mullan wrote:
> Xuelei or Vinnie could you please review the following fix:
>
> http://cr.openjdk.java.net/~mullan/webrevs/7176326/
>
> The bug has not been posted yet, so I've included the relevant details
> below. It is a small regression i
Changeset: 505455116320
Author:mduigou
Date: 2012-06-13 16:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/505455116320
7173919: Minor optimization of hashing methods
Summary: several minor optimizations to hashing methods used by hash map classes
Reviewed-by: dholmes
! sr
Changeset: 28588ace1fb9
Author:lancea
Date: 2012-06-14 15:05 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9
7145913: CachedRowSetSwriter.insertNewRow() throws SQLException
Reviewed-by: joehw, naoto, psandoz, forax
! src/share/classes/com/sun/rowset/internal/Cach
Xuelei or Vinnie could you please review the following fix:
http://cr.openjdk.java.net/~mullan/webrevs/7176326/
The bug has not been posted yet, so I've included the relevant details
below. It is a small regression introduced by my changes for JEP 124
(6854712).
Also, I have moved the existi
Changeset: 4f99d146fce0
Author:alanb
Date: 2012-06-14 12:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f99d146fce0
7176630: (sc) SocketChannel.write does not write more than 128k when channel
configured blocking [win]
Reviewed-by: khazra, chegar
! src/windows/native/su
On 6/14/2012 5:55 PM, Weijun Wang wrote:
>> I can accept your current design if you won't like to make more changes.
>> I may be able to complete the review tomorrow.
>
> Please go on. I think we agree on the basic idea that name and realm
> should be bound in a single class. The only disagreement
On 06/14/2012 05:26 PM, Xuelei Fan wrote:
It's really confusing to mix the name of a principal and realm of a
principal in the same PrincipalName class.
For example, when printing a debug log for "sname", from the name of
"sname", I think it a name of the principal, but the output also include
It's really confusing to mix the name of a principal and realm of a
principal in the same PrincipalName class.
For example, when printing a debug log for "sname", from the name of
"sname", I think it a name of the principal, but the output also include
the realm of the principal.
When I read the
12 matches
Mail list logo
