Re: [PATCH] Review request for 7195733 TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing

2012-09-04 Thread Weijun Wang
I don't update copyright years myself also these days. Not all changes in JDK 8 will be backported to 7u, so if you always update copyright years, some patch won't apply smoothly. For example, you made a change in 2011, the patch is - 2010 + 2011 you made another change to the same file in 2

hg: jdk8/tl/jdk: 7195519: OutOfMemoryError in docs build after 7151010

2012-09-04 Thread jonathan . gibbons
Changeset: 7dda50fe8e1c Author:jjg Date: 2012-09-04 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dda50fe8e1c 7195519: OutOfMemoryError in docs build after 7151010 Reviewed-by: darcy ! make/docs/Makefile

Re: [PATCH] Review request for 7195733 TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing

2012-09-04 Thread Brad Wetmore
On 9/3/2012 3:20 AM, Alan Bateman wrote: On 03/09/2012 11:02, Eric Wang wrote: Hi Chris and Xuelei, Thanks for your advice, I have updated the @run tag and copyright, please help to review. and Thank you to be my sponsor. http://dl.dropbox.com/u/90659131/fixes/7195733/webrev/index.html Looks

Code review request: 4647343: IDENT variable in sun.security.x509 classes not used

2012-09-04 Thread Jason Uh
Hi all, This change addresses -- 4647343: IDENT variable in sun.security.x509 classes not used The x509 CertificateIssuerUniqueIdentity and CertificateSubjectUniqueIdentity classes have been removed and X509CertInfo now makes use of the UniqueIdentity class directly instead. CR: http://bugs.

hg: jdk8/tl/jdk: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value

2012-09-04 Thread staffan . larsen
Changeset: 3338019fda8a Author:sla Date: 2009-06-19 16:50 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3338019fda8a 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value Reviewed-by: alanb, dholmes, sla Contributed-by: Dmytro Sheyko ! src/windows/nati

Re: Code review request for JEP-121

2012-09-04 Thread Vincent Ryan
Thanks Valerie. I'd addressed your comments except the first one. Since RC4 is a stream cipher and RC2 is a block cipher they are handled slightly differently. It would be possible to re-factor this code to simplify it but I'd like to leave that for later as I'm under pressure to meet the next p

Re: Spec review of JEP 114: TLS Server Name Indication (SNI) Extension

2012-09-04 Thread Chris Hegarty
Xuelei, Thanks for addressing my comments. This looks fine to me. -Chris. On 04/09/12 06:01, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7068321/webrev_spec.10/ On 9/3/2012 9:22 PM, Chris Hegarty wrote: Xuelei, This looks very good. Just a few minor comments: - SNIServer

hg: jdk8/tl/jdk: 7195733: TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing

2012-09-04 Thread xuelei . fan
Changeset: b7b33a3c9df0 Author:xuelei Date: 2012-09-04 02:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7b33a3c9df0 7195733: TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing Reviewed-by: chegar, alanb, xuelei Contributed-by