Re: run regression tests from testlist

2012-09-12 Thread Eric Wang
Hi Amy & Max, Below are the results of security tests from ProblemList, there are 4/18 tests are failed on Solaris sparc and 1 test failed on Suse Linux. please check the hightlight batches. Linux64 agentvm http://aurora.ru.oracle.com//faces/Batch.xhtml?batchName=98653.CORELIBS-JDK8-NIGHTLY-

Re: 7u10 Request for review: 7054918, 7055362, 7055363

2012-09-12 Thread Weijun Wang
jdk_security2 should use agenvm mode now. I'll make this change. Same with jdk_security3. I see no other problem. Thanks Max 7055363 -- jdk_security3 test target cleanup Webrev: http://cr.openjdk.java.net/~juh/7055363/webrev.7u.00/ JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Stephen Flores
Vincent, It seems like we are work on same area, except I have a larger scope. The JSSE is not the only package to have sun.security.ec dependencies, PKCS 11 has them plus the Public and private key class and the EC unit test. I have same type of changes in mind so I can remove the duplicate

Re: Quick Codereview

2012-09-12 Thread Valerie (Yu-Ching) Peng
The enhanced test is run for all platforms, right? However, the particular test for the PKCS11 using Solaris crypto library is platform specific. So, it seems kind of strange to have them in the same test which runs on all platforms. In addition, I don't see a need for testing this UnsatisfiedLi

hg: jdk8/tl/jdk: 2 new changesets

2012-09-12 Thread sean . mullan
Changeset: 7a16cd3bd2d9 Author:mullan Date: 2012-09-12 15:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a16cd3bd2d9 7196593: java.security.debug=help doesn't list certpath option Reviewed-by: mullan, wetmore, valeriep Contributed-by: jason...@oracle.com ! src/share/clas

Re: Quick Codereview

2012-09-12 Thread Sean Mullan
Looks good to me. --Sean On 09/12/2012 03:39 AM, Brad Wetmore wrote: Valerie/Sean, Here's the change for JDK8. 7197071: Makefiles for various security providers aren't including the default manifest. I've added the standard/regular rt.jar attributes (see common/Release.gmk) to the remainder

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Michael StJohns
Sorry - additional comment. I think this one needs to be entered as a bug as it needs to be fixed both places. In encodePoint at 426,427 int n = (data.length -1 ) / 2; // fix component size calculation. if ( n != ((curve.getField().getFieldSize() + 7 ) >> 3)) { // has to be equal, not just gr

Re: 7u10 Request for review: 7054918, 7055362, 7055363

2012-09-12 Thread Jason Uh
I actually sent the request for review for the closed tests at the same time. Did you not receive it? Jason On 09/12/2012 05:28 AM, Weijun Wang wrote: > Also, remember to also backport the code changes in the jdk/test/closed repo > for the same CRs. They should be fixed at the same time. > > -M

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Michael StJohns
At 06:31 AM 9/12/2012, Vincent Ryan wrote: >>Also, instead of the function trimZeroes, how about instead a >>"static byte getMagnitude (BigInteger val, int magSize)" method which is >>really what you're trying to do. Still throw the RuntimeError, but do it >>inside that method. This is a meth

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Michael StJohns
At 06:31 AM 9/12/2012, Vincent Ryan wrote: >>Also, instead of the function trimZeroes, how about instead a >>"static byte getMagnitude (BigInteger val, int magSize)" method which is >>really what you're trying to do. Still throw the RuntimeError, but do it >>inside that method. This is a meth

Re: 7u10 Request for review: 7054918, 7055362, 7055363

2012-09-12 Thread Weijun Wang
Also, remember to also backport the code changes in the jdk/test/closed repo for the same CRs. They should be fixed at the same time. -Max 在 Sep 12, 2012,2:06 PM, Jason Uh 写道: > > > On 09/11/2012 09:41 PM, Xuelei Fan wrote: >> Hi Jason, >> >> Thanks for take care of this. I only reviewed a f

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Vincent Ryan
On 09/11/12 06:06 PM, Michael StJohns wrote: There's a number of places where Arrays.copyOfRange might be a better choice than System.arraycopy and the various array creations - if only for readability. I'll use Arrays.copyOfRange as you suggest. Also, instead of the function trimZeroes,

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Vincent Ryan
Thanks. On 09/12/12 11:17 AM, Xuelei Fan wrote: On 9/12/2012 6:13 PM, Vincent Ryan wrote: The only standardized name is the object identifier. Any other names are just user-friendly aliases which may not be supported by all implementations. Good. Let's do it later if user-friendly aliases is

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Xuelei Fan
On 9/12/2012 6:13 PM, Vincent Ryan wrote: > The only standardized name is the object identifier. Any other names are > just user-friendly aliases which may not be supported by all > implementations. > Good. Let's do it later if user-friendly aliases is used in other providers. Looks fine to me.

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Vincent Ryan
The only standardized name is the object identifier. Any other names are just user-friendly aliases which may not be supported by all implementations. On 09/12/12 05:02 AM, Xuelei Fan wrote: ECGenParameterSpec.getName() returns "the standard or predefined name". What's the form of standard na

Re: JDK 8 Code Review Request for 7176627: CertPath/jep124/PreferCRL_SoftFail test fails (Could not determine revocation status)

2012-09-12 Thread Xuelei Fan
RevocationChecker.java: line 473: We may only want to save the first exception. 473 if (softFail && nfe == null && line 530 to 540: "nfe" is not null means it is to ignore network failure. I think we may not want to check the network failure before verifyWithSepara

Quick Codereview

2012-09-12 Thread Brad Wetmore
Valerie/Sean, Here's the change for JDK8. 7197071: Makefiles for various security providers aren't including the default manifest. I've added the standard/regular rt.jar attributes (see common/Release.gmk) to the remainder of the JCE jars (see javax/crypto/Makefile and com/sun/crypto/provider/