hg: jdk8/tl/jdk: 8000206: Uninitialized variable in PlainDatagramSocketImpl.c

2012-10-19 Thread chris . hegarty
Changeset: 27f854a1e5c5 Author:chegar Date: 2012-10-19 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27f854a1e5c5 8000206: Uninitialized variable in PlainDatagramSocketImpl.c Reviewed-by: dsamersoff, khazra, chegar Contributed-by: John Zavgren john.zavg...@oracle.com

Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-19 Thread John Zavgren
Greetings: The following webrev image contains a fix for a memory leak that occurs in the procedure: Java_com_sun_security_auth_module_UnixSystem_getUnixInfo (JNIEnv *env, jobject obj) in the file: jdk/src/solaris/native/com/sun/security/auth/module/Unix.c

Re: bug fix for native kerberos libraries

2012-10-19 Thread Christos Zoulas
On Oct 19, 8:50am, chris...@zoulas.com (Christos Zoulas) wrote: -- Subject: Re: bug fix for native kerberos libraries Hi Weijun, I verified that setting -Djavax.security.auth.useSubjectCredsOnly=false fixes this issue, but then unless I brought in my other patch from jdk6, I get:

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-19 Thread Brad Wetmore
Looks good, taken in isolation. Just to be sure, are there any other methods that might return some object that has to be freed. Brad On 10/19/2012 1:28 PM, John Zavgren wrote: Greetings: The following webrev image contains a fix for a memory leak that occurs in the procedure:

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-19 Thread John Zavgren
Brad: I'm not sure that I completely understand your question, because this is C code and there are no objects involved. Nevertheless, I read through the procedures that are defined in this particular file (Unix.c) and balanced their memory allocations (malloc(), calloc()) against their memory

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-19 Thread Bradford Wetmore
Yes, that's what I meant. Just that none of the other functions alloc'd memory internally that you had to manually free. Thanks for checking. Brad On 10/19/2012 5:54 PM, John Zavgren wrote: Brad: I'm not sure that I completely understand your question, because this is C code and there are