Code review request: 8001208: Fix for KRB5CCNAME not complete

2012-10-21 Thread Weijun Wang
Please take a look at http://cr.openjdk.java.net/~weijun/8001208/webrev.00/ An old test is enhanced to check for the fix. Honestly, it might be best to check for KRB5CCNAME outside FileCredentialsCache since the ccache type can be something other than FILE:. It will touch more files and I

Re: bug fix for native kerberos libraries

2012-10-21 Thread Weijun Wang
But are you using MEMORY: type ccache in your case? If I understand correctly, the substring after MEMORY: is not a normal file name. It's a tag that links to a block of bytes stored in the memory that must be accessed with native calls. I'll not support it at the moment. Thanks Weijun On 10

Re: bug fix for native kerberos libraries

2012-10-21 Thread Christos Zoulas
On Oct 22, 11:33am, weijun.w...@oracle.com (Weijun Wang) wrote: -- Subject: Re: bug fix for native kerberos libraries | I forgot to ask: | | Your patch mentioned MEMORY: ccache. What is the full string? Is that | any document on it? It was in my patch: > + * http://docs.oracle

Re: bug fix for native kerberos libraries

2012-10-21 Thread Weijun Wang
I forgot to ask: Your patch mentioned MEMORY: ccache. What is the full string? Is that any document on it? Thanks Weijun On 10/22/2012 11:29 AM, Weijun Wang wrote: On 10/22/2012 11:10 AM, chris...@zoulas.com wrote: On Oct 22, 10:54am, weijun.w...@oracle.com (Weijun Wang) wrote: -- Subject

Re: bug fix for native kerberos libraries

2012-10-21 Thread Weijun Wang
On 10/22/2012 11:10 AM, chris...@zoulas.com wrote: On Oct 22, 10:54am, weijun.w...@oracle.com (Weijun Wang) wrote: -- Subject: Re: bug fix for native kerberos libraries | I see. So it looks like the MS tool is calling JAAS. Is it asking you to | prepare a JAAS login file like this? | | cli

Re: bug fix for native kerberos libraries

2012-10-21 Thread Christos Zoulas
On Oct 22, 10:54am, weijun.w...@oracle.com (Weijun Wang) wrote: -- Subject: Re: bug fix for native kerberos libraries | I see. So it looks like the MS tool is calling JAAS. Is it asking you to | prepare a JAAS login file like this? | | client { |com.sun.security.auth.module.Krb5Login

Re: bug fix for native kerberos libraries

2012-10-21 Thread Weijun Wang
I see. So it looks like the MS tool is calling JAAS. Is it asking you to prepare a JAAS login file like this? client { com.sun.security.auth.module.Krb5LoginModule required ...; }; You can put a key-value pair ticketCache=ccache_file inside it where ccache_file is the KRB5CCN

hg: jdk8/tl/jdk: 8001204: typo: Unable to obtain Princpal Name for authentication

2012-10-21 Thread weijun . wang
Changeset: b39ab9c6f4cb Author:weijun Date: 2012-10-22 09:59 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b39ab9c6f4cb 8001204: typo: Unable to obtain Princpal Name for authentication Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java

Re: Code review request: 8001204: typo: Unable to obtain Princpal Name for authentication

2012-10-21 Thread Xuelei Fan
Looks fine to me. Xuelei On 10/22/2012 8:34 AM, Weijun Wang wrote: > A simple typo fix: > >http://cr.openjdk.java.net/~weijun/8001204/webrev.00/ > > It's just > > --- a/src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java > +++ b/src/share/classes/com/sun/security/auth/modul

Re: bug fix for native kerberos libraries

2012-10-21 Thread Christos Zoulas
On Oct 22, 8:17am, weijun.w...@oracle.com (Weijun Wang) wrote: -- Subject: Re: bug fix for native kerberos libraries | You are still using JAAS? There is no need to call Krb5LoginModule or | read credentials cache yourself if you are using native kerberos. Just | call JGSS APIs directly. | | T

Code review request: 8001204: typo: Unable to obtain Princpal Name for authentication

2012-10-21 Thread Weijun Wang
A simple typo fix: http://cr.openjdk.java.net/~weijun/8001204/webrev.00/ It's just --- a/src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java +++ b/src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java @@ -802,7 +802,7 @@ if (doNotPrompt) {

Re: bug fix for native kerberos libraries

2012-10-21 Thread Weijun Wang
You are still using JAAS? There is no need to call Krb5LoginModule or read credentials cache yourself if you are using native kerberos. Just call JGSS APIs directly. Thanks Weijun On 10/19/2012 11:17 PM, chris...@zoulas.com wrote: On Oct 19, 8:50am, chris...@zoulas.com (Christos Zoulas) wrot