Re: Code review request, JDK-8001569 Regression test GetPeerHost uses static port number

2012-11-09 Thread Brad Wetmore
I'm surprised we are still finding these! ;) I though we had fixed most of them already. Maybe whoever fixed them was looking for 443/80/8080, and missed ? Brad On 11/9/2012 1:20 AM, Chris Hegarty wrote: Looks fine Xuelei. -Chris. On 09/11/2012 05:27, Xuelei Fan wrote: webrev: http

Re: [PATCH FOR REVIEW] Allow multiple initialisation of NSS with different library directories to be a non-criticial error

2012-11-09 Thread Vincent Ryan
Hello Andrew, The code changes look fine. I will open a bug for this issue. Is there a testcase available for this new option? Thanks. On 7 Nov 2012, at 18:45, Andrew Hughes wrote: > The PKCS11 provider has an option in its configuration file, > "handleStartupErrors" > that can be used to mak

Re: Code review request, JDK-8001569 Regression test GetPeerHost uses static port number

2012-11-09 Thread Chris Hegarty
Looks fine Xuelei. -Chris. On 09/11/2012 05:27, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net./~xuelei/8001569/webrev.00/ Test case, test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/GetPeerHost.java, uses the static port number, and does not close the socket explicitl

hg: jdk8/tl/jdk: 8001569: Regression test GetPeerHost uses static port number

2012-11-09 Thread xuelei . fan
Changeset: 9edfa0e761b9 Author:xuelei Date: 2012-11-09 01:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9edfa0e761b9 8001569: Regression test GetPeerHost uses static port number Reviewed-by: weijun ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/Ge

Re: Code review request, JDK-8001569 Regression test GetPeerHost uses static port number

2012-11-09 Thread Weijun Wang
Looks good. Never heard of noreg-tests, I use noreg-self. See [1]. -Max [1] http://javaweb.sfbay.sun.com/j2se/eng/guidelines/putbacks On 11/09/2012 01:27 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net./~xuelei/8001569/webrev.00/ Test case, test/sun/security/ssl/com/sun/net/ssl/inte