Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread Xuelei Fan
Good! Mala, thanks you so much for make it happen in JDK 1.5.0 and 1.4.2. It's a busy weekend for you, I appreciate your hardwork on this fix very much! On 12/4/2012 1:25 PM, mala bankal wrote: > Yes there was some problem with the webrev generation , i had to > generate it too many times. OK, th

Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread mala bankal
Yes there was some problem with the webrev generation , i had to generate it too many times. But i made sure all changes are present. Thanks for taking a detailed look into this !! rgds mala On 12/4/2012 10:52 AM, Xuelei Fan wrote: Let's look at the history of the parent workspace; 1. You putb

Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread Xuelei Fan
Let's look at the history of the parent workspace; 1. You putback CR 7192392, Dec 2. 2. David undo the putback, Dec 3, 10:33 3. You bringover the workspace, Dec 3, 10:45 4. The you putback CR 7192392, Dec 3. 11:42 5. Java RE bringover the workspace, maybe for jar building. The processes look right

Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread mala bankal
HI Andrew, No it is not based on previous integration. I brought over a fresh wses after Dave's rollback and made all changes again. Made the changes and built the wses again. It took me more time but i did it right. Now before final integration i checked if changes are present in MASTER ws. rg

Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread Xuelei Fan
It seems that you webrev is based on your previous integration. I may be wrong, but as my previous comment, I think as David has rollover your previous integration, you need to rollover the changes in your local workspace as well, or bringover new workspace, and then generate the webrev, and then

Re: Code Review Request, 8004184, security tests leave JSSEServer running

2012-12-03 Thread Brad Wetmore
Looks ok to me too. Brad On 12/2/2012 5:28 PM, Xuelei Fan wrote: On 12/2/2012 11:38 PM, Chris Hegarty wrote: Your description talks about releasing resources, but the comment in the source mentions initialising system properties. Are you using othervm mode to get around releasing resources o

Code Review Request: 8004188: Rename src/share/lib/security/java.security to java.security-linux

2012-12-03 Thread Jason Uh
Could I please get a review of http://cr.openjdk.java.net/~juh/8004188/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004188 This change renames src/share/lib/security/java.security to java.security-linux to avoid confusion. The Makefile has been updated to accommodate th

hg: jdk8/tl/jdk: 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout

2012-12-03 Thread sean . mullan
Changeset: ee9846f351d7 Author:mullan Date: 2012-12-03 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee9846f351d7 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Summary: Added com.sun.security.ocsp.timeout system propert

hg: jdk8/tl/jdk: 8004184: security tests leave JSSEServer running

2012-12-03 Thread xuelei . fan
Changeset: ead651efb271 Author:xuelei Date: 2012-12-03 06:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead651efb271 8004184: security tests leave JSSEServer running Summary: Use othervm mode to release resources, and correct the system properties issues in JSSE Reviewe

Re: Code Review Request, 8004184, security tests leave JSSEServer running

2012-12-03 Thread Xuelei Fan
Thanks, Chris! Xuelei On 12/3/2012 5:34 PM, Chris Hegarty wrote: > OK, if this resolves this issue, then I'm fine with it. > > -Chris. > > On 03/12/2012 01:28, Xuelei Fan wrote: >> On 12/2/2012 11:38 PM, Chris Hegarty wrote: >>> Your description talks about releasing resources, but the comment

Re: Code Review Request, 8004184, security tests leave JSSEServer running

2012-12-03 Thread Chris Hegarty
OK, if this resolves this issue, then I'm fine with it. -Chris. On 03/12/2012 01:28, Xuelei Fan wrote: On 12/2/2012 11:38 PM, Chris Hegarty wrote: Your description talks about releasing resources, but the comment in the source mentions initialising system properties. Are you using othervm mode

hg: jdk8/tl/jdk: 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten

2012-12-03 Thread weijun . wang
Changeset: a42da685dfca Author:weijun Date: 2012-12-03 17:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42da685dfca 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh