Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-17 Thread Brad Wetmore
Hi Xuelei, Minor stuff. A couple things to check. Xuelei wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ JEP 115: http://openjdk.java.net/jeps/115 I looked at webrev.0

hg: jdk8/tl/jdk: 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times

2013-01-17 Thread stuart . marks
Changeset: 79fed1733d4a Author:jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number

hg: jdk8/tl/jdk: 7171415: java.net.URI.equals/hashCode not consistent for some URIs

2013-01-17 Thread kurchi . subhra . hazra
Changeset: e8414d69692c Author:khazra Date: 2013-01-17 14:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8414d69692c 7171415: java.net.URI.equals/hashCode not consistent for some URIs Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed by vita..

hg: jdk8/tl/jdk: 8006090: Formatter asserts with -esa

2013-01-17 Thread xueming . shen
Changeset: 787c7c1c210f Author:sherman Date: 2013-01-17 12:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/787c7c1c210f 8006090: Formatter asserts with -esa Summary: removed the offending assert Reviewed-by: alanb, darcy Contributed-by: brian.burkhal...@oracle.com ! src/sh

hg: jdk8/tl/langtools: 8005852: Treatment of '_' as identifier

2013-01-17 Thread maurizio . cimadamore
Changeset: 2d2b2be57c78 Author:mcimadamore Date: 2013-01-17 18:15 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/

[8] Code review request for 6263419: No way to clean the memory for a java.security.Key

2013-01-17 Thread Vincent Ryan
Hello, Please review the fix for 6263419. It introduces a mechanism to destroy the sensitive data associated with private keys and secret keys. It is a component of the JEP-166 delivery. Webrev: http://cr.openjdk.java.net/~vinnie/6263419/webrev.00/ Implementers of JCE security providers can ove

Re: Update #4: JEP 123: SecureRandom Draft and Implementation.

2013-01-17 Thread Xuelei Fan
Hi Brad, Please note the priorities for each comment. As the M6 is coming, you can only take P1 comments. P1: need to update P2: suggested update, you can take it after M6. P3: minor comments, it's OK to leave it unchanged. P4: personal preference for your consideration, or my question. java/sec