Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-19 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.03/ A significant update of CipherBox.java. We are not able to know whether a cipher for a particular key size is available or not until the cipher is successfully initialized. For example, we can get instance for "AES/GCM/NoPadding". Bu

hg: jdk8/tl/jdk: 8005080: JDBC 4.2 Core changes

2013-01-19 Thread lance . andersen
Changeset: d3da0d29d7cd Author:lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.ja

hg: jdk8/tl/jdk: 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl

2013-01-19 Thread lance . andersen
Changeset: 78514544980d Author:lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/row

Re: [8] Code review request for 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-19 Thread Weijun Wang
On Jan 19, 2013, at 20:24, Vincent Ryan wrote: > > On 19/01/2013 09:43, Weijun Wang wrote: >> Also, although we haven't standardized the keystore types, there is >> still a possibility that different providers using the same storetype >> name. How can we ensure everyone honoring the security p

Re: [8] Code review request for 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-19 Thread Vincent Ryan
On 19/01/2013 09:43, Weijun Wang wrote: Also, although we haven't standardized the keystore types, there is still a possibility that different providers using the same storetype name. How can we ensure everyone honoring the security property? If another JCE provider uses the same keystore typ

Re: [8] Code review request for 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-19 Thread Weijun Wang
Also, although we haven't standardized the keystore types, there is still a possibility that different providers using the same storetype name. How can we ensure everyone honoring the security property? Max On Jan 19, 2013, at 17:28, Weijun Wang wrote: > > > +/** > + * Gets

Re: [8] Code review request for 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-19 Thread Weijun Wang
+/** + * Gets the name of the protection algorithm. + * If none was set then the default algorithm name is returned. + * The default algorithm name for a given keystore type is set using the + * {@code 'keystore..entryProtectionAlgorithm'} Security proper

hg: jdk8/tl/jdk: 8006568: HTTP protocol handler NLTM Authentication should use Base64 API

2013-01-19 Thread chris . hegarty
Changeset: 33d0175ea8d9 Author:msheppar Date: 2013-01-19 08:39 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33d0175ea8d9 8006568: HTTP protocol handler NLTM Authentication should use Base64 API Reviewed-by: chegar, alanb ! src/solaris/classes/sun/net/www/protocol/http/ntlm

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-19 Thread Bradford Wetmore
EngineOutputRecord.java === 294/296: Another great comment. I might suggest reversing the comments so that the comment about AEAD is in the AEAD arm, and CBC is outside. I'm not sure I catch your ideas. ;-) Would you please show me the code? Just a simple reversal of th