hg: jdk8/tl/langtools: 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model

2013-01-23 Thread joe . darcy
Changeset: 09f65aad4759 Author:darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/eleme

hg: jdk8/tl/jdk: 8006813: Compilation error in PKCS12KeyStore.java

2013-01-23 Thread sean . mullan
Changeset: 89f37f7188df Author:mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java

Re: URGENT Code Review Request for JDK-8006813: Compilation error in PKCS12KeyStore.java

2013-01-23 Thread Valerie (Yu-Ching) Peng
Change looks good. Thanks, Valerie On 01/23/13 17:42, Sean Mullan wrote: Valerie, can you please review the following fix: http://cr.openjdk.java.net/~mullan/webrevs/8006813/webrev.00/ Thanks, Sean

URGENT Code Review Request for JDK-8006813: Compilation error in PKCS12KeyStore.java

2013-01-23 Thread Sean Mullan
Valerie, can you please review the following fix: http://cr.openjdk.java.net/~mullan/webrevs/8006813/webrev.00/ Thanks, Sean

hg: jdk8/tl/jdk: 8005408: KeyStore API enhancements

2013-01-23 Thread vincent . x . ryan
Changeset: 1da93663f8f3 Author:vinnie Date: 2013-01-23 23:13 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/java/security/PKCS12Attribute.j

hg: jdk8/tl/jdk: 6519127: user.home property not set correctly

2013-01-23 Thread alexey . utkin
Changeset: 01b36b400145 Author:uta Date: 2013-01-23 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b36b400145 6519127: user.home property not set correctly Summary: Registry-based approach was changed to SHGetKnownFolderPath/SHGetFolderPathW Reviewed-by: alanb, antho

hg: jdk8/tl/langtools: 8006775: JSR 308: Compiler changes in JDK8

2013-01-23 Thread jonathan . gibbons
Changeset: 71f35e4b93a5 Author:jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mer...@cs.washington.edu, wmdi...@cs.washington.edu, mp...@csail.mit.edu, m

hg: jdk8/tl/jdk: 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-23 Thread vincent . x . ryan
Changeset: 0c86df653029 Author:vinnie Date: 2013-01-23 21:25 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java ! src/share/classes/su

hg: jdk8/tl/langtools: 8006694: temporarily workaround combo tests are causing time out in several platforms

2013-01-23 Thread vicente . romero
Changeset: 5c956be64b9e Author:vromero Date: 2013-01-23 20:57 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.c

Re: [8] Code review request for 8005408: KeyStore API enhancements

2013-01-23 Thread Vincent Ryan
Thanks for your comments Michael. Your suggestions involve API changes that I cannot accommodate in time for Milestone 6. I will address these issues following M6 and have filed the following bug report to track that task: 8006796: Address additional review comments for 8005408 BTW the curren

hg: jdk8/tl/jdk: 2 new changesets

2013-01-23 Thread xueming . shen
Changeset: e0552f13f4a2 Author:sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb ! test/java/util/zip/ZipF

Re: [8] Code review request for 8005408: KeyStore API enhancements

2013-01-23 Thread Michael StJohns
In KeyStore.java - Attribute should probably be abstract rather than interface - mainly because you need to define equals properly to honor the Set contract for an attribute. E.g. the equals is only against the "name" - not the encoded name/value. This can be overridden later. In PKCS12Attri

Re: [8] Code review request for 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-23 Thread Sean Mullan
Just one comment: 1. In PasswordProtection.getAlgorithm(), I'd recommend adding the following sentence: "If this security property is not set, an implementation-specific algorithm will be used." --Sean On 01/22/2013 06:18 PM, Vincent Ryan wrote: Last call and an updated webrev that includ

Re: [8] Code review request for 8005408: KeyStore API enhancements

2013-01-23 Thread Vincent Ryan
Thanks for those comments Sean. On 22 Jan 2013, at 21:22, Sean Mullan wrote: > Final set of comments in this webrev: > > PKCS12KeyStore.java > > [214] Minor comment, but I think it would be cleaner to create separate > SecretKeyEntry and PrivateKeyEntry classes. > I did consider that origina

hg: jdk8/tl/jdk: 8006764: FunctionalInterface missing from rt.jar (old build)

2013-01-23 Thread alan . bateman
Changeset: 53064bbaeec5 Author:alanb Date: 2013-01-23 15:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk

hg: jdk8/tl/langtools: 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile

2013-01-23 Thread maurizio . cimadamore
Changeset: 97bd5e7151bc Author:mcimadamore Date: 2013-01-23 15:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-

hg: jdk8/tl/jdk: 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

2013-01-23 Thread chris . hegarty
Changeset: bf2a14ebb6e9 Author:chegar Date: 2013-01-23 14:45 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ssl/sun/ne

Re: RFR(XS) 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

2013-01-23 Thread Alan Bateman
On 22/01/2013 15:04, Chris Hegarty wrote: These tests started failing recently on some mac machines. They appear to hang and timeout. FAILED: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh FAILED: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/

hg: jdk8/tl/jdk: 8006741: javadoc cleanup for 6263419

2013-01-23 Thread vincent . x . ryan
Changeset: 71691b9d45ab Author:vinnie Date: 2013-01-23 09:49 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java

[8] 8006741: javadoc cleanup for 6263419

2013-01-23 Thread Vincent Ryan
FYI this is a minor correction to javadoc tag: Webrev: http://cr.openjdk.java.net/~vinnie/8006741/webrev.00/